Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <0ea7559b-8e9f-5c85-87eb-0bcf5fddef10@canonical.com>
Date:   Fri, 4 Mar 2022 09:42:58 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: mmotm 2022-03-03-21-24 uploaded
 (security/apparmor/policy_unpack.o)
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>, broonie@kernel.org,
        mhocko@suse.cz, sfr@canb.auug.org.au, linux-next@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org
Cc:     apparmor@lists.ubuntu.com
References: <20220304052444.C157EC340E9@smtp.kernel.org>
 <217ec524-7ade-7e1f-b81a-4a9a3ff90397@infradead.org>
From:   John Johansen <john.johansen@canonical.com>
Organization: Canonical
In-Reply-To: <217ec524-7ade-7e1f-b81a-4a9a3ff90397@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/4/22 09:32, Randy Dunlap wrote:
> 
> 
> On 3/3/22 21:24, Andrew Morton wrote:
>> The mm-of-the-moment snapshot 2022-03-03-21-24 has been uploaded to
>>
>>    https://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> https://www.ozlabs.org/~akpm/mmotm/
>>
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
>>
>> You will need quilt to apply these patches to the latest Linus release (5.x
>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
>> https://ozlabs.org/~akpm/mmotm/series
> 
> on x86_64:
> 
> ld: security/apparmor/policy_unpack.o: in function `deflate_compress':
> mmotm-2022-0303-2124/X64/../security/apparmor/policy_unpack.c:1069: undefined reference to `zlib_deflate_workspacesize'
> ld: mmotm-2022-0303-2124/X64/../security/apparmor/policy_unpack.c:1075: undefined reference to `zlib_deflateInit2'
> ld: mmotm-2022-0303-2124/X64/../security/apparmor/policy_unpack.c:1092: undefined reference to `zlib_deflate'
> ld: mmotm-2022-0303-2124/X64/../security/apparmor/policy_unpack.c:1122: undefined reference to `zlib_deflateEnd'
> 
> 
> 
> Full randconfig file is attached.
> 

yes thanks for the report,

the fix is already baking in apparmor-next
c2489617b3b9 apparmor: Fix undefined reference to `zlib_deflate_workspacesize'

this happens when CONFIG_SECURITY_APPARMOR_EXPORT_BINARY is not set and hence ZLIB_INFLATE/DEFLATE aren't selected and the kernel is configed without them. Basically some blocks of code need to be wrapped in #ifdef.