Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <bc41bc12-0d88-771f-7e78-4e29361fcfd8@intel.com>
Date:   Fri, 4 Mar 2022 08:45:20 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.5.0
Subject: Re: [PATCH v2 1/2] Documentation: fpga: dfl: add PCI Identification
 documentation
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, <matthew.gerlach@linux.intel.com>,
        <hao.wu@intel.com>, <yilun.xu@intel.com>,
        <basheer.ahmed.muddebihal@intel.com>, <mdf@kernel.org>,
        <corbet@lwn.net>, <linux-fpga@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <dan.j.williams@intel.com>, <ashok.raj@intel.com>,
        <tianfei.zhang@intel.com>
References: <20220303003534.3307971-1-matthew.gerlach@linux.intel.com>
 <20220303003534.3307971-2-matthew.gerlach@linux.intel.com>
 <6448f21f-7ce1-d9ce-1048-29aca14f9d3d@redhat.com>
From:   Russ Weight <russell.h.weight@intel.com>
In-Reply-To: <6448f21f-7ce1-d9ce-1048-29aca14f9d3d@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXNIWVVsaGt4MlEwTVRWRnNMeXlzWnlwTm51TG91aTNvQU4xZXpoR0laVE1q?=
 =?utf-8?B?Y1h3dlBxL2UwYkFNYXJzNDZiTmpUWDNZMDNwb3VPOFRDbHoxWlpSY2J6L3NB?=
 =?utf-8?B?d3NkSGlsTHk4WWRHZWJYU2tzN3Z5a2NhbnQ4RWhkWnZyY2dtM2lVTHdXZnBR?=
 =?utf-8?B?cEs1YkkyY1lXQ2lrblJwNTI0bUt4VWRQei9MdFpOaEhDWHplbVpqTmt0Z0Rx?=
 =?utf-8?B?ekhsL3RjL294MGxZTXpTdjgxUEE1TE1uWXBjMDB6MDltNzE1QTMrT1lUOGk1?=
 =?utf-8?B?Ync1SkdLRXJjaDk0bFJoNUxTNEt0UFFNeFNDR0JmdWtuSjM5S1VySWdjR3k0?=
 =?utf-8?B?UDQySGNnME1PNTh0cUV5WkxIUUxVYnlzdHdHRThYUjJHeU80ZjFqbDRwUUMw?=
 =?utf-8?B?ZWlTZERWZW5TcGRiNXdLSDlSeTFGNUI1YWlzaGJCK2JwWWJDcTRINnAzc09N?=
 =?utf-8?B?bVJQMEV6eURvQVNRVC9zWjIrYTNmMGt0Rmo1ZTQva2RLUHYvLzcvNnNtOTlp?=
 =?utf-8?B?dDVMclFmbkxKK01PMk9MTEQvS2hFcTFIUlZOQ3lnL3Y3WkpZT3lrbHd6Z1pY?=
 =?utf-8?B?bTBDQlVTTHBOYlBUTnp5ckJ5NFAxWGYyenNkU0NBdUpnVERBZkRYKzBxZEdE?=
 =?utf-8?B?K2k1alZRekZMWVF5Zk9kREpZZkdxdWMySHNHa3h1bDZqK0YxVDJsdGZBRGYr?=
 =?utf-8?B?ZDhzcXpSTlIrL09ZWUZtSFRPOW1TNkxtVVFtMW5TN0lJUEwwMDNhcEh1WXZT?=
 =?utf-8?B?bHZXY00vQmM1Sit3K3ZBMUhtQzBoSDIzWHcyUWdVRUpTaUliK2RiUUgwSHJO?=
 =?utf-8?B?ZzJQdlJFaHRYTFNYMDYrR2hQdFlpd280SjJZdUJDc3d5T2xZOTJxNFlwRDB4?=
 =?utf-8?B?em80MUJhTmZCcGxtcjJINHZ4aC9wWVZwOFJnS1VRWkMvbm9DMGZ6ZjV0c3Uw?=
 =?utf-8?B?WXZWZWJ2OWxXK0M2OWV5dFB0ZWJkdW9zb25zS3ZYNmE3TkpLYXhCNk1Cc0Fq?=
 =?utf-8?B?OWlqL0pTdzNOV1NwanU5dFp3ZWVtcEs5Y0dJY21RRjFEYmVEbUE1cE9TMG5U?=
 =?utf-8?B?TWRFUVRDMWJHSkllUE80Q1I4S3cvTFppNHZwS0pEMElTS0dmczlLSGFhWVZI?=
 =?utf-8?B?VVpsNXRDZzVETXQyd2Z3TmlCdVJQY0F0WmNOYWV0U08zcURUMklPYldLSnpG?=
 =?utf-8?B?bjdhOWFkRk5Hbk9GdWRBeFVNbSthODQvbFhKUzVtVGt6QmhjTFlNRGNDUHNY?=
 =?utf-8?B?Z053NXhDaXFhUkdCWGVsMWFBaGFBVkdvUDl2WGdHZVEwMmRyVi9WK2MwUWc2?=
 =?utf-8?B?TTdpTVlLS05vcVBXN0h1c203ZHVZNlRCR3RmaUROUDFEL0xyYVBjZU1kaEQw?=
 =?utf-8?B?RUdsYkRIb1V2ZjJIS2pXengzUjB1NUNSSHBtZFVQVUtsVU5nQTFJSlZ2T0pq?=
 =?utf-8?B?VStSak1wNkxETWl5bXJTOVA5THQ3eFEvTGVlUy80OE1keVh5b1BQYVpRNGNL?=
 =?utf-8?B?S0NrK3M2OEtqRWJ3LzR1Vk5tNGVIS3BHTVJDUlBDbVB2WW5VdTl1ZzAwUXRj?=
 =?utf-8?B?eUl2enE3NFJlREJzbnhvbHNoRE0zM0d6MmpVUFhKZGFLcmsxQ3dBaGZLZU9O?=
 =?utf-8?B?U1JCeitvQnQxL2VXc1A2RHZFb0tXS0pPUTZwUzIwMWFpeWJXN28zUWlmcDBx?=
 =?utf-8?B?OFB3K3hZTXAwUkExSHlmYmtSMnZVUmVEa2pWLzVyNnlJdHJ5bDNBWk5HQXFz?=
 =?utf-8?B?aVlCWDJBWStTQkhSRUtkSnNqYjd2K203OENJZForeFhOTmUvQWJqVXhiUDFs?=
 =?utf-8?B?RUx3TGlNUncxTUFIS3RFQWhlb3lXYTRoQzFmaTBwamhUSmxmMzZvd0ZyeW5I?=
 =?utf-8?B?WU5lM3BlUXBxc3JmRmp3eWlGendZdVBFSkFZNkhPNXhlRWpGUElocTRXelZy?=
 =?utf-8?B?ZWxpcnY2aDJKRnkzTTdFNVUyUmlFQ1RqaFRtTjJXMlZ2VGp6bEFubW5naS9P?=
 =?utf-8?B?OU5RRkp3RmxncktpL2EzWlV1MEl4TE92SC9SMllQalV1cnFWeU1OcUtzRytK?=
 =?utf-8?B?SmdDNWlOMHl1ckNmb1RyS0tlZnN5Ymh0dzE0dmUxQ1o5bnNSM1VlUmViWlcz?=
 =?utf-8?B?TXZPV0trQUtCWTc2dFpxUjVHcHdIUkJWbnJrb2laUVNKcFBraTgzc3ltYU9S?=
 =?utf-8?B?ZUd0aWY2MElmK3R1R3lXU1VSa09RQXZyK3B4dU9rRnAzelhxbjlVTEZJNGN2?=
 =?utf-8?B?YkR0L0lTY1FhY3V3R2c2SEh4dWRBPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ba71b13f-7f4c-440c-b286-08d9fdfe60dd
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1899.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 16:45:24.0173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: al3hkr26iW17a8tg762AgLeFClC5oPPJMM/le0yx7yjyOGqDBaE1z6RaImkckLH/9WE5rMCZZ8OOBpqg8dIj0uhiFNKnnOKhwt/YK/uy+f0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4598
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/3/22 14:04, Tom Rix wrote:
>
> On 3/2/22 4:35 PM, matthew.gerlach@linux.intel.com wrote:
>> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>>
>> Add documentation on identifying FPGA based PCI cards prompted
>> by discussion on the linux-fpga@vger.kernel.org mailing list.
>>
>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>> ---
>> v2: Introduced in v2.
>> ---
>>   Documentation/fpga/dfl.rst | 20 ++++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>
>> diff --git a/Documentation/fpga/dfl.rst b/Documentation/fpga/dfl.rst
>> index ef9eec71f6f3..5fb2ca8e76d7 100644
>> --- a/Documentation/fpga/dfl.rst
>> +++ b/Documentation/fpga/dfl.rst
>> @@ -502,6 +502,26 @@ Developer only needs to provide a sub feature driver with matched feature id.
>>   FME Partial Reconfiguration Sub Feature driver (see drivers/fpga/dfl-fme-pr.c)
>>   could be a reference.
>>   +PCI Device Identification
>> +================================
>> +Since FPGA based PCI cards can be reconfigured to a perform a completely
>> +new function at runtime, properly identifying such cards and binding the
>> +correct driver can be challenging. In many use cases, deployed FPGA based
>> +PCI cards are essentially static and the PCI Product ID and Vendor ID pair
>> +is sufficient to identify the card.  The DFL framework helps with the
>> +dynamic case of deployed FPGA cards changing at run time by providing
>> +more detailed information about card discoverable at runtime.
>> +
>> +At one level, the DFL on a PCI card describes the function of the card.
>> +However, the same DFL could be instantiated on different physical cards.
>> +Conversely, different DFLs could be instantiated on the same physical card.
>> +Practical management of a cloud containing a heterogeneous set of such cards
>> +requires a PCI level of card identification. While the PCI Product ID and
>> +Vendor ID may be sufficient to bind the dfl-pci driver, it is expected
>> +that FPGA PCI cards would advertise suitable Subsystem ID and Subsystem
>> +Vendor ID values. PCI Vital Product Data (VPD) can also be used for
>> +more granular information about the board.
>
> This describes a bit more of the problem, it should describe it wrt ofs dev id. The introduction of the ofs dev should be explicitly called out as a generic pci id.
>
> Why couldn't one of the old pci id's be reused ?
>
> How will the subvendor/subid be enforced ?
>
> Is the current security manager patchset smart enough to save the board from being bricked when a user doesn't look beyond the pci id ?

Yes - the security manager is invoked based of DFL feature ID and revision, and the functionality is differentiated based on the same information.

>
> What happens if a board uses this device id but doesn't have a max10 to do the update ?
>
> Tom
>
>> +
>>   Location of DFLs on a PCI Device
>>   ================================
>>   The original method for finding a DFL on a PCI device assumed the start of the
>