Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2227947pxm; Fri, 4 Mar 2022 11:51:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJxbbbn0/OlU6ZZSUz/27J6cQiDrJg5F68W6zUAxQFKgPG+Emj88gWS/tBHYMgL1BUc01MaC X-Received: by 2002:a17:902:b103:b0:14f:aa09:f23a with SMTP id q3-20020a170902b10300b0014faa09f23amr44056704plr.25.1646423482897; Fri, 04 Mar 2022 11:51:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646423482; cv=none; d=google.com; s=arc-20160816; b=UE2GzJLvHAAqq/AFcUDlf+V6F60IRIYUHE03Bd/wKYS0HBKhBDblDeAJR5UuXVC454 MPgF4UBY2BG8uI/QhqEj0hEHhvN1OgBGObcE7W5l5UFJTmF4eX/0+IuJwx3MESqzcaAw fdz38VftXjG4mFLDL3gUCw6CZYQ8yaVO2lyN1uMVDw5M0j6b9BNczgctK7n6Tqwr+zgJ TmG0AZT07X2rikAMlSHAEBqn7U0liJm1rnv/kd6f+/yUE2lHjeH0FV+HqLzWSShe95yu KoGl0egvgXSw6zdWUdNE3wolbQQUhMwhyXxiLMBj+LoPBnumGIQiQiu6ZQZLfyqTjTm9 jYng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=86mrUfY2a9ejGUqsBn3YNiqPHJtfi4XwtVYGZkB1VoI=; b=nPPp/fqITxNiHL+3G1c+jRVmgNpRXnRJjX7QCFclZPI0Ta8O3TVOSbQAjn1HRzid1Q /FWs8pkygpjtf3QOM0XJ5fQFqjiMzcxw+kVUtcIYMAFgnCtgCc1ko2BBW1rrX4wKusCs O2Hf5AMK2Cc7DEGmlSAWWg2s4HDDVj9g6DNGw8ct9xWtKAVASNf71F3xXr2OQfptNZKq h3eTB3DZvKzvSfyu7OHkuNVSeJN/WzUNQBAXAmrhm/AUKZ4xn5SPdZCs1ckqP0jLV+P7 nyOb/7f0tIv0lxb3PYrXEZ3yQcTZDdOcpXKfWF42n6BmMALP0bq0mw1Z+AgW3Vxxspfq j1Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Usxcnt/h"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id m1-20020a656a01000000b0034c007d9a43si7308749pgu.400.2022.03.04.11.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 11:51:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Usxcnt/h"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CC76623585F; Fri, 4 Mar 2022 11:20:48 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241278AbiCDRxF (ORCPT + 99 others); Fri, 4 Mar 2022 12:53:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241077AbiCDRws (ORCPT ); Fri, 4 Mar 2022 12:52:48 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C960DF540F for ; Fri, 4 Mar 2022 09:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646416319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=86mrUfY2a9ejGUqsBn3YNiqPHJtfi4XwtVYGZkB1VoI=; b=Usxcnt/h1hIBmCqITwyCvJl/Q3giNCNcP7geVxUIj14ZGgKW7MsgMR0lFz+SqerlUUWJXb 9V5BYUi6LaA5I3OuVbnLOV5Y+YG6nw0hbwTkhJx9iX20qAD0M2TZ7nEcWjJUI+A7y5eFUZ ygG07X6vRbrcc32Xe1a98UImLqvSDwA= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-93-tGefMWhJNB6Lhnwnuageow-1; Fri, 04 Mar 2022 12:51:58 -0500 X-MC-Unique: tGefMWhJNB6Lhnwnuageow-1 Received: by mail-qv1-f72.google.com with SMTP id kj16-20020a056214529000b00435218e0f0dso6963871qvb.3 for ; Fri, 04 Mar 2022 09:51:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=86mrUfY2a9ejGUqsBn3YNiqPHJtfi4XwtVYGZkB1VoI=; b=RQRg94SztjhMXmiZqej2oXGM/fIUNHN4MkTGGOE4uBeJPASi+UZNhUb/sNnESAYfAq nuKV7M+6/ly61pds3YO63vYNp9fl1B8EXxR3HRmvFKY8QM8pvvr8V8lQtDieGY7BfgQv Vs6u6pXzgiVSXUwaeI1FFWi3h3kwD7UScszbY1m7e8ZgLkbWIVUvCk3PFuodcNydrCy8 jgyFQz1IAHymBTUnNh05Xz2bRIjJ/ignfdiX92D7g8a6QI1sCAW+FDkZ5wJebtYZrGt4 s7OXaK7/P/DjxQpB+5KotsYuSByvssN+c0/sfYyvIPKWm2e8oF/l1TbP8o0jFvVQ+wja NbAg== X-Gm-Message-State: AOAM533CKN3b8ZYOyb4ap0XZZUQqdpPq2hSTdkJM+ofNwCT2YxguUgi0 MS1rmIW4ZGOjZiHWtRocjnv+/UZaOmejohr2yQvGcPaMMh53tQp3sryhDyXsgQSuGCpGcyZHh49 jnFPdY4dArNAch3IbHmFXsAGD X-Received: by 2002:ac8:5c81:0:b0:2dd:97b6:bcc7 with SMTP id r1-20020ac85c81000000b002dd97b6bcc7mr31957889qta.412.1646416318262; Fri, 04 Mar 2022 09:51:58 -0800 (PST) X-Received: by 2002:ac8:5c81:0:b0:2dd:97b6:bcc7 with SMTP id r1-20020ac85c81000000b002dd97b6bcc7mr31957863qta.412.1646416317989; Fri, 04 Mar 2022 09:51:57 -0800 (PST) Received: from treble ([2600:1700:6e32:6c00::45]) by smtp.gmail.com with ESMTPSA id 6-20020a05620a040600b005f177d938dbsm2710224qkp.66.2022.03.04.09.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 09:51:57 -0800 (PST) Date: Fri, 4 Mar 2022 09:51:54 -0800 From: Josh Poimboeuf To: Peter Zijlstra Cc: x86@kernel.org, joao@overdrivepizza.com, hjl.tools@gmail.com, andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org, ndesaulniers@google.com, keescook@chromium.org, samitolvanen@google.com, mark.rutland@arm.com, alyssa.milburn@intel.com, mbenes@suse.cz, rostedt@goodmis.org, mhiramat@kernel.org, alexei.starovoitov@gmail.com Subject: Re: [PATCH v3 18/39] x86/ibt,ftrace: Make function-graph play nice Message-ID: <20220304175154.l2otvmqd4r7ozsuy@treble> References: <20220303112321.422525803@infradead.org> <20220303112826.044301664@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220303112826.044301664@infradead.org> X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2022 at 12:23:39PM +0100, Peter Zijlstra wrote: > + > + addq $16, %rsp > + ANNOTATE_INTRA_FUNCTION_CALL > + call .Ldo_rop > + int3 > +.Ldo_rop: > + mov %rdi, (%rsp) > + UNWIND_HINT_FUNC > + RET Why the int3? -- Josh