Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2229097pxm; Fri, 4 Mar 2022 11:53:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQ+khU2YSaMfmAaQ7WmzBIex5DBJC0yhXANOvO6DnFgczLx/f2XorDwadsjxRQfql8k7is X-Received: by 2002:a63:6b85:0:b0:37c:8576:5156 with SMTP id g127-20020a636b85000000b0037c85765156mr53435pgc.380.1646423581506; Fri, 04 Mar 2022 11:53:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646423581; cv=none; d=google.com; s=arc-20160816; b=FZPEhJ2sJRg1x60xxZEi/R+kwSxwAAq1VDUd3fEkxdy3/1mlgJlMhACVY1BhQr9P1y 717LUnVTyPzp6oeRCzzBi7tSUWuco5Hp2uE7P6ywOHYdSsHXZxqhcfRSMWFc2jhaoI8z wS13fA9vFx1l3t+j0gizi0z86ahZzfblh7efbFicklkT+M9/daWtz2YfrWK2XnnRhcma y4ocHkfDa2q5cirDve0XG/nEFJpEzyLZ5rmUI4uu2p3hySTf7d+NjD+FqgAs1/piPnQw oH1zNs2moR7qiLpSDgI8cAGnxBkH3dR5g1FvwVuTbuOwHvdST82EoqeInizeDYEiL6hn L/mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KzILZ0DlQ3n1e7FkjfZR9BxxG7sCrZbKRkYcy7tdB58=; b=QBNpBBw9iA0PU806hgOg/CGhY3O4u39HH6MisQMrPRYC+XLnw6V65mvkLFSXHg8S6v 28VriiHmH8rzUOetLIP+6zQUc+94zk6zfSJYYOcjrq4uwiUPPKQ7VV5DbCRvMUnurGLt 32oK/s0tq8MkeCkt5+w6jJf550Khdjg7O3bLPupZ5R+5597v4oK5mTVIh6l/AXR+RTzF UXltwJni3fU67iSUY0I7SY7kWLkNo99qO5UtQaGmFEPLqG5CvIJny8HTuTB1/PWTNWEy cQbo71+O694f54b0W8Ct4a7sFCZmq8uIrtdjcmJVLZf3m8qZ464jfKy3v8i3JDFZHYXz x8Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=VI3MopPA; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id 126-20020a620684000000b004e0db114e7bsi5056153pfg.67.2022.03.04.11.53.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 11:53:01 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=VI3MopPA; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 83D952017E3; Fri, 4 Mar 2022 11:21:47 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240174AbiCDPJC (ORCPT + 99 others); Fri, 4 Mar 2022 10:09:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240077AbiCDPIb (ORCPT ); Fri, 4 Mar 2022 10:08:31 -0500 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8C6349FB6; Fri, 4 Mar 2022 07:07:42 -0800 (PST) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2244w2hI013723; Fri, 4 Mar 2022 09:07:29 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=KzILZ0DlQ3n1e7FkjfZR9BxxG7sCrZbKRkYcy7tdB58=; b=VI3MopPA7nmem+jieDrRYtkrc+aijaXRlLoLBipSg262UPdmzH0Y+XKfk7V9ZQ5AQvoI IwHLOF0Qvr1CRIf3oZE99vQ5uvPHM17epS1JlS7BIMFwjougYitpRcp0k2Axnc4621q4 kW+Jby/pZYGNbnY6RB1vaRur2S5BtcMaRoIq/uncemu0POQ4T7mLx7TrP3TC49cOLiCv 0/vRm0U+R6xBDb9R/GKhwPcYxpa75u+Lh5djyS61VlkSSAL1cLHtQcGOSnk6m0bFTuBA GcOxo7PrcRRN9Uu9m5zVDyQjFxSrRkvKSAnl1w/do6zHoy8vbl56tY/CEwWoWzlzX8Q8 tQ== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3ek4j3h414-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 04 Mar 2022 09:07:29 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Fri, 4 Mar 2022 15:07:27 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.18 via Frontend Transport; Fri, 4 Mar 2022 15:07:27 +0000 Received: from aryzen.ad.cirrus.com (unknown [198.61.65.198]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id C94807C; Fri, 4 Mar 2022 15:07:26 +0000 (UTC) From: Lucas Tanure To: Liam Girdwood , Mark Brown , Rob Herring , Jaroslav Kysela , Takashi Iwai CC: , , , , Lucas Tanure Subject: [PATCH v2 09/20] hda: cs35l41: Always configure the DAI Date: Fri, 4 Mar 2022 15:07:10 +0000 Message-ID: <20220304150721.3802-10-tanureal@opensource.cirrus.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220304150721.3802-1-tanureal@opensource.cirrus.com> References: <20220304150721.3802-1-tanureal@opensource.cirrus.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: pGQHpro56Or773HWynigvmuppCGB081s X-Proofpoint-ORIG-GUID: pGQHpro56Or773HWynigvmuppCGB081s X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Dai configuration is always the same and should always configured during open. Signed-off-by: Lucas Tanure --- sound/pci/hda/cs35l41_hda.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index fe6f6a208d29..4c99dcac2dd7 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -111,8 +111,6 @@ static const struct reg_sequence cs35l41_reset_to_safe[] = { static const struct cs35l41_hda_reg_sequence cs35l41_hda_reg_seq_no_bst = { .probe = cs35l41_reset_to_safe, .num_probe = ARRAY_SIZE(cs35l41_reset_to_safe), - .open = cs35l41_hda_config, - .num_open = ARRAY_SIZE(cs35l41_hda_config), .prepare = cs35l41_safe_to_active, .num_prepare = ARRAY_SIZE(cs35l41_safe_to_active), .cleanup = cs35l41_active_to_safe, @@ -120,8 +118,6 @@ static const struct cs35l41_hda_reg_sequence cs35l41_hda_reg_seq_no_bst = { }; static const struct cs35l41_hda_reg_sequence cs35l41_hda_reg_seq_ext_bst = { - .open = cs35l41_hda_config, - .num_open = ARRAY_SIZE(cs35l41_hda_config), .prepare = cs35l41_start_ext_vspk, .num_prepare = ARRAY_SIZE(cs35l41_start_ext_vspk), .cleanup = cs35l41_stop_ext_vspk, @@ -129,8 +125,6 @@ static const struct cs35l41_hda_reg_sequence cs35l41_hda_reg_seq_ext_bst = { }; static const struct cs35l41_hda_reg_sequence cs35l41_hda_reg_seq_int_bst = { - .open = cs35l41_hda_config, - .num_open = ARRAY_SIZE(cs35l41_hda_config), .prepare = cs35l41_hda_start_bst, .num_prepare = ARRAY_SIZE(cs35l41_hda_start_bst), .cleanup = cs35l41_hda_stop_bst, @@ -146,8 +140,8 @@ static void cs35l41_hda_playback_hook(struct device *dev, int action) switch (action) { case HDA_GEN_PCM_ACT_OPEN: - if (reg_seq->open) - ret = regmap_multi_reg_write(reg, reg_seq->open, reg_seq->num_open); + ret = regmap_multi_reg_write(reg, cs35l41_hda_config, + ARRAY_SIZE(cs35l41_hda_config)); break; case HDA_GEN_PCM_ACT_PREPARE: if (reg_seq->prepare) -- 2.35.1