Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <579e0023-09b8-8fae-355f-7182e7c8214f@amd.com>
Date:   Fri, 4 Mar 2022 09:15:22 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v5] sched/fair: Consider cpu affinity when allowing NUMA
 imbalance in find_idlest_group
Content-Language: en-US
To:     Mel Gorman <mgorman@techsingularity.net>
Cc:     peterz@infradead.org, aubrey.li@linux.intel.com, efault@gmx.de,
        gautham.shenoy@amd.com, linux-kernel@vger.kernel.org,
        mingo@kernel.org, song.bao.hua@hisilicon.com,
        srikar@linux.vnet.ibm.com, valentin.schneider@arm.com,
        vincent.guittot@linaro.org
References: <20220222102133.2956-1-kprateek.nayak@amd.com>
 <20220222132722.GC4423@techsingularity.net>
From:   K Prateek Nayak <kprateek.nayak@amd.com>
In-Reply-To: <20220222132722.GC4423@techsingularity.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFlLN3Y4K3NVZnk3K1FEUCsvOG0wbEhUOW1KN1pjN2ZNQkYycWZ4UHFTMDNU?=
 =?utf-8?B?SnBuSXRieXk3eDBseGZSMUFpZnhLcUNlMVRaZitneVFPS0VPdmQ3ZG1YYmpu?=
 =?utf-8?B?L2lIT0dLbkFWQnVpRWFXbXdDVzBqYWhBMktKYzV0ZkVRU0xvM2t4bEdORWt0?=
 =?utf-8?B?S3lDWWh4cG4wNEVDTEVIbitZOEx6a08rV3phdW5GNVg3QzU3bWFacXBNdlgx?=
 =?utf-8?B?dTgwYURvaDl6djFPNnduTENjZUdpS042MFdSNjdsdlJlOVlUR0JIbUgyVE1K?=
 =?utf-8?B?eWJCYkNWK2RDTUIyVmNLUzJZZitWOHpKN1RVa0grUlluQVp5U1MzVS9Jc2tp?=
 =?utf-8?B?ZGRPd0dPL2ZsRm9idkgxcEhLaFd6RCs0R2owS3NBUk5DYkppT200bEtiblpW?=
 =?utf-8?B?eDQyYnd2eTY1aXJ3TGJsRU5wNE9qOGNnSlZyKzNzdUdqbXNLcXZDZ2Q1ands?=
 =?utf-8?B?dWxQRXorUis5cHJuOWFVNE9HZVkxMlhVZDVZNmkrOEZyUUFDckkvWUR0WGdU?=
 =?utf-8?B?YWt1WnBFcjQwRUt1WFYrU3luMXl6NDJ1TmlUR1dPRFRjMXdLY3JmYy9KN1NY?=
 =?utf-8?B?cVlDZzhzQjJ4YncyUkJuY2crUFpUQUtPSEloUDhEZG9RUk51VmY2WmhPclB0?=
 =?utf-8?B?VmtIdXEwVlI5UzFXd2d6MkVOZEtZTlFYekJMVTZZVGYxQllPaWxmZjZNYjFH?=
 =?utf-8?B?c1FHQ1NwUURCMmpCZDlJNURxSm52V1lXWm5JbnA1b0Y2RGprRkx3YnRxVDNt?=
 =?utf-8?B?ZFl5Wm45SUlrdmoxeCtwdm4xQzBEWjRiTmw5VFBSMklFVm5Vc2Q1MUd4WUdk?=
 =?utf-8?B?SU8xS3E3KzZEOEwzRkE3cFd4ZWFCb29QTzNpak0zT3pRU2U1TTNCTlN5N1o3?=
 =?utf-8?B?eS91dGkvMEVjamd0QlV0Sjd5dEZ3SG9OMWlLNlp5S1RlMmFONko4WHBnTlJH?=
 =?utf-8?B?L242K0YrZDVUZk5GN1NpSW03dXpEeFh2WE1PZnhNcDltQjQxQnU0cVJqRUlY?=
 =?utf-8?B?YVcvMEExYnFRRHI1dWk3OXpHdE1WWlFMeEdDcjlxZ2V2NFNWazBjdEJBMjh6?=
 =?utf-8?B?TXFHR0ZjemdaZFlGeHdVUytmTDREL3A3aThMSjRyVnRkeWFmV2FNTi9mOCtU?=
 =?utf-8?B?Q3pBN0h6QzFvM2pvQ1B3cGhqRC9uOXBvREdOeFNZdnJ2VmNiSkQrNkhTd0ds?=
 =?utf-8?B?cENQdEJSbUJVNTNvQlRQU2RiN2RudlRNRFBXZ1hFUlhQc0pPM0UrUld3QTNh?=
 =?utf-8?B?MnVqSHVtb0FhTEZPM2ovcy9COTBWVWtwQnQxOGI0cjI1WVRYeEEvNXI4QW8r?=
 =?utf-8?B?NVJBd1lMMFlNQ09vZWZxSnVyS1JkTkl2Z3RsTUxrUDIwZzlZQ1lWTi9OSWF3?=
 =?utf-8?B?U3ZXbGpRMUkzTlkyQXA4cnVlSnZzQ3I1RUJkYi9zaGIzVStjRlExZmtKTjhu?=
 =?utf-8?B?dTdYT1lQT2R0M3NoZ2k1SmhSSW55MEJTc050aDBmcVRNaitBVWN3V29pMDFp?=
 =?utf-8?B?ZWkxVzFIQVVRSzJ0Q2ZmOFkybUFuTE9USEZ6cmJQOXJFMlBhK1NkL1d0SDFJ?=
 =?utf-8?B?Yjc2Vy9xOXQvWElrL1NlZ1hyRDdPbWU4MVVBMzR3azh1NGRLSFVmWXVOZTNY?=
 =?utf-8?B?M2R0UGZjNzZwQkZWK1p0aUViZFZwbTFZSUJVVkZQV0VGRUw0bWdGdzluMGJw?=
 =?utf-8?B?K3k4TnFYaWxvY3FveFRaR0gvTTUzcWN4TlpBK0s2cUJmY1dhVSs4MGRvWGQr?=
 =?utf-8?B?N1NtRlUySERaeTFIYWNvQUIxMFhzOFQ1SlI1M3czQ3BoVERaVTM1Q2t5MnRL?=
 =?utf-8?B?RmxIRFNTVkhhN2x3Z3BNajdCVWtIOEhHNTdra2FHTWcrWk5qckhTZEI0bnFp?=
 =?utf-8?B?N0tpUzNvcjQ4b0NRQkM5VU84VXlmemFiVWRRam1icmxUQllGemxtczduQUha?=
 =?utf-8?B?TmtsQVhzOHpvM1g0QnVxOWZ2TzZYR0hQSTZ5NlVLc0w3bjhTTDZSNXhPYnJ1?=
 =?utf-8?B?S1p0c0FaeVBFVmw2ZE5VQlFxeU52RmN2OFpOZXNpMStMeFRjQVpqaHRNVWFE?=
 =?utf-8?B?T2dZK0xBSFBDVTA3RVRZRTkweWpkWTMzRW9GbSsrZ2VGdUZVZU9GU1lTbGpR?=
 =?utf-8?B?VjFrUWpBOGEwdTdCN0diR3hGZXdKK2J0VHdlS20xejlBZm1jL0lnRDloazk2?=
 =?utf-8?Q?1QQ6tROjhHrOho8pyHB8jCg=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d936d39c-7b58-4017-2a82-08d9fd916d39
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2379.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 03:45:29.9652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A5wJdlFnMbDguGYQ/sc+XALfXUDUxDFfcbVHZYkJljnouJtOvJdKhGFNZ8N17tiorYRLQnE/NnbSvFueSIgM4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2337
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Mel,

On 2/22/2022 6:57 PM, Mel Gorman wrote:
> [..snip..]
> Only minor nit would that the cpumask can be declared within the if
> block to limit scope but that is just being picky so
Small oversight on my part. I'll wait for Peter's response on the
same and create a v6 if necessary.
Peter, any thoughts?
> Acked-by: Mel Gorman <mgorman@techsingularity.net>

Thanks for the ack :)

--
Thanks and Regards,
Prateek