Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Hugh Dickins <hughd@google.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Oleg Nesterov <oleg@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH mmotm] mempolicy: mbind_range() set_policy() after
 vma_merge()
Thread-Topic: [PATCH mmotm] mempolicy: mbind_range() set_policy() after
 vma_merge()
Thread-Index: AQHYL4FzWFkyFnZUSku+xBH1UQyT+KyvkiKA
Date:   Fri, 4 Mar 2022 18:49:33 +0000
Message-ID: <20220304184927.vkq6ewn6uqtcesma@revolver>
References: <319e4db9-64ae-4bca-92f0-ade85d342ff@google.com>
In-Reply-To: <319e4db9-64ae-4bca-92f0-ade85d342ff@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ad4UyP1RjmiaFA8lBTRpHlb3wpShfuG0X/fobjkul3ImQiHqOgNBTw1UnOgn?=
 =?us-ascii?Q?fdA1Z7nJh7eKi9mg1FCBatD8bf00SFZe46B0weKV+Ay3tiePzjhos+NYt1q9?=
 =?us-ascii?Q?TBce4tU15/O5vgM1oht2e/2gebGHbMUU8UxOJafOhQDaT+pDHxu02147Qs5S?=
 =?us-ascii?Q?LqkJ3K3jmo9vCVpUHFs0dMJ0Ynns2mqp44F9AmLGivQ5I9CcOwZjowGb6PDJ?=
 =?us-ascii?Q?XDcjtTleM5O+oSPU1sx0gbyhUYAua+rAiNENug0b+oXQeQJKHuPChs7c+ESq?=
 =?us-ascii?Q?+q68Q0mQq2zk13errsdeKPSk3oB08wmfPHa27T0SJJ+gh3f9FaOT2KFvQ9r+?=
 =?us-ascii?Q?2nyHUHWUacqL0/6Tbq66bqV6Q3i+cZrV1KS41hX6LM85U7dErX6L8S4OCDAZ?=
 =?us-ascii?Q?ogHuNJTzGKNfxKhgRyQtNRC8Z9ohRRxNe7RvsL19bM7Y/QpD9+e7ZV8OBhVH?=
 =?us-ascii?Q?6Kjaq8d0CpcnPHvbQ8MyIzcX0yjkl/GfI/xCL9krnILgfYCk5mW3q7IxQ2z5?=
 =?us-ascii?Q?tFai7I2NJ6PbA4SdF9P3dSX5B/lDCK6zZErPQfWdr2EIt0kpbbBdsmb+Kw+M?=
 =?us-ascii?Q?eM65nRzRm+aIGN54miuDsi5wGCfrsH07XRwyusk2WbgO+jA1QImB28IC1wpc?=
 =?us-ascii?Q?/5o5UkJttXYJcLDhUHBswrJEDWMZyl1KMzWrtk9rJ6brSZV4ZBm0pqlrUcO4?=
 =?us-ascii?Q?Iy7id8u/QT3gTF/FmycCzKl9CAzKkRlhTIw3t6FH0jRmXEjTIjfHhS4ih9OV?=
 =?us-ascii?Q?1cJQWajJr6em1GfSHliG3HvR1QHydYhJnCyt1+vOkoO4ehYidnKiBXMfB9qp?=
 =?us-ascii?Q?OnXW9ptYpCht+eTbx8jKd69aSpjO0e4xrFlA49tukFavKDx0ihJUvv+FkYNj?=
 =?us-ascii?Q?tZ23eHl0Ve3Q9N8NHvJyMcolKCO7MidscCusjl3nF4Aw/+m9s1+mXUb+G8Gi?=
 =?us-ascii?Q?fxgWLdltW+f/fAJyJncPT46+tnQAkrkOfU/g1c55wHKjrekLOulFn7dghwuu?=
 =?us-ascii?Q?iaHvCO3E3t+54VfUo4I1a688v9+GHCeLzfOFX4HS2jHmNMPFiTO+TCrCWUMx?=
 =?us-ascii?Q?f5Q89MSZ6xtTO8TFH2E0QxYHrXyzR5q646ePQJmyJC8uApWRWIfjcDYkLWce?=
 =?us-ascii?Q?urA94T8gJjPGI3JyxLgN+q9PqgshB/zQLIiwMf750xltfW8yft4u0mj9mPFk?=
 =?us-ascii?Q?gG4gv5QU8nKxg3dewOCaGcmlMlgNSBV7Z4/xDYW+DxG83Xz41sBWJiLjXCoE?=
 =?us-ascii?Q?I2qBFuUBDIBv+eOtpvtXUhGoEZfbxSD/quoPXh81L1QT0XMqVgfMbWdC1mFn?=
 =?us-ascii?Q?a3ArF3gDdp5pwqa2ZxWLEmCABI8Z5hqzHTLfRoX6APm2xqtl8YTOSaIQrplO?=
 =?us-ascii?Q?6N3a4La3SclEAp+mqMfVdwluILdpDLlNQRXCdsQLOadFbXixJ33o/zwICzdI?=
 =?us-ascii?Q?veDubmk0lk97IH8Uw8uYYAek0MHDS893POzGwxbx/ZB6FdYKMkX9pkiI8RKP?=
 =?us-ascii?Q?HjFDfUA5KRtwboG6Sw4bgGXhfr7ZC7x4oBVxNTe5NOhzhRmXCxgz3pMrzwZa?=
 =?us-ascii?Q?DKOlOC7J9hGE8StgXd2wgJ0mNGBlwpUANWABRtEgrLx8wNHSB24FC9NWy9I0?=
 =?us-ascii?Q?oWtFOWPX43Z5PA3juf5GoFo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A0929FA07B20064D86799D5C4B8F5837@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6ce9fd8-1ce4-47c6-7789-08d9fe0fb964
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2022 18:49:33.7657
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 88VMNKKHaopT/0fw9tNaGlwqlVeuhxv3/C0JtOFJR3/pHNhOGI75ylL9x4AqrENzQgZdOh7imIxuFGs7CG7o5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5212
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10276 signatures=690470
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 bulkscore=0
 malwarescore=0 mlxscore=0 spamscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203040093
X-Proofpoint-GUID: xlLLAiT_7EPbTlpQ4AcuTCD1NlHb-yvo
X-Proofpoint-ORIG-GUID: xlLLAiT_7EPbTlpQ4AcuTCD1NlHb-yvo
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Hugh Dickins <hughd@google.com> [220303 23:36]:
> v2.6.34 commit 9d8cebd4bcd7 ("mm: fix mbind vma merge problem")
> introduced vma_merge() to mbind_range(); but unlike madvise, mlock and
> mprotect, it put a "continue" to next vma where its precedents go to
> update flags on current vma before advancing: that left vma with the
> wrong setting in the infamous vma_merge() case 8.
>=20
> v3.10 commit 1444f92c8498 ("mm: merging memory blocks resets mempolicy")
> tried to fix that in vma_adjust(), without fully understanding the issue.
>=20
> v3.11 commit 3964acd0dbec ("mm: mempolicy: fix mbind_range() &&
> vma_adjust() interaction") reverted that, and went about the fix in the
> right way, but chose to optimize out an unnecessary mpol_dup() with a
> prior mpol_equal() test.  But on tmpfs, that also pessimized out the
> vital call to its ->set_policy(), leaving the new mbind unenforced.
>=20
> Just delete that optimization now (though it could be made conditional
> on vma not having a set_policy).  Also remove the "next" variable:
> it turned out to be blameless, but also pointless.
>=20
> Fixes: 3964acd0dbec ("mm: mempolicy: fix mbind_range() && vma_adjust() in=
teraction")
> Signed-off-by: Hugh Dickins <hughd@google.com>
> ---
>=20
>  mm/mempolicy.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>=20
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -786,7 +786,6 @@ static int vma_replace_policy(struct vm_area_struct *=
vma,
>  static int mbind_range(struct mm_struct *mm, unsigned long start,
>  		       unsigned long end, struct mempolicy *new_pol)
>  {
> -	struct vm_area_struct *next;
>  	struct vm_area_struct *prev;
>  	struct vm_area_struct *vma;
>  	int err =3D 0;
> @@ -801,8 +800,7 @@ static int mbind_range(struct mm_struct *mm, unsigned=
 long start,
>  	if (start > vma->vm_start)
>  		prev =3D vma;
> =20
> -	for (; vma && vma->vm_start < end; prev =3D vma, vma =3D next) {
> -		next =3D vma->vm_next;
> +	for (; vma && vma->vm_start < end; prev =3D vma, vma =3D vma->vm_next) =
{
>  		vmstart =3D max(start, vma->vm_start);
>  		vmend   =3D min(end, vma->vm_end);
> =20
> @@ -817,10 +815,6 @@ static int mbind_range(struct mm_struct *mm, unsigne=
d long start,
>  				 anon_vma_name(vma));
>  		if (prev) {
>  			vma =3D prev;
> -			next =3D vma->vm_next;
> -			if (mpol_equal(vma_policy(vma), new_pol))
> -				continue;
> -			/* vma_merge() joined vma && vma->next, case 8 */
>  			goto replace;
>  		}
>  		if (vma->vm_start !=3D vmstart) {

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>=