Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2258019pxm; Fri, 4 Mar 2022 12:30:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJx2eTXPiMb7L4swPbceAGH+4P4OMn4e6AaI2P/sN9MEAKgtF0laU+zWF8GXmlmtMztNbSrr X-Received: by 2002:a62:7990:0:b0:4e0:5ae8:6c11 with SMTP id u138-20020a627990000000b004e05ae86c11mr476352pfc.34.1646425811690; Fri, 04 Mar 2022 12:30:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646425811; cv=none; d=google.com; s=arc-20160816; b=plitKVFHOw+e28ZRYuM/i6iUgId7osNHrW1opTOTRPSuRfGFNlm9nQierh0miGjkNB RrdaFMP34dkg5mvtite/IsvASmIeWaZJR1NQOd1t53eCBPlkBKgrdbrEbzigFDpZ+2vz 4wZN5mlJ/shD0LSj0TZVWRKmyVtB1Py8yyDNdF2LwosC5NwmG+9aNH/VF1zZWD0VR/JJ gIZtz4bnb3sLYVShHJM700OfVJqjVKY3e+CIu3ACGzSEslY8ee/AFE3fNCw5fETpVaKV 4WTuPmXOsy/KJ16H/87JYlpo1rrjjgmp8SvyFE26Bj5X9R4+4I3s7Fm1GbQTCVk3/nwn g5RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=rnVpkoSn9VqsAnd9zN4uwgqWCEpAUYKl6fz45LFY4uU=; b=Hhv5CtBkgEVuHSqLurdav7TtUChfQh4pQN5+RWW+Q5tZ71wQnSKBPObbGGfO9s4QGk sfhBO2Mu1T8Dnc/rGvFFKrIkM5q3BB1XxoZQ67HtMo+OKw4IntAJKF7Y6MR4YyQgFlMc Dkbep58BZLYUxKthlabRwdKaKI1nH2DZEzqKl7tWQHFQzpyKPVlfxVERakohDMFzaYJC 4fnxhKqK/Zcv/Thhev5ebEKbvxh3rSZil1nQXEvtsv593t820Cd087syMfm4HPkYzwgs iEED2aY7pa4vh6VTS47iaUyHWlIDVzFjImO+q3+kPEE5vGWvwDWCYT9vgJUCBg/zNjbz mKfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gFMQ9jfe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 9-20020a17090a0b8900b001bd412e0fa0si421366pjr.44.2022.03.04.12.30.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 12:30:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gFMQ9jfe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1200A21653A; Fri, 4 Mar 2022 11:34:49 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235557AbiCDOSj (ORCPT + 99 others); Fri, 4 Mar 2022 09:18:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229594AbiCDOSi (ORCPT ); Fri, 4 Mar 2022 09:18:38 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA1842559B; Fri, 4 Mar 2022 06:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646403470; x=1677939470; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=or3pXL7frdL+sQOxlxnzqbp2iB/FyXVFN2iAqqfq00c=; b=gFMQ9jfeg38vNguS5itQreotU4r2bH/Brn7m+7HSPGJ63/+LFihsNQp+ 2azxkFZPQ28jKmGDY8s5zjVYH3ufj3L8/pPEoD4X0+ND1Jhm+qMvCOuKS rtRzGHOsotROQfa4BmiGsrL2cbWV/ps0p5LfJUGQlL3l9ZXRSKvN1GDt/ ZWcTyPCwWF6kqadDRhou9FTLtyl3yS8Nj7eN5OwihB/8Cq4XQV3LFIsAv VJutUV+urkdsRLvzg/CCxyBaPrF+wHmNvx+tg47awQCqGOwCK5OmWl4iU H/XtkoJhlGFopRg1P8aT3gJzN+orsJiUXEeQ7QxS9ulvthT7ymDj/wTOd A==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="253711653" X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="253711653" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 06:17:50 -0800 X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="710345703" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.162]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 06:17:48 -0800 Received: by lahna (sSMTP sendmail emulation); Fri, 04 Mar 2022 16:17:45 +0200 Date: Fri, 4 Mar 2022 16:17:45 +0200 From: Mika Westerberg To: Mario Limonciello Cc: "open list:THUNDERBOLT DRIVER" , linux-kernel@vger.kernel.org, Sanju.Mehta@amd.com Subject: Re: [PATCH v2 1/5] thunderbolt: Retry DROM reads for more failure scenarios Message-ID: References: <20220303131328.4150454-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220303131328.4150454-1-mario.limonciello@amd.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mario, On Thu, Mar 03, 2022 at 07:13:24AM -0600, Mario Limonciello wrote: > Currently DROM reads are only retried in the case that parsing failed. > However if the size or CRC fails, then there should also be a retry. > > This helps with reading the DROM on TBT3 devices connected to AMD > Yellow Carp which will sometimes fail on the first attempt. > > Signed-off-by: Mario Limonciello This and the rest of the patches applied to thunderbolt.git/next, thanks!