Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2266884pxm; Fri, 4 Mar 2022 12:42:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJyDMTf6h/aIU2saD0t4OrwPtUq2dh4vI14tk/+XMbQgc8kPuhwiVnBlAPxSOmVFpHgR8Pj1 X-Received: by 2002:a17:90b:3a81:b0:1bf:8b5:f924 with SMTP id om1-20020a17090b3a8100b001bf08b5f924mr422914pjb.153.1646426535366; Fri, 04 Mar 2022 12:42:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646426535; cv=none; d=google.com; s=arc-20160816; b=m6ZKpjeacSEn3RejbiZll5hpZKprdN5fVLqRbuhZBzsRuCvq5wAhq18lGpBccnx4Ve Ncwkkn/FjvASuDa98Qr4xsa/yOBfSMY2+oVQnimCYYLWrk3dKs0fSuBuNXjKG/FPakGX mfcWz44hEpe4MOLf6ysaPRqo8FmaX0H7srQkufLK/kNVBolUV0uBrLJAmEArMQuHBpqp QNYBSPra8ku0u7Y+6r+mLzQSCjjh5wEEKOQDvrtf3rCwkFr4TQZ0od2NDKqYet+nO8wm tArx0+ZIEQvowPZMAYDr3GtdRbZ4KjTreqiaQLTWy075J9MqTPvzzCWXn51NnlNQAOYC QmJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature:dkim-signature; bh=dse1Yo6t0Vcy29L3lT+MHYqucbHXPrkGk6t6/xDwVp4=; b=UJKooByj0jI/NxurbnKq2TojTJYM04uCfqDpn1N77fTSaPc7RL483Trhv0UcgYFIWx Xr6eOD8WinpnDPfWe6LPr7yCUQ+YenHxdSz7fHw/VDPMxH5VcBLNrXpFFyO2Dy/IsKAr fMfAziCCsYs3VKs0vCwLFSrDhX5eSlqQJ5tx/VmvTum+l3gClgm2oK6wWsD4vgZGXBci FvvGjNas75pQ2lbMpmdABoJu6Ltgs7OBZHR8RS6jLQr4jxTgky41syx4lyKJXnl0+odw 5n1foeUvVC7ycFHwNRQJr/Epd9huOdaiigvc/F4ShmwbhBvBsEHRo/fjVic2+a0MhfMl NB4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Y8vufeV8; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=yU8i9Gvk; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id 4-20020a630e44000000b00374570f8078si5313409pgo.787.2022.03.04.12.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 12:42:15 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Y8vufeV8; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=yU8i9Gvk; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2E8FC2AD33B; Fri, 4 Mar 2022 11:42:08 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241625AbiCDS0l (ORCPT + 99 others); Fri, 4 Mar 2022 13:26:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241607AbiCDS0j (ORCPT ); Fri, 4 Mar 2022 13:26:39 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1421A1C6662 for ; Fri, 4 Mar 2022 10:25:50 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8586721136; Fri, 4 Mar 2022 18:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1646418348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dse1Yo6t0Vcy29L3lT+MHYqucbHXPrkGk6t6/xDwVp4=; b=Y8vufeV8mA7aSKloGeOJAQT/uREGmDg1LuWaTXvY1m1UA2NcrxhbZMCf1Xxc7YPwOmFFWO GONrlMTrMWtwqeuD2wkXcvRNSDAf6NR/pip60hffJ3fX9JH7HmDL4Jbsi28IkBKqvyVvVb +QYo5rcN0JMBsLjw7bI5OEnbQuLUrco= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1646418348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dse1Yo6t0Vcy29L3lT+MHYqucbHXPrkGk6t6/xDwVp4=; b=yU8i9GvkB4jJuIKk0+o5iu1iuKVT7ULGY/9ZLGeJX5ZTo+c39lGFnOUQl29Xde4VB+ODEo fsBGb7IZXkSemADQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 515F913B70; Fri, 4 Mar 2022 18:25:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8iLnEaxZImI9AgAAMHmgww (envelope-from ); Fri, 04 Mar 2022 18:25:48 +0000 Message-ID: <74269fcd-60ef-5308-3aaf-e8944e37d1b0@suse.cz> Date: Fri, 4 Mar 2022 19:25:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 2/5] mm/sl[au]b: unify __ksize() Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Marco Elver , Matthew WilCox , Roman Gushchin , linux-kernel@vger.kernel.org References: <20220304063427.372145-1-42.hyeyoo@gmail.com> <20220304063427.372145-3-42.hyeyoo@gmail.com> From: Vlastimil Babka In-Reply-To: <20220304063427.372145-3-42.hyeyoo@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/4/22 07:34, Hyeonggon Yoo wrote: > Now that SLAB passes large requests to page allocator like SLUB, > Unify __ksize(). Only SLOB need to implement own version of __ksize() > because it stores size in object header for kmalloc objects. > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reviewed-by: Vlastimil Babka As discussed, we can be more specific about the !folio_test_slab() case, but that can be done on top.