Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 3 Mar 2022 22:56:40 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Max Kellermann <max.kellermann@gmail.com>
Cc:     linux-pwm@vger.kernel.org, thierry.reding@gmail.com,
        lee.jones@linaro.org, linux-kernel@vger.kernel.org,
        andrey@lebedev.lt, stable@vger.kernel.org
Subject: Re: [PATCH 3/3] pwm-sun4i: calculate the delay without rounding down
 to jiffies
Message-ID: <20220303215640.m23yozioeqxvmlfc@pengutronix.de>
References: <20220125123429.3490883-1-max.kellermann@gmail.com>
 <20220125123429.3490883-3-max.kellermann@gmail.com>
 <20220224165135.g4ufknd3alrhnfx3@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jer5rcewuptdavq4"
Content-Disposition: inline
In-Reply-To: <20220224165135.g4ufknd3alrhnfx3@pengutronix.de>
Precedence: bulk


--jer5rcewuptdavq4
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 24, 2022 at 05:51:35PM +0100, Uwe Kleine-K=F6nig wrote:
> On Tue, Jan 25, 2022 at 01:34:29PM +0100, Max Kellermann wrote:
> > This fixes a problem that was supposed to be addressed by commit
> > 6eefb79d6f5bc ("pwm: sun4i: Remove erroneous else branch") - backlight
> > could not be switched off on some Allwinner A20.  The commit was
> > correct, but was not a reliable fix for the problem, which was timing
> > related.
> >=20
> > The real problem for the backlight switching problem was that sleeping
> > for a full period did not work, because delay_us is always zero.
> >=20
> > It is zero because the period (plus 1 microsecond) is rounded down to
> > the next "jiffies", but the period is less than one jiffy.
> >=20
> > On my Cubieboard 2, the period is 5ms, and 1 jiffy (at the default
> > HZ=3D100) is 10ms, so nsecs_to_jiffies(10ms+1us)=3D0.
> >=20
> > The roundtrip from nanoseconds to jiffies and back to microseconds is
> > an unnecessary loss of precision; always rounding down (via
> > nsecs_to_jiffies()) then causes the breakage.
> >=20
> > This patch eliminates this roundtrip, and directly converts from
> > nanoseconds to microseconds (for usleep_range()), using
> > DIV_ROUND_UP_ULL() to force rounding up.  This way, the sleep time is
> > never zero, and after the sleep, we are guaranteed to be in a
> > different period, and the device is ready for another control command
> > for sure.
> >=20
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Max Kellermann <max.kellermann@gmail.com>
>=20
> Sounds reasonable
>=20
> Acked-by; Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

/me had problems with is keyboard, the Shift-key didn't work and so I
typed a ; instead a :. To make patchwork pick up my tag, I'll repeat it
here:

Acked-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--jer5rcewuptdavq4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmIhOZUACgkQwfwUeK3K
7AlIfgf9HeL94rE/TP4y8ECAlIoCb0eRRWZ4Zj1TM0SxRd1KtmcvQHx/jfivLc8H
IVuljJbzUmrEKRTTXzSZ2Ptj4Lgs3jBYARTklK/lR+NTn9dI1AQyv2TK7Sf3S4fE
ZESjVxH610fLuLTG8aVVCT3mN8PMb6V5RJfIZ1ee5/lyWWkzXWkvGvW89I8+vZYe
ic93WQx9tKt93L8w8SAat/J6OhLhHVXHUSc0Ia/LBGpU6KDHCsaSj58W5G9bbF76
1/YKmMj636lZfN8ts7kNmHiwCsgwFbFqd/nPuRehyDITg1vBADDlPboyTk0KHf8h
7KT0qN1D2OIqm/ZeWWEpm1sszA5d7w==
=DJyp
-----END PGP SIGNATURE-----

--jer5rcewuptdavq4--