Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 4 Mar 2022 15:26:06 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linus.walleij@linaro.org>, <colin.foster@in-advantage.com>
Subject: Re: [PATCH 2/2] pinctrl: ocelot: Fix interrupt parsing
Message-ID: <20220304142606.3yxwah4k36deqa3e@soft-dev3-1.localhost>
References: <20220303203716.3012703-1-horatiu.vultur@microchip.com>
 <20220303203716.3012703-3-horatiu.vultur@microchip.com>
 <YiIIxXemSB8LIq8L@smile.fi.intel.com>
 <YiII4mMembqLiX5D@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <YiII4mMembqLiX5D@smile.fi.intel.com>
Precedence: bulk

The 03/04/2022 14:41, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Mar 04, 2022 at 02:40:38PM +0200, Andy Shevchenko wrote:
> > On Thu, Mar 03, 2022 at 09:37:16PM +0100, Horatiu Vultur wrote:
> > > In the blamed commit, it removes the duplicate of_node assignment in the
> > > driver. But the driver uses this before calling into of_gpio_dev_init to
> > > determine if it needs to assign an IRQ chip to the GPIO. The fixes
> > > consists in using of_node from dev.
> >
> > ...
> >
> > > -   irq = irq_of_parse_and_map(gc->of_node, 0);
> > > +   irq = irq_of_parse_and_map(info->dev->of_node, 0);
> >
> > Why platform_get_irq() can't be used?
> 
> Or actually _optional() variant of it?

It can be used. I will update this in the next series.

> 
> --
> With Best Regards,
> Andy Shevchenko
> 
> 

-- 
/Horatiu