Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <f57550a9-f3d7-9a04-a51a-6224b352af7b@bytedance.com>
Date:   Fri, 4 Mar 2022 22:50:36 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [External] Re: [PATCH 1/2] kselftest/vm: override TARGETS from
 arguments
Content-Language: en-US
To:     Shuah Khan <skhan@linuxfoundation.org>, akpm@linux-foundation.org,
        shuah@kernel.org
Cc:     linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220227055330.43087-1-zhouchengming@bytedance.com>
 <b29de093-72dd-1dc5-b591-2a75f49cdb2a@linuxfoundation.org>
From:   Chengming Zhou <zhouchengming@bytedance.com>
In-Reply-To: <b29de093-72dd-1dc5-b591-2a75f49cdb2a@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2022/3/4 3:17 上午, Shuah Khan wrote:
> On 2/26/22 10:53 PM, Chengming Zhou wrote:
>> We can specify which testcases to build using TARGETS argument,
>> for example: make -C tools/testing/selftests TARGETS=vm, cause
>> the ordinary assignment of TARGETS in Makefile will be ignored.
>> So we need to use override directive to change that.
>>
>> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
>> ---
>>   tools/testing/selftests/vm/Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile
>> index 1607322a112c..0b330a5b1840 100644
>> --- a/tools/testing/selftests/vm/Makefile
>> +++ b/tools/testing/selftests/vm/Makefile
>> @@ -53,7 +53,7 @@ CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_32bit_progra
>>   CAN_BUILD_X86_64 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_64bit_program.c)
>>   CAN_BUILD_WITH_NOPIE := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_program.c -no-pie)
>>   -TARGETS := protection_keys
>> +override TARGETS := protection_keys
>>   BINARIES_32 := $(TARGETS:%=%_32)
>>   BINARIES_64 := $(TARGETS:%=%_64)
>>  
> 
> Let's not override TARGETS - rename TARGETS in this file.
> VM_TARGETS?

Looks like Andrew has already added this patch to the -mm tree. I think
both way is ok to solve this problem. Should I rename to VM_TARGETS and
send another patch?

Thanks.

> 
> thanks,
> -- Shuah