Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220304170813.1689186-1-nathan@kernel.org> <202203041005.A3B985C@keescook>
 <YiJXUL3zIik+4QDv@thelio-3990X>
In-Reply-To: <YiJXUL3zIik+4QDv@thelio-3990X>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sat, 5 Mar 2022 03:55:36 +0900
Message-ID: <CAK7LNAT+4t_c=SLJqVWYVMaQ8C1uqWCeOFJ6eNczT1TUgEG_Cg@mail.gmail.com>
Subject: Re: [PATCH v2] kbuild: Make $(LLVM) more flexible
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Kees Cook <keescook@chromium.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Shuah Khan <shuah@kernel.org>, llvm@lists.linux.dev,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Mar 5, 2022 at 3:15 AM Nathan Chancellor <nathan@kernel.org> wrote:
>
> On Fri, Mar 04, 2022 at 10:09:03AM -0800, Kees Cook wrote:
> > On Fri, Mar 04, 2022 at 10:08:14AM -0700, Nathan Chancellor wrote:
> > > [...]
> > >
> > > Update and reorder the documentation to reflect these new additions.
> > > At the same time, notate that LLVM=0 is not the same as just omitting it
> > > altogether, which has confused people in the past.
> >
> > Is it worth making LLVM=0 actually act the way it's expected to?
>
> I don't really see the point, omitting $(LLVM) altogether is simpler.
> Why specify LLVM=0 if you want GNU tools, since it is the default?
> However, I can look into changing that in a new revision or a follow up
> if others disagree?


Changing the meaning of LLVM=0 is beyond the scope of what
we are trying to achieve now.

I think documenting it is enough.

(If we have a good reason to change it, we can. But, it should be
done in a separate patch, at least)


-- 
Best Regards
Masahiro Yamada