Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2280677pxm; Fri, 4 Mar 2022 13:01:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5lDDXlD5JOo7r1uHtss/9GBfI6pyJMACTdBejTF+VtKqCB4dPS1CSzsH4yk3G+hUsTaR2 X-Received: by 2002:a17:906:2ad3:b0:6ce:3662:8d68 with SMTP id m19-20020a1709062ad300b006ce36628d68mr487777eje.71.1646427698990; Fri, 04 Mar 2022 13:01:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646427698; cv=none; d=google.com; s=arc-20160816; b=QCz6Frzeyvlmxd0SPVAWtRdG7H627bUEgl2vxYuEaukdbQofdb+m/VbOvbT92hMrxm nIBRL10IJI+orZoLajJrei/DKfuz1LvKKVin2ic6riCwHhDhJehvXNXG9COsOAIA71HS qORiUd7hZWbixTVYkqKuw60aVjWzdVoI5oz8kwDbL1cqrCajluqcx3YlA6li61L6YuQL FxBJEhNLpxhCC8v5pRvm9xmrIMO0OqwrlFXCQ7b3iMgcNyMqiZ5MScyh0dmI1LPj3bl3 HHJ/u1iN3czPe9kLu1ijscalCH7vqYviRwrqU7gmg084fFq9ek997A+2V5oQo94vHe9o NYzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hTgfC44JS9v44NLsD1sg7Y1pWVGJtaRJ7sUIWmhL94M=; b=g8ZEHGSUjBAMMx5nYADyKH+DaftWt6tFFMXxtZztXofT/E+AKJmSKdgxsJuOCTSxTV +uQ1ikuv6kM1jY5tWnQNb/2cNaGHYn+gOHby0nKdC1p7PEGOYKkZDEx8q/s6H3zkxOyy 8gSFvN9STXGBQSBn2CVfG2koc1QCSR0VRpNKSWteTEGgeyxzUjjPdJVLK2zx8o5gmHyj uhSG9SZOsu4KBQjO8nLqgzH9o1HSlI4RD8byKfyrCRM/gvIutyk54z/lHQFS68lSSa9h 20DLA6atrzrLWCWl6Vl2gDwwqY7SmX5al8fkvzEL/vPgor4Vfa8y8CMPmVjgoq61FOSz AAxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="dyP/MFwp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r23-20020a170906705700b006d6e5456b4bsi3591232ejj.833.2022.03.04.13.01.11; Fri, 04 Mar 2022 13:01:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="dyP/MFwp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbiCDU70 (ORCPT + 99 others); Fri, 4 Mar 2022 15:59:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbiCDU7X (ORCPT ); Fri, 4 Mar 2022 15:59:23 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77AEF419B5; Fri, 4 Mar 2022 12:58:34 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: sre) with ESMTPSA id 7F3BB1F469EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1646427513; bh=hTgfC44JS9v44NLsD1sg7Y1pWVGJtaRJ7sUIWmhL94M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dyP/MFwpz0UOS7kMPEvfTweRCqsKtp7dZgta3bMnXhGcc+jkvVKQZ8QoYxmpAstfR aC/cIHqtWLAJK2PqednXw/M9h9nxt53MOuJhaw5vZaD54OeHllhS0Uqnu4EuOcvZbp ZyHIXeG2lWYIj4OI2MjYS2unJscfG8H8zz4hx+rkBpDxlg6dq8H+4Qb3MZqBAXfPpc KTrsDUAMx8fvgBrQhZpe4yHwRqADaJ/d+xM5w8yg7JMJCTIh+gfGnBmHZKcFQ0pjLO dWx3FpD/uZEt3jQ+pUCV+Hvy2m90r7ZzCmM5M65e/yI0Db1gCtGT65nfdk1x2bNYiU nDwMoTzuVWA+g== Received: by mercury (Postfix, from userid 1000) id E1C301060602; Fri, 4 Mar 2022 21:58:30 +0100 (CET) Date: Fri, 4 Mar 2022 21:58:30 +0100 From: Sebastian Reichel To: Charles Keepax Cc: Jiasheng Jiang , patches@opensource.cirrus.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] power: supply: Handle error for wm8350_register_irq Message-ID: <20220304205830.udamvgsngin2gib5@mercury.elektranox.org> References: <20220304015751.367280-1-jiasheng@iscas.ac.cn> <20220304100011.GU38351@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nyivvc77cwjv2mom" Content-Disposition: inline In-Reply-To: <20220304100011.GU38351@ediswmail.ad.cirrus.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nyivvc77cwjv2mom Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Mar 04, 2022 at 10:00:11AM +0000, Charles Keepax wrote: > On Fri, Mar 04, 2022 at 09:57:51AM +0800, Jiasheng Jiang wrote: > > As the potential failure of the wm8350_register_irq(), > > it should be better to check it and return error if fails. > > Also, use 'free_' in order to avoid same code. > >=20 > > Fixes: 14431aa0c5a4 ("power_supply: Add support for WM8350 PMU") > > Signed-off-by: Jiasheng Jiang > > --- >=20 > Acked-by: Charles Keepax Thanks, queued. -- Sebastian --nyivvc77cwjv2mom Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmIifXYACgkQ2O7X88g7 +pqrTA/+PuT7os9q1eAwQg7iAxaYXRN5lEODz98SiA0Sjphxskwj4xf+M8RRPYo4 N3Fswgl6df7KiiqCsRbCaappMjvRPkU2y74dAiavo4kxytPI63DuW/CPk0E0lagm 15/Zhqj5tLKH2wBzJC54lgH7AijtPkprPQTaoNc4v6IEjiu9sS+1AipHYtlvX0Y5 e0BNATEZoT4NUn64Q2zWXD8ZjjcD4AwLqVtCpWeSRWKffw5c9fKkr6X6Tu1o7KVZ ydwTnuJUDfLqrvxfSyzVvC93vEmvqubBMyMB7XSeNlaFCWj06f0YF4B9qN4dabFs BsQE7WuUiFs4aI70OoEHeBBVkxH17kVgrHyYFC00UM+D6XYGJ5gEhqV0jWoj8K9c epNGfBSmxRqrsniGc4yKrBQFr0MC7iyaMS9omQOUw7Vy5mwI1TrfW3WRB49zfLIT DiupIuawh3VajLjwHw4/KGjUNH3d4Pk8LiuYiJZn3y6yk0gy1G/4WcnTaqRnJkyO UtWdqEHhmmsWEtaxtwL3ZpdocBXRvscPXJ6+SAtJP3XlEskSevzHF9oMunHvxzF0 s+8M9tDjGQ05Ywh1e8WhcHcTjL1cbOzMaXpgCPEgUXszpc5KkXyGyXYAwxknH/tK pTPOGLL2kET4zrI9QdD9EkyWe8QWWgHnsUyMxj8bKm8GedcWj9U= =ysUY -----END PGP SIGNATURE----- --nyivvc77cwjv2mom--