Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932945AbXBTNMy (ORCPT ); Tue, 20 Feb 2007 08:12:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932947AbXBTNMy (ORCPT ); Tue, 20 Feb 2007 08:12:54 -0500 Received: from mail.parknet.jp ([210.171.160.80]:1742 "EHLO parknet.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932945AbXBTNMx (ORCPT ); Tue, 20 Feb 2007 08:12:53 -0500 X-AuthUser: hirofumi@parknet.jp To: Vignesh Babu BM Cc: Kernel Janitors List , linux-kernel@vger.kernel.org Subject: Re: [KJ][PATCH] is_power_of_2 in fat References: <1171957794.6127.65.camel@wriver-t81fb058.linuxcoe> From: OGAWA Hirofumi Date: Tue, 20 Feb 2007 22:12:45 +0900 In-Reply-To: <1171957794.6127.65.camel@wriver-t81fb058.linuxcoe> (Vignesh Babu's message of "Tue\, 20 Feb 2007 13\:19\:54 +0530") Message-ID: <873b51j7le.fsf@duaron.myhome.or.jp> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1728 Lines: 53 Vignesh Babu BM writes: > Replacing (n & (n-1)) in the context of power of 2 checks > with is_power_of_2 > > Signed-off-by: vignesh babu Acked-by: OGAWA Hirofumi Thanks. > --- > diff --git a/fs/fat/inode.c b/fs/fat/inode.c > index a9e4688..8437190 100644 > --- a/fs/fat/inode.c > +++ b/fs/fat/inode.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > #include > > #ifndef CONFIG_FAT_DEFAULT_IOCHARSET > @@ -1216,8 +1217,7 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, > } > logical_sector_size = > le16_to_cpu(get_unaligned((__le16 *)&b->sector_size)); > - if (!logical_sector_size > - || (logical_sector_size & (logical_sector_size - 1)) > + if (!is_power_of_2(logical_sector_size) > || (logical_sector_size < 512) > || (PAGE_CACHE_SIZE < logical_sector_size)) { > if (!silent) > @@ -1227,8 +1227,7 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, > goto out_invalid; > } > sbi->sec_per_clus = b->sec_per_clus; > - if (!sbi->sec_per_clus > - || (sbi->sec_per_clus & (sbi->sec_per_clus - 1))) { > + if (!is_power_of_2(sbi->sec_per_clus)) { > if (!silent) > printk(KERN_ERR "FAT: bogus sectors per cluster %u\n", > sbi->sec_per_clus); > > -- -- OGAWA Hirofumi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/