Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Mar 2022 22:03:36 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Yihao Han <hanyihao@vivo.com>
Cc:     Chen-Yu Tsai <wens@csie.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@vivo.com
Subject: Re: [PATCH] power: supply: axp20x_ac_power: fix
 platform_get_irq.cocci warning
Message-ID: <20220304210336.pxuof34536g5w2ku@mercury.elektranox.org>
References: <20220303122719.2855-1-hanyihao@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tm4mdjva6vpqbfts"
Content-Disposition: inline
In-Reply-To: <20220303122719.2855-1-hanyihao@vivo.com>
Precedence: bulk


--tm4mdjva6vpqbfts
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Mar 03, 2022 at 04:27:19AM -0800, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>=20
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>=20
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/axp20x_ac_power.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/power/supply/axp20x_ac_power.c b/drivers/power/suppl=
y/axp20x_ac_power.c
> index ac360016b08a..57e50208d537 100644
> --- a/drivers/power/supply/axp20x_ac_power.c
> +++ b/drivers/power/supply/axp20x_ac_power.c
> @@ -377,11 +377,9 @@ static int axp20x_ac_power_probe(struct platform_dev=
ice *pdev)
>  	/* Request irqs after registering, as irqs may trigger immediately */
>  	for (i =3D 0; i < axp_data->num_irq_names; i++) {
>  		irq =3D platform_get_irq_byname(pdev, axp_data->irq_names[i]);
> -		if (irq < 0) {
> -			dev_err(&pdev->dev, "No IRQ for %s: %d\n",
> -				axp_data->irq_names[i], irq);
> +		if (irq < 0)
>  			return irq;
> -		}
> +
>  		power->irqs[i] =3D regmap_irq_get_virq(axp20x->regmap_irqc, irq);
>  		ret =3D devm_request_any_context_irq(&pdev->dev, power->irqs[i],
>  						   axp20x_ac_power_irq, 0,
> --=20
> 2.17.1
>=20

--tm4mdjva6vpqbfts
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmIifqgACgkQ2O7X88g7
+pr4fQ/+P4vl8QdMKX868E69dvmd9lMhr8cLEUqxkdXmNFZi07MX5qAe9WjRAc6U
xxrzbb97LpHEvoWTjTG9VTn6CHzej/WhVg3Yh5MRy+TZ7Dt2W3660rVKrIFr1NbI
ghfDpU9Ud7bFDC50vAlMzyX7aNrGBTsAYFh+WlYzvgtNp5UsG9NnogjKan7Pzml6
9+V1nlsEb4D6XCBQNi9GzpFFS3nGvUmuL9iHKOzK5nNAO72wqJ3zvq4ZVu5oz2kQ
PyFXHjqX0qRszB9qQpRkCB02t+o3ttSCX2YfsClAOwoYrK4r/1Cq8nZWbf066C3p
0HQXtx1GBjavk6XQ/kYVUobjPn39fuLSSxm89ScKKINvN3wgjpYHZMB6ieWqL3tR
v4+oAPrq2PL0GAUFBrlUIcxE6WcC9QkB3w6V4S7hfdWfvOAQo5Ziy7yVU9oYcggj
7v9Q7OfSsmeqa1IrL16SqAUwWkTJI32hZ3zzmV/Ip+uRDVbWPXIKl9It4qHPjHBW
jXtUktuIVcrVGrM4zeG50jH4t17KjOcy73qviA63Rc0/wmadBRY+gjnMOVshnSqH
SFgQzhwvG6n8v7vENmHK3qVCN4T6fZo8nM/DYE+txypUDLJMJehh8f2m63sFLeus
Zof+q1LTYiyMaal4pCuNP4A1yFq2jlr/oms/TfTu6fEJGihwX2w=
=Iw+l
-----END PGP SIGNATURE-----

--tm4mdjva6vpqbfts--