Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Mar 2022 22:04:27 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Yihao Han <hanyihao@vivo.com>
Cc:     Chen-Yu Tsai <wens@csie.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@vivo.com
Subject: Re: [PATCH] power: supply: axp20x_usb_power: fix
 platform_get_irq.cocci warnings
Message-ID: <20220304210427.mjocn3kdk26u5u7y@mercury.elektranox.org>
References: <20220302023451.5040-1-hanyihao@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7vo6g6q2c56odmp3"
Content-Disposition: inline
In-Reply-To: <20220302023451.5040-1-hanyihao@vivo.com>
Precedence: bulk


--7vo6g6q2c56odmp3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Mar 01, 2022 at 06:34:51PM -0800, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>=20
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>=20
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---

Thanks, queued (slightly modified to remove the now useless {}).

-- Sebastian

>  drivers/power/supply/axp20x_usb_power.c | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supp=
ly/axp20x_usb_power.c
> index a1d110f7ddce..75170fe79cbf 100644
> --- a/drivers/power/supply/axp20x_usb_power.c
> +++ b/drivers/power/supply/axp20x_usb_power.c
> @@ -638,8 +638,6 @@ static int axp20x_usb_power_probe(struct platform_dev=
ice *pdev)
>  	for (i =3D 0; i < axp_data->num_irq_names; i++) {
>  		irq =3D platform_get_irq_byname(pdev, axp_data->irq_names[i]);
>  		if (irq < 0) {
> -			dev_err(&pdev->dev, "No IRQ for %s: %d\n",
> -				axp_data->irq_names[i], irq);
>  			return irq;
>  		}
>  		power->irqs[i] =3D regmap_irq_get_virq(axp20x->regmap_irqc, irq);
> --=20
> 2.17.1
>=20

--7vo6g6q2c56odmp3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmIiftsACgkQ2O7X88g7
+pow8BAAnmIFHFIZxmxPvm/fmOAtvjEkKa80AtasHkaIcsT7uDiD0mr/w4wsb3Ul
sDQ4IMEVXaOK7OAddGzIO573405ZFdWskkiRTn7gBZd7tOJKe0iirOqwgZezjf/C
b0m9JTkeclZsDMNlKwIfRBTrEsrJcjJLPHEn0UDVDbDcUdMQ5z+eN2QRvZJ2CITF
4DwqMzqnvF0YJhGZequ5DPfeK3frgJU3ByqhOhRFrD32qRhy4YlyGx6mM195MODc
UjVIkT3miVFY6RnpwbHZkcBbLZQDazrUilTp6FCjV5ZpwxX6pit8ZVO+SxAPjg/k
TXUuMck81nkaGnIt4r76bouqGq0HC2X62CISr/o8S17tx3pOwhu6VRIbPWv5hP9j
/kHmI70IZVYu0UxYLBEGxEkefxSChgZ6Ur7ewqFulDsT3Q8hSKm9MBHUfiBk+wJj
JiGwwSCCSAG87F6t6aoahqxrYVEOxCvTUmbYrP8OomevmFxbRb//f/hrIS0JvI46
SFudcWMuRTCDEs35Bn0Y9qVBrc1FEXN8vR9Mthp77mti14KVMjumMSWfmk0DA4j5
fuCmZI9l5zbuvgIDsGyf8B04ChNZ61UX90isJSGovtZDGFFIkqUQUMB7CRjfFRuz
q1YTTLr9LK0PG6kcdTYaGBoYQ+fmkhF9rkduop1iDiytd1dXw04=
=VD+D
-----END PGP SIGNATURE-----

--7vo6g6q2c56odmp3--