Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2290661pxm; Fri, 4 Mar 2022 13:13:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJwDmDo0OAVpuGxo42FvFT2MucmzgsK4Wwax7p94cgnHLdkzdZPn7w3o0wghFm6lhSLAa2Fm X-Received: by 2002:a17:903:110d:b0:14f:72a1:7b18 with SMTP id n13-20020a170903110d00b0014f72a17b18mr450680plh.111.1646428401106; Fri, 04 Mar 2022 13:13:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646428401; cv=none; d=google.com; s=arc-20160816; b=M2rVJr7aMTMPGWfmfC9xXvgQmdNE/f2MzMpknehr+X6sAcjmvjbUp4XJv5a02bjMji 5imbRjIjdPMGGEW+eKwGaXOBxooUpr3Rj9Kx1CBaXvszCkCJpoh5QzaREvNRYkfgOL2I 5/6Qur3R9bnCLmFwIkyWBNyWN3EyGvgdp1GM/U56MrqnEoI+ZgAcBGNO3Cslkk00j0Ox eHnKI4wF9xzA0I1gDQe/dNpiqs5aBS7YvP8+VFFxBDCvpr3Y3MoJ9mnr0CZq9s945qNb Wg8BVwwYK4r0Ow5x37gPVV4NK6bhr7gTXs5ea6jiclrnHNqSc9hhux9gUyegETjvGUkc bxfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Coz50aIh+op5vSEWnrPJPbjgvlYxj+XgQk9B6io0ZLs=; b=IbM+aSzo2F3cx9F/yl+19hIkbJwz84BwmBvZ17xw+sUhqzFksrsBhitY1GS7QQ/k0W clsim+wSCLQu2Slv3Jayqd2AE6W8S7zo37TAxfpow6mSY1o5pX76eD1CvhgvuskqRRFn 17lkuBdeEOW+Yh/2rRINTZiYyNz+qhskOdLZwSR7Ja9uEOLNI2YPbeL/lVHkVtnok10x QYVvuboD+/emZO45z2sno+ZaFt/PX8icGGEjyWQ5DagRxLzAK6yxoxamjXUmBRYPiOr1 Ys1pO335RRy41vBn01+lOjzZyhkQdhxuzF0NhuCk16TOwrltQztVntGR8zBkEpNEs+88 wlag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=PGMB4Hrp; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id w10-20020a17090a4f4a00b001bd14e030bdsi488199pjl.149.2022.03.04.13.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 13:13:21 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=PGMB4Hrp; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8438413C241; Fri, 4 Mar 2022 12:26:08 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229895AbiCDUYG (ORCPT + 99 others); Fri, 4 Mar 2022 15:24:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229869AbiCDUYC (ORCPT ); Fri, 4 Mar 2022 15:24:02 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E44620D505 for ; Fri, 4 Mar 2022 12:23:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Coz50aIh+op5vSEWnrPJPbjgvlYxj+XgQk9B6io0ZLs=; b=PGMB4Hrpmshy4FMED5pRwSdoYp hJexJHKeDWUVViplILvIyAvnsFd4DbQKl9HFMfD/M6XEzHF86MwU1fwUDM54aF3mh4tak1NcW4kGO cpLXUe+w0E5zcCKbjDNm87E0E5RbwQgfuiXay+3NCqp069qfgsAz29hKO9xr9QZMUUPEhiMenz6u/ CRKA5XqUOlNfMzC0QS8Nxgy7ZYAbWPyyuitk0MK7YwO51re8QnzeHo21OVAJB3gDVwUrlsi8Ztkxz oCA0ZXfRos2Voxd7SvO0kC54wCPHHjl3NGvfzTd7+6Ziz5UbWUsPQrRiSmGI9BN1FuDwKb/Eshkdm HtN9tpoQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQES2-00Cz5S-HF; Fri, 04 Mar 2022 20:22:59 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 254D098624E; Fri, 4 Mar 2022 21:22:58 +0100 (CET) Date: Fri, 4 Mar 2022 21:22:58 +0100 From: Peter Zijlstra To: Josh Poimboeuf Cc: x86@kernel.org, joao@overdrivepizza.com, hjl.tools@gmail.com, andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org, ndesaulniers@google.com, keescook@chromium.org, samitolvanen@google.com, mark.rutland@arm.com, alyssa.milburn@intel.com, mbenes@suse.cz, rostedt@goodmis.org, mhiramat@kernel.org, alexei.starovoitov@gmail.com Subject: Re: [PATCH v3 05/39] x86/ibt: Add ANNOTATE_NOENDBR Message-ID: <20220304202258.GP11184@worktop.programming.kicks-ass.net> References: <20220303112321.422525803@infradead.org> <20220303112825.251775688@infradead.org> <20220304185953.pom5at6roevsmm2w@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220304185953.pom5at6roevsmm2w@treble> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 04, 2022 at 10:59:53AM -0800, Josh Poimboeuf wrote: > On Thu, Mar 03, 2022 at 12:23:26PM +0100, Peter Zijlstra wrote: > > In order to have objtool warn about code references to !ENDBR > > instruction, we need an annotation to allow this for non-control-flow > > instances -- consider text range checks, text patching, or return > > trampolines etc. > > > > Signed-off-by: Peter Zijlstra (Intel) > > Reviewed-by: Kees Cook > > --- > > include/linux/objtool.h | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > Also needs copied over to tools/include/linux/objtool.h to avoid the > sync warning. Urgh yeah, I keep meaning to add that bit and then immediately forget about it :/