Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 4 Mar 2022 20:25:27 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yajun Deng <yajun.deng@linux.dev>
Cc:     leonro@nvidia.com, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-next] RDMA/core: Fix ib_qp_usecnt_dec() called when
 error
Message-ID: <20220305002527.GC1248225@nvidia.com>
References: <20220303024232.2847388-1-yajun.deng@linux.dev>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220303024232.2847388-1-yajun.deng@linux.dev>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?psOsAOjy5gp/pQZ/0KXCJ+wd2wMPQkpu5ZD/4CqHjU4pY3dxhzcgmZPmRB5e?=
 =?us-ascii?Q?NHp9KBg0ZFGeuXWHGSkITneXRkM6UucfNH83vmjq17lt3wMXjY2Je33IKWbb?=
 =?us-ascii?Q?0y5+qmp8RcOIjobHBkdVNLVpHp9UUU8dXvUfnc5dI2HN3XgYNDNokG5klpRa?=
 =?us-ascii?Q?2TfV2fJF2QR2A7pXL0kbmKhQLCuKSFH06Cl308qIjrmX/isfzy9VxoWJjFRc?=
 =?us-ascii?Q?SszDFMhFgfZtXfG8Ym71XQf27BhfuQMUKtAI77usgTXxFMjDoJjT1WnoeEwB?=
 =?us-ascii?Q?dmH5RL8yyFpAMpcGSRCzbzJc1wMaf30jq8w3dZnukmnzsQA2ivAqFj09iQt+?=
 =?us-ascii?Q?cLVK9djdHDGhNavyJeZHuRA/DuyL9W1uJPX1PjuFn4qYF4wyJ2EY017t/dG7?=
 =?us-ascii?Q?EIIm4vWJD71rqcVW4kszDUf8vAk6XtPGWC2SRlQLoKUpQ1UPcHoHlu1e1G/W?=
 =?us-ascii?Q?2eK3qtvF0Wj9Krciptn5Xnft6PwyNaVhz6DHlZEj1dzyDEPDh4Z283Lfqq9f?=
 =?us-ascii?Q?o6MKIlXANeCttBv2ftCvMEZ1i54tZ2O4KFC0Gu2iZllWHpDqfV2tS/6Z2urQ?=
 =?us-ascii?Q?Ks1rqRzim5KErC5SqkUzYpa5BgzSCxGU1AXqKvhleUMRrL6LbUwjN74l4G+6?=
 =?us-ascii?Q?S/PsXzLlTQS+egNbSEwJscbVVOSeZKmtGoSEv0dTxvkM9r9CGsvPjcDbDtHb?=
 =?us-ascii?Q?XOV0BirxUtTQ5IR7AB4g8H4WxQbVHKREfM/lderRotVNcvBsZ2skcsrHhbpq?=
 =?us-ascii?Q?jCZ0F587DPLigoU0ksI7wm6mavy0RGcki2a/IWPoRxEkkSGzYQw6aFy5Whqp?=
 =?us-ascii?Q?BCDQHY+7HYemy1eFgfLzdOwP+5iVm+4jeJLjqKk26EIRFv/LRk9Py0+E3rrB?=
 =?us-ascii?Q?Hrtwvx2YQVajcn+Wh7W8812siNqsRWNp4wUyrkF0DI3UyA5mDLwPx1Si5Bv0?=
 =?us-ascii?Q?zIDQjZsGMznPb6F0c3LkJ2rOEhpULKpvv9sWvHnxeU3JhZ+HqhkG5LImbmTW?=
 =?us-ascii?Q?jR1Ub8wOiaUqfVEiO9bLaesiYcaPvpNJP0+Cdhb7D9JWJ3HvdkLcw0nzxGZx?=
 =?us-ascii?Q?WeTrTnZ21CYLbK7d483rzQnHqkWvvDYmEoRUm/Ojc9pxjjM8FdwlRNs50HP7?=
 =?us-ascii?Q?Um6RZsNwEpQ+hBd+cOg2P1boH6QrTuxSXisJiSDV/kq5zRAUSHAN1ai1QI6M?=
 =?us-ascii?Q?ucIV7ZWA+ftCmHaEqM8aUioWCUiunuJrj0J8gWEDfmBKr3DXqGL4u9HaIbtc?=
 =?us-ascii?Q?+qCE19+UdDugD4FQgz0XHpLGJrEFw39DWR8DsrQrwwK2ZQq5E1L3Ua/40lts?=
 =?us-ascii?Q?rCxho9s+jw5lKDoS9oKgvzDDowjarZxBxVH2tKnrxih+cq48b4OtI/9ZF9oM?=
 =?us-ascii?Q?kMAi3miABg8Ja0w0hDZnXHq0DlE96lISJQbdTUJ6Ctk81rScUdhnsaQvq4No?=
 =?us-ascii?Q?8unU/pfR9/bT0ovrktE9utQzeBlqOPNAegR7akWjMNgan86nsYxDLcIRF7Vi?=
 =?us-ascii?Q?qZjD3R1Tq1d18MiMAVCMhA7ViPCMLzD162DF8NeoJoorRMqf/K3izkZWN4kW?=
 =?us-ascii?Q?AVeNzXLnxEuCcbM1E4c=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff314c6f-e116-4a3a-f152-08d9fe3ea6ad
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2022 00:25:28.9681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2wxqNQIK6M3HipAJp8PGJvqrqmi/H+2bF0lDv9yBZteJePKhNV838cSsEYIQ02yp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3925
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 03, 2022 at 10:42:32AM +0800, Yajun Deng wrote:
> ib_destroy_qp() would called by ib_create_qp_user() if error, the former
> contains ib_qp_usecnt_dec(), but ib_qp_usecnt_inc() was not called before.
> 
> So move ib_qp_usecnt_inc() into create_qp().
> 
> Fixes: d2b10794fc13 ("RDMA/core: Create clean QP creations interface for uverbs")
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  drivers/infiniband/core/uverbs_cmd.c          | 1 -
>  drivers/infiniband/core/uverbs_std_types_qp.c | 1 -
>  drivers/infiniband/core/verbs.c               | 3 +--
>  3 files changed, 1 insertion(+), 4 deletions(-)

Applied to for-next, thanks

Jason