Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] isdn: hfcpci: check the return value of dma_set_mask() in
 setup_hw()
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     isdn@linux-pingi.de, davem@davemloft.net, zou_wei@huawei.com,
        zheyuma97@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220303025710.1201-1-baijiaju1990@gmail.com>
 <20220303211557.16458976@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Message-ID: <1650c170-3223-d74f-23ac-a05440765ad0@gmail.com>
Date:   Sat, 5 Mar 2022 16:34:44 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20220303211557.16458976@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2022/3/4 13:15, Jakub Kicinski wrote:
> On Wed,  2 Mar 2022 18:57:10 -0800 Jia-Ju Bai wrote:
>> The function dma_set_mask() in setup_hw() can fail, so its return value
>> should be checked.
>>
>> Fixes: e85da794f658 ("mISDN: switch from 'pci_' to 'dma_' API")
> The change under Fixes only switched the helper the driver uses,
> it did not introduce the problem. The Fixes tag should point to
> the earliest commit where the problem is present.

Hi Jakub,

Thanks for the advice.
I will send a V2 patch.


Best wishes,
Jia-Ju Bai