Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] dma: xilinx: check the return value of dma_set_mask() in
 zynqmp_dma_probe()
To:     Michael Tretter <m.tretter@pengutronix.de>
Cc:     vkoul@kernel.org, michal.simek@xilinx.com, yukuai3@huawei.com,
        lars@metafoo.de, libaokun1@huawei.com, dmaengine@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
References: <20220303024334.813-1-baijiaju1990@gmail.com>
 <20220304082024.GO8137@pengutronix.de>
From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Message-ID: <47bca068-9bc2-73c7-dfa4-ddd5ce78618c@gmail.com>
Date:   Sat, 5 Mar 2022 16:38:07 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20220304082024.GO8137@pengutronix.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2022/3/4 16:20, Michael Tretter wrote:
> On Wed, 02 Mar 2022 18:43:34 -0800, Jia-Ju Bai wrote:
>> The function dma_set_mask() in zynqmp_dma_probe() can fail, so its
>> return value should be checked.
>>
>> Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver support")
>> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
>> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
>> ---
>>   drivers/dma/xilinx/zynqmp_dma.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
>> index 7aa63b652027..963fb1de93af 100644
>> --- a/drivers/dma/xilinx/zynqmp_dma.c
>> +++ b/drivers/dma/xilinx/zynqmp_dma.c
>> @@ -1050,7 +1050,8 @@ static int zynqmp_dma_probe(struct platform_device *pdev)
>>   	zdev->dev = &pdev->dev;
>>   	INIT_LIST_HEAD(&zdev->common.channels);
>>   
>> -	dma_set_mask(&pdev->dev, DMA_BIT_MASK(44));
>> +	if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(44)))
>> +		return -EIO;
> Thanks.
>
> You may print an error message with dev_err_probe and forward the return value
> of dma_set_mask.

Hi Michael,

Thanks for the advice.
I will send a V2 patch.


Best wishes,
Jia-Ju Bai