Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp437561pxp; Sat, 5 Mar 2022 07:46:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJwFJiNmTw3qrFjPv2YB8zd1O9wt8vdu/PXFY3dgcPgf4QX6uyvilNvWLWnPTptUu/zTVMFH X-Received: by 2002:a17:90b:314a:b0:1bf:fff:ee94 with SMTP id ip10-20020a17090b314a00b001bf0fffee94mr4286893pjb.169.1646495203024; Sat, 05 Mar 2022 07:46:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646495203; cv=none; d=google.com; s=arc-20160816; b=tXrkEcLe/kx3TDs9Gk2u/BnSkL8CViwr/3aLbwzR4wte4XnQT9oFDaViBRCqJWe8NH eri52iTHT445CDgmZqxZUZZD7v1mYS9h8uLg6l0ANn70qvRx4yzLaKJgk3HwXKOThMhu 52y4KwY5H2vv1CdfktSfBTNMmA3rH/v3D4ErMeRepdwh4Aaaat+CtG1/txhIiurffc1T rTHWxRqhZK/YN2ei78KJLHuTeIcgQYFaG4sLGWo41yAIRxeczYSDJJaGTKxFnPd1sqKY fPlzPEXG8mVGNfGAlFzJy4h87q6nb7P1ALoKUF6A7L8sIlwsGoJKd2b+PTN4hEmkfVU5 uo4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=o8YRPKtxEMPdU6+Q3B6e4fqO0sPdCeK3qQDcbu/LSDI=; b=Dx0eDwS/rvMRwBvqKPPNp6TX6DijaBJcUw0Jxz0KdVFKuWZayGMWFPNero7/Y6LxF1 eWxob+9E+kjj13ExPrM6H5jh1kRlwjvc5BdeUmAs1kbVVWqlSLgbPWvaWMySVOkoTfwT 2u1x4HS/VrWWHi4FW9urhfvF/pY6xsY1cnZcVUuq13Jv5i5zao9DxK6iyB3ttcR8IvD7 kRJix1bntnTm08Vf6tnfSZkAolyOvQQ00YLVdT9QrDhJrAjywD3TCK3FnxCl1uK0sr33 X6LQQTqkj2adlNQmlimOyffPlRGIPiz2D4blzRK9I8Pn1ajP8DLHu9Wht52/FZV4+Q4r tuIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=lHnnCFcH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ay5-20020a1709028b8500b0014f37e13994si7301969plb.595.2022.03.05.07.46.24; Sat, 05 Mar 2022 07:46:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=lHnnCFcH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230401AbiCEJiF (ORCPT + 99 others); Sat, 5 Mar 2022 04:38:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230392AbiCEJiC (ORCPT ); Sat, 5 Mar 2022 04:38:02 -0500 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D089D23D032 for ; Sat, 5 Mar 2022 01:37:12 -0800 (PST) Received: by mail-yb1-xb2d.google.com with SMTP id x200so21563319ybe.6 for ; Sat, 05 Mar 2022 01:37:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o8YRPKtxEMPdU6+Q3B6e4fqO0sPdCeK3qQDcbu/LSDI=; b=lHnnCFcHOLqcqZMm+7wQDnMfORjxrlVmpEtEJuS6gqKBKU+vVsAsu/j2DDL/uk7k/4 vnoJald/c6ZzlLjFH0RiIW6L4/ClW47utWEV4ymBywMHUbQ31+5jSCXbNVOGEZMB+ALy 7Qd2TCsiTF+jFtlMtgK0GzOZz0abu2MV4x1XAdr1CalMppFy7btDAv8CuSENnArupIMq Hp3va2VbOL9LRQN6ahlW/H5+aNj/smQDh49mLjExKFZbzv5CLdqOJF0YhVzC29GJOfkX XgYn2Vu+HmHcFwlm1hjPtRMCdnkR5C2ETrWUjxvf+/3acp2xLbOMjHRB4h/mtAt1uDvz p4Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o8YRPKtxEMPdU6+Q3B6e4fqO0sPdCeK3qQDcbu/LSDI=; b=K8Xwst+PXJsldTySR4rAETQSIlYt6LvhQAf9Q9Ccafj1M/HT3tzXnGKuMgpre2G68A I9wfbHhxPmXVkpF3MLsPbNTuep6jPTXxr1oJjD4qja2maLYylp6fXAuGH27wKRXFNjQm Vp85UCXb4KGPOV+ESlI33qwsFN5TgBQtoTwNEU+e8ztHNbGSdiUtAcrdjNE1Xt6B1jfU ZNh8s0aWouxlQ79Q02KIvQTGJneJv7LQKWTdHczhItpwle3REib1j5V1RnObp3DO3MWn ok7dKs6N+IRNnbLd0C6x8yn61xD+OOCo6VdXHi+cvySSUzxzXQXB4IuA4gJ2r2T99cx+ pwBw== X-Gm-Message-State: AOAM533DPyM7rvq1gfoNa5sLHlStpPIeY+k6B5eX1u9nmHAziThSh9/7 tDimaQzMdK/n9ne0f5UszNcpxpozP0kK6G+0TDbeyA== X-Received: by 2002:a25:6994:0:b0:629:1e05:b110 with SMTP id e142-20020a256994000000b006291e05b110mr497927ybc.425.1646473031701; Sat, 05 Mar 2022 01:37:11 -0800 (PST) MIME-Version: 1.0 References: <20220303031505.28495-1-dtcccc@linux.alibaba.com> <20220303031505.28495-2-dtcccc@linux.alibaba.com> In-Reply-To: From: Marco Elver Date: Sat, 5 Mar 2022 10:36:35 +0100 Message-ID: Subject: Re: [RFC PATCH 1/2] kfence: Allow re-enabling KFENCE after system startup To: Tianchen Ding Cc: Alexander Potapenko , Dmitry Vyukov , Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 5 Mar 2022 at 07:06, Tianchen Ding wrote: [...] > Hmm... > I found KFENCE_WARN_ON() may be called when sample_interval==0. (e.g., > kfence_guarded_free()) > So it's better to add a bool. Yes, that's probably safer and easier. Thanks, -- Marco