Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
User-Agent: Cyrus-JMAP/3.5.0-alpha0-4778-g14fba9972e-fm-20220217.001-g14fba997
Mime-Version: 1.0
Message-Id: <2e36dae0-7eff-43fc-b1a5-2c530f56e877@www.fastmail.com>
In-Reply-To: <0d7b9a17-f5fc-69e5-173f-1c897522d3f3@canonical.com>
References: <20220227115743.69059-1-sven@svenpeter.dev>
 <0d7b9a17-f5fc-69e5-173f-1c897522d3f3@canonical.com>
Date:   Sat, 05 Mar 2022 13:00:17 +0100
From:   "Sven Peter" <sven@svenpeter.dev>
To:     "Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
        "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
        "Rob Herring" <robh+dt@kernel.org>
Cc:     "Hector Martin" <marcan@marcan.st>,
        "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
        "Mark Kettenis" <kettenis@openbsd.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: nvmem: Add apple,efuses
Content-Type: text/plain
Precedence: bulk


On Thu, Mar 3, 2022, at 19:00, Krzysztof Kozlowski wrote:
> On 27/02/2022 12:57, Sven Peter wrote:
>> Apple SoCs come with eFuses used to store factory-programmed data
>> such as calibration settings for the PCIe and Type-C PHY.
>> 
>> Signed-off-by: Sven Peter <sven@svenpeter.dev>
>> ---
>>  .../bindings/nvmem/apple,efuses.yaml          | 50 +++++++++++++++++++
>>  MAINTAINERS                                   |  1 +
>>  2 files changed, 51 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/nvmem/apple,efuses.yaml
>> 
>> diff --git a/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml b/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml
>> new file mode 100644
>> index 000000000000..a735d54856ae
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml
>> @@ -0,0 +1,50 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/nvmem/apple,efuses.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Apple SoC eFuse-based NVMEM
>> +
>> +description: |
>> +  Apple SoCs such as the M1 contain factory-programmed eFuses used to e.g. store
>> +  calibration data for the PCIe and the Type-C PHY or unique chip identifiers such
>> +  as the ECID.
>> +
>> +maintainers:
>> +  - Sven Peter <sven@svenpeter.dev>
>> +
>> +allOf:
>> +  - $ref: "nvmem.yaml#"
>> +
>> +properties:
>> +  compatible:
>> +    items:
>> +      - enum:
>> +          - apple,t8103-efuses
>> +          - apple,t6000-efuses
>> +      - const: apple,efuses
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    efuse@3d2bc000 {
>> +        compatible = "apple,t8103-efuses", "apple,efuses";
>> +        reg = <0x3d2bc000 0x1000>;
>> +        #address-cells = <1>;
>> +        #size-cells = <1>;
>> +
>> +        ecid: efuse@500 {
>> +              reg = <0x500 0x8>;
>
> Mismatched indentation. Rest looks good.

Good catch, thanks! Will fix it for v2.


Best,


Sven