Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-68e1ed73-5a31-42d1-838e-0a837e686c4a-1646474868401@3c-app-gmx-bap19>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Rob Herring <robh@kernel.org>
Cc:     Frank Wunderlich <linux@fw-web.de>, devicetree@vger.kernel.org,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Jens Axboe <axboe@kernel.dk>,
        "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
        <linux-ide@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Peter Geis <pgwipeout@gmail.com>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@broadcom.com>
Subject: Aw: Re: Re: [PATCH v4 1/5] dt-bindings: Convert ahci-platform DT
 bindings to yaml
Content-Type: text/plain; charset=UTF-8
Date:   Sat, 5 Mar 2022 11:07:48 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <CAL_JsqJMZ1mZ91SYZR03rMkK-ZqFd-tCwV6zOrNu5NmP6V+duA@mail.gmail.com>
References: <20220301152421.57281-1-linux@fw-web.de>
 <20220301152421.57281-2-linux@fw-web.de>
 <Yh+0B+iKx1gJXXCk@robh.at.kernel.org>
 <trinity-1ca1f3fd-1eeb-4c8d-a7e2-65851eb8002b-1646291055736@3c-app-gmx-bs69>
 <CAL_JsqJMZ1mZ91SYZR03rMkK-ZqFd-tCwV6zOrNu5NmP6V+duA@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi

> Gesendet: Samstag, 05=2E M=C3=A4rz 2022 um 00:37 Uhr
> Von: "Rob Herring" <robh@kernel=2Eorg>

> > > > +  ports-implemented:
> > > > +    $ref: '/schemas/types=2Eyaml#/definitions/uint32'
> > > > +    description:
> > > > +      Mask that indicates which ports that the HBA supports
> > > > +      are available for software to use=2E Useful if PORTS_IMPL
> > > > +      is not programmed by the BIOS, which is true with
> > > > +      some embedded SoCs=2E
> > > > +    maxItems: 1
> > >
> > > A uint32 is only ever 1 item=2E Drop=2E
> > >
> > > IIRC, isn't the max here 0xff? Add constraints=2E
> >
> > i've found it only set to 0x1 so i have currently set the maximum to 0=
x1, is this ok?
> > If some higher value is needed binding needs to be touched=2E=2E=2E
>=20
> There's a spec for it, so no need to look at what's used=2E Calxeda AHCI
> had 5 ports IIRC=2E

as far as i understand code in libahci=2Ec line 535+ [1]
i guess i need to set lower 5 bits to 1 for 5 ports, right? resulting in m=
ax value 0x1f

> > now i have only the marvell-errors about incomplete sata-port subnode =
(without phy/target-supply) like i mention in the patch=2E=2E=2Ehow to proc=
eed with this?
>=20
> So the child nodes are incomplete? They should be disabled then
> (status =3D "disabled") and that turns off required properties checks=2E

thanks, have disable the nodes and reenable them where phys/target-supply =
was added [2]=2E=2E=2E

now the dtbs_check is clean

[1] https://elixir=2Ebootlin=2Ecom/linux/v5=2E17-rc6/source/drivers/ata/li=
bahci=2Ec#L535
[2] https://github=2Ecom/frank-w/BPI-R2-4=2E14/commits/5=2E17-next-2022022=
5

regards Frank