Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1084889pxp; Sun, 6 Mar 2022 05:30:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJxyAeX3GBC2BJNXzPgXEulE7j5gpecawIjZtE502woLjN3jyljKlUoa7yEIF4JqbtuMlAg+ X-Received: by 2002:a17:902:e745:b0:151:5474:d3ed with SMTP id p5-20020a170902e74500b001515474d3edmr7416626plf.106.1646573402835; Sun, 06 Mar 2022 05:30:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646573402; cv=none; d=google.com; s=arc-20160816; b=zTAzmQc3yIHfuYK2VFMiuwiKtRfIQj3iCeC6ZsLm/+NLfB0SfnS0APw0dgDMSBizXL gO3jhORbmeEAn6DEr2mJbffQlkWG6wCDn09YakvAC808BW1Eu7Cqfwr0XdzhhDZzAKU2 31EIc/FNOyrZiBbrVFJQ4j2hq79jKlaKSt2OBIamI+4M6dvxJL/gtKnjFMrLDkMsNQcB 5QVFhHC/m6DmZY4wAGLVS37GIDEU2WqtZTYtzKcvTlDrg6C1TRXGcZiLZZS7XsJPhNNu bixk7If88GdHbMUimAzlWY6tJqRabCqoGV9eCIajRbSp4yUlKgxOna3dI6K0XgFO6TV1 nOoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4bHhpltx5t5BGct675dtWCaSJ7bKFWsocHgCtE6eVVc=; b=aOFAyDLpQp0fKuqVc/+eQbKujRKbcnO36t7Sw5Y4GeiTE1BkRJAv4pyPGp9shFwfvH HB7CjIhCoJA3UcJEFbdDbi3AputAA8K8cOVGEDb1tFpc0m/MxyzansMIvCC4YVJOSqSS 0ic/uhpThjxXcN9vgaBLPHJeG2WYifHRcT80QykaesLUuMmUwedIuy+9TObAyiV24WZg ARz4Uj5L9Z+c27GjK5iYeIxHGtjKuvI487FY5Cl5kVeg/uR/VnFeYcoq7r5QMdLqpEV4 P1nJ8NeChgenp4EVszZ4lOtbTax1Pcop6jBGFvCeeTddkOX8UXY2oKp9VvO+PCmO2GQA K2Uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=bzJD080S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h2-20020a636c02000000b003803fbe150bsi709310pgc.334.2022.03.06.05.29.30; Sun, 06 Mar 2022 05:30:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=bzJD080S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233392AbiCFMQh (ORCPT + 99 others); Sun, 6 Mar 2022 07:16:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbiCFMQg (ORCPT ); Sun, 6 Mar 2022 07:16:36 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3AE15C649; Sun, 6 Mar 2022 04:15:44 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id z16so11476958pfh.3; Sun, 06 Mar 2022 04:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4bHhpltx5t5BGct675dtWCaSJ7bKFWsocHgCtE6eVVc=; b=bzJD080S+XDAsKEY1Tr7d58HsT3skQFMC81wCT3/qmQ5zO6HxEX7M9FgRMbI9kgC+R WC83rFFuxsgaLokbgjnHTjxHD4T1GZEShuQKBF1eM3VksSygT57ZEYXbS40qcpGI+FWN 8OIO8kx9/lpSQbcQ3hAzqNrolTD1gDdMMphGIcqyYAl5KgdxWekcv65x1gcq1cHZkRpI 3iTxLizN8EPTFcwca8Vo3hz5bpR/VWPz+P3LSOH242Z7AuaE2phWnRKGRusidEgHQthi GfPmySoiT71SybnHtyIc/vWUS2kTK5svvBrEIVp9htwhAxi3VLhpBB5GnbNDDUPlGpPS lzug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4bHhpltx5t5BGct675dtWCaSJ7bKFWsocHgCtE6eVVc=; b=QxRvPcErG3N35rSQ7Y1nY3cXFT6fD/Qc8Jaul5l/PgZxRTGsU1F/BWMOBpNXWps3t/ qg+1Du870kZWQlvksiDf0K2AOqDiqXQdwIknrs5J4PYl05ZAznPnaDkm/3qUtwVsESMQ nz5vd5cETSfIyztQG4VIu1pua17K/Gq3BjZc4fVXr+aVfVJFJhlM2em30mJKqcMEkg04 C4LYfuEkZhwk0O4XR6TXdEZe8FfmYHybTWBRH5BwSPawPOVDIWopjdESNo/try9Fy1b8 w6nHeI/kcM3U78uWMS/pyMQ328/ATBvDwG1911nBBiyhCAipb9fhdYtPUPCrCRtqWm10 APdQ== X-Gm-Message-State: AOAM532OukwLLL1rxa6FD6dFhiGpjdl/ljcORJhUcGZN5MqHFsdejwrr AP83h8CWjWtSw/LI1PhLDYs= X-Received: by 2002:a63:5214:0:b0:373:8aca:7453 with SMTP id g20-20020a635214000000b003738aca7453mr5826444pgb.574.1646568944065; Sun, 06 Mar 2022 04:15:44 -0800 (PST) Received: from baaz.falakreyaz.gmail.com.beta.tailscale.net ([49.36.203.74]) by smtp.gmail.com with ESMTPSA id me8-20020a17090b17c800b001bce9d8e61fsm16481253pjb.50.2022.03.06.04.15.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Mar 2022 04:15:43 -0800 (PST) From: Muhammad Falak R Wani To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Muhammad Falak R Wani Subject: [PATCH bpf-next] samples/bpf: fix broken bpf programs due to function inlining Date: Sun, 6 Mar 2022 17:45:35 +0530 Message-Id: <20220306121535.156276-1-falakreyaz@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit: "be6bfe36db17 block: inline hot paths of blk_account_io_*()" inlines the function `blk_account_io_done`. As a result we can't attach a kprobe to the function anymore. Use `__blk_account_io_done` instead. Signed-off-by: Muhammad Falak R Wani --- samples/bpf/task_fd_query_kern.c | 2 +- samples/bpf/tracex3_kern.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/bpf/task_fd_query_kern.c b/samples/bpf/task_fd_query_kern.c index c821294e1774..186ac0a79c0a 100644 --- a/samples/bpf/task_fd_query_kern.c +++ b/samples/bpf/task_fd_query_kern.c @@ -10,7 +10,7 @@ int bpf_prog1(struct pt_regs *ctx) return 0; } -SEC("kretprobe/blk_account_io_done") +SEC("kretprobe/__blk_account_io_done") int bpf_prog2(struct pt_regs *ctx) { return 0; diff --git a/samples/bpf/tracex3_kern.c b/samples/bpf/tracex3_kern.c index 710a4410b2fb..bde6591cb20c 100644 --- a/samples/bpf/tracex3_kern.c +++ b/samples/bpf/tracex3_kern.c @@ -49,7 +49,7 @@ struct { __uint(max_entries, SLOTS); } lat_map SEC(".maps"); -SEC("kprobe/blk_account_io_done") +SEC("kprobe/__blk_account_io_done") int bpf_prog2(struct pt_regs *ctx) { long rq = PT_REGS_PARM1(ctx); -- 2.35.1