Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4c8f31d0-d51c-bb8c-acae-da1f1b1ada51@infradead.org>
Date:   Sat, 5 Mar 2022 19:49:40 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [next] mips-mt.c:233:19: error: conflicting types for 'mt_init'
Content-Language: en-US
To:     Naresh Kamboju <naresh.kamboju@linaro.org>,
        linux-mips@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>,
        Linux-Next Mailing List <linux-next@vger.kernel.org>,
        Liam Howlett <liam.howlett@oracle.com>
Cc:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Kees Cook <keescook@chromium.org>,
        Juxin Gao <gaojuxin@loongson.cn>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        lkft-triage@lists.linaro.org
References: <CA+G9fYtEx=k9TM7c7EihbO3U0qxZLbKX26NWJ1L=jjEOuy7cHQ@mail.gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <CA+G9fYtEx=k9TM7c7EihbO3U0qxZLbKX26NWJ1L=jjEOuy7cHQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Liam,

Would you consider renaming maple tree's "mt_init()" function to
maple_tree_init() or mtree_init() or something that does not
conflict with the mt_init() function in arch/mips/ so that
these build errors don't happen?

thanks.

On 2/24/22 23:09, Naresh Kamboju wrote:
> [Please ignore this email if it is already reported]
> 
> Linux next-20220224 arch mips build errors / warnings noticed [1].
> 
> Build configs:
>   -  mips-gcc-8-malta_defconfig
>   -  mips-gcc-10-malta_defconfig
>   -  mips-gcc-8-defconfig
>   -  mips-gcc-10-defconfig
> 
> metadata:
>     git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>     git_sha: 44948bd49d878dad6c9707e34f4a06df73c3a800
>     git_short_log: 44948bd49d87 (\Add linux-next specific files for 20220224\)
>     kconfig: defconfig
>     target_arch: mips
>     toolchain: gcc-10
> 
> 
> Build errors / warnings:
> 
> arch/mips/kernel/mips-mt.c:233:19: error: conflicting types for 'mt_init'
>   233 | static int __init mt_init(void)
>       |                   ^~~~~~~
> In file included from include/linux/mm_types.h:12,
>                  from include/linux/mmzone.h:21,
>                  from include/linux/gfp.h:6,
>                  from include/linux/radix-tree.h:12,
>                  from include/linux/idr.h:15,
>                  from include/linux/kernfs.h:12,
>                  from include/linux/sysfs.h:16,
>                  from include/linux/kobject.h:20,
>                  from include/linux/energy_model.h:7,
>                  from include/linux/device.h:16,
>                  from arch/mips/kernel/mips-mt.c:7:
> include/linux/maple_tree.h:589:20: note: previous definition of
> 'mt_init' was here
>   589 | static inline void mt_init(struct maple_tree *mt)
>       |                    ^~~~~~~
> make[3]: *** [scripts/Makefile.build:288: arch/mips/kernel/mips-mt.o] Error 1
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> Steps to reproduce:
> ------------------
> # To install tuxmake on your system globally:
> # sudo pip3 install -U tuxmake
> 
> tuxmake --runtime podman --target-arch mips --toolchain gcc-10
> --kconfig defconfig
> 
> --
> 
> [1] https://builds.tuxbuild.com/25aFF2X7uoyebURaYzNHW9FVEmN/

-- 
~Randy