Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 6 Mar 2022 15:12:12 +0000
From:   Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To:     Paul Cercueil <paul@crapouillou.net>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Randy Dunlap <rdunlap@infradead.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Wei WANG <wei_wang@realsil.com.cn>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        <jonathan.cameron@huawei.com>
Subject: Re: [PATCH -next] misc: rtsx: fix build for CONFIG_PM not set
Message-ID: <20220306151212.00003e6f@Huawei.com>
In-Reply-To: <7U5Z7R.RNKITPUWCPX32@crapouillou.net>
References: <20220226222457.13668-1-rdunlap@infradead.org>
        <CAK8P3a07PoFGC8jyRG5_CjfVPCc2T79c7Fs_WmHZEkuqtG+oPg@mail.gmail.com>
        <449d6ceb-7308-9543-c23c-831bebffda21@infradead.org>
        <CAK8P3a30RbSk3Y5CyRrOjfTiq0c9XGxC3qjAD0154j3a7k+xQQ@mail.gmail.com>
        <0D5Z7R.NUOWBMRT4GQ2@crapouillou.net>
        <CAK8P3a3=5uud3jd7N3FEAnaLapX-0OYaiscBFNEQm2hzkTmj7g@mail.gmail.com>
        <7U5Z7R.RNKITPUWCPX32@crapouillou.net>
Organization: Huawei Technologies Research and Development (UK) Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Sun, 27 Feb 2022 17:56:31 +0000
Paul Cercueil <paul@crapouillou.net> wrote:

> Le dim., f?vr. 27 2022 at 18:51:38 +0100, Arnd Bergmann 
> <arnd@arndb.de> a ?crit :
> > On Sun, Feb 27, 2022 at 6:46 PM Paul Cercueil <paul@crapouillou.net> 
> > wrote:  
> >>  Le dim., f?vr. 27 2022 at 18:30:16 +0100, Arnd Bergmann
> >> 
> >>  There could be a DEFINE_DEV_PM_OPS(), but I don't think that's 
> >> really
> >>  needed - you can very well declare your struct dev_pm_ops without 
> >> using
> >>  one of these macros. Just make sure to use the SYSTEM_SLEEP_PM_OPS /
> >>  RUNTIME_PM_OPS macros for the callbacks and pm_ptr() for the 
> >> device.pm
> >>  pointer.  
> > 
> > Ah, of course, so it comes down to
> > s/SET_SYSTEM_SLEEP_PM_OPS/SYSTEM_SLEEP_PM_OPS/ while
> > removing all the #ifdef an __maybe_unused annotations. The pm_ptr()
> > in driver.pm makes this slightly more optimized AFAICT, but has no
> > effect on behavior, right?  
> 
> The use of SYSTEM_SLEEP_PM_OPS makes sure that the callbacks are 
> dropped if the dev_pm_ops is dead code, and the pm_ptr() must be used 
> for the compiler to know that the dev_pm_ops is dead code.
> 
> -Paul
> 
> 

Hi Paul,

We have one remaining case which is still ugly to do.
Where both SYSTEM_SLEEP_PM_OPS/RUNTIME_PM_OPS are set and
the dev_pm_ops structure is exported.

For that one we still need to expose #ifdef fun in the
drivers I think.

Any suggestions on a clean solution for that?

Currently I have this...

#ifdef CONFIG_PM
const struct dev_pm_ops bmc150_magn_pm_ops = {
	SYSTEM_SLEEP_PM_OPS(...)
	RUNTIME_PM_OPS(...)
};
EXPORT_SYMBOL_NS(bmc150_magn_pm_ops, IIO_BMC150_MAGN);
#else
static const __maybe_unused dev_pm_ops bmc150_magn_pm_ops = {
	SYSTEM_SLEEP_PM_OPS(...)
	RUNTIME_PM_OPS(...)
};
#endif
Not super clean but perhaps we do need
EXPORT_NS_DEV_PM_OPS
EXPORT_NS_GPL_DEV_PM_OPS
and potentially the non namespaced versions.

Thanks,

Jonathan