Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1313588pxp; Sun, 6 Mar 2022 11:25:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJxhNNaBfhw3fSeIYLjzgGFl/isfRL+Gl9tpp/etbErlkuKWx/V9qBP95lm4w+FiaH5nGiRL X-Received: by 2002:a63:d44d:0:b0:372:d975:3390 with SMTP id i13-20020a63d44d000000b00372d9753390mr6873944pgj.525.1646594741647; Sun, 06 Mar 2022 11:25:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646594741; cv=none; d=google.com; s=arc-20160816; b=Ao1DSRk63BVHyEXdg15QMlkaSOrz4HvXeH47AuQ2O/eDMicTm4I0wKiMg97OZTHjyt e3PrLr+X4cNUPOPvHiS2nEotoGlul3mj/0c+JTEXwR1/ZRIfqljnnf8MAwapldlQPkZP Xz5d1R8U7ZtRpDlzzygXBEjHzhjYSN7ncJyLFsUZEGuzw3NPDh82DDBtNnQtZ2Ejph3v qwWMOCNdCJ/4KLx5mur976wzYuENiNtliYPgjX6+BHZJpYt+XhPgk4vf+zbfuHMgQk4U bEV4tsf9bBYBZf+EWkph0pcsT4NH/WSLQUO+SifWTXV4Nrur+3Hgh42OYUwsKgOp39LT t5Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:content-disposition :content-transfer-encoding:mime-version:in-reply-to:references:cc :user-agent:date:subject:to:from; bh=+NltjGp9dZzqfw8R+2uiQv/vE6p5pYQxvCNFCHnA9Vw=; b=m1nE1P/AGJGNguKOGM2wA288X3IEY6NFiDo/G5QsC+U1ariKqiM/9PnWmXhRv4FRTk RaRbPaPo0DHlBqvIJnuYkR5X0OHza4SuSOsW3jUlyxLVCDlxGk34qpo8BQ5cWsLJITUi 98ENdHrNGRZdp3J77OdB/HQwVdcZxKqn0wD0B/RlSgp+NwsDBTa0DFvbm/s685FVC8n0 S46FWffUOuA3Fs5/xHfPtn0FS3pO7TWbizQzfTn2P1b1vWd48XXAN/5fpPCGs+U5tgbI p4Inab3CzX80BetT/3TxsU2b0xhx8gvpWFvCjZk5Hzc6q69zGijNpq1PSUDS3s0E+bDD THYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z1-20020a170902708100b0014f9099a17asi10387815plk.273.2022.03.06.11.25.25; Sun, 06 Mar 2022 11:25:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233235AbiCFKhd (ORCPT + 99 others); Sun, 6 Mar 2022 05:37:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233224AbiCFKhc (ORCPT ); Sun, 6 Mar 2022 05:37:32 -0500 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E4A5142486; Sun, 6 Mar 2022 02:36:39 -0800 (PST) Received: from [192.168.0.2] (chello089173232159.chello.sk [89.173.232.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 131427A01D4; Sun, 6 Mar 2022 11:36:39 +0100 (CET) From: Ondrej Zary To: Christoph Hellwig Subject: Re: [RFC PATCH] pata_parport: paride replacement Date: Sun, 6 Mar 2022 11:36:36 +0100 User-Agent: KMail/1.9.10 Cc: Damien Le Moal , Jens Axboe , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220305201411.501-1-linux@zary.sk> <20220306085825.GA22425@lst.de> In-Reply-To: <20220306085825.GA22425@lst.de> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="ansi_x3.4-1968" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <202203061136.36700.linux@zary.sk> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 06 March 2022 09:58:25 Christoph Hellwig wrote: > Hi Ondrej, > > I just took a quick glance and it seems like the actual protocol > modules still are basically almost exactly the same ones as the > paride ones. Is there a way to just keep the existing modules? > > The only big thing I noticed is the host template, but at least > for the transitional periode we could probably allocate that > dynamically in the core. I think would reduce the amount of code > churn nicely and make review much easier. Yes, only small changes in the protocol modules regarding (un)registration. Getting the original modules work with pata_parport (like in 1st preview) required some hacks that break paride (disabling EXPORT_SYMBOLs in paride). Maybe the protocol modules can be moved (git mv) from paride and then patched? A copy would be better but there's no "git cp". -- Ondrej Zary