Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965192AbXBTP4k (ORCPT ); Tue, 20 Feb 2007 10:56:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965189AbXBTP4k (ORCPT ); Tue, 20 Feb 2007 10:56:40 -0500 Received: from nommos.sslcatacombnetworking.com ([67.18.224.114]:7269 "EHLO nommos.sslcatacombnetworking.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965186AbXBTP4j (ORCPT ); Tue, 20 Feb 2007 10:56:39 -0500 In-Reply-To: <200702201629.40758.m.kozlowski@tuxland.pl> References: <200702201629.40758.m.kozlowski@tuxland.pl> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <014B4DC2-53BB-423E-B261-569299CAB2D9@kernel.crashing.org> Cc: "Robert P. J. Day" , Linux kernel mailing list , Andrew Morton , Paul Mackerras , dhowells@redhat.com Content-Transfer-Encoding: 7bit From: Kumar Gala Subject: Re: [PATCH] Add "is_power_of_2" checking to log2.h. Date: Tue, 20 Feb 2007 09:56:36 -0600 To: Mariusz Kozlowski X-Mailer: Apple Mail (2.752.2) X-PopBeforeSMTPSenders: kumar-chaos@kgala.com,kumar-statements@kgala.com,kumar@kgala.com X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - nommos.sslcatacombnetworking.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [47 12] X-AntiAbuse: Sender Address Domain - kernel.crashing.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 537 Lines: 19 On Feb 20, 2007, at 9:29 AM, Mariusz Kozlowski wrote: > Hello, > > Please fix the parentheses thing in both arch/powerpc/mm/ > pgtable_32.c and > arch/ppc/mm/pgtable.c. > >> +#define is_power_of_4(x) is_power_of_2(x) && (ffs(x) & 1)) These should be fixed and pushed upstream by now. - k - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/