Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: 2hZoiAONZczbEOw2y3y4hYDlFoPZaKLacM6Wy9U+DTFpwYbUJf3wyWudHKOZTJHlr2Pm8xPrbp
 1aZpRPIrmpxpJn6ScX9NtjmnhG7BQIWc36LHoWs+rFMpNWQkficIRdskb0MvAWIkpfBHf9JmBB
 nK5MfNkFcgiJcxODC4EJHZ5eWKFgzkvxr4qW9ghKqarAzUhf7BuAUJy5huBuPtNdxiJSfetrm+
 a8qI/XQPvULF6qwtRRBoJyv7IT5HGeY9GxW1rVsw34WBLzRlSXqUYlR4FNrAXavTuCofOsNjR/
 67pakRL5seqXxR3t72sVoMdW
IronPort-SDR: 8vCxws0eyun8TpegdXqv+yXKn7pBmXpDQNAaRy300ZZMJ7B/wK5XdWlqD+EuB1HC3XdczFF8SU
 HoAm2EZcGet46Z3BPBki0tUUMSgbm+X0tPexSBEhXo3lBVd/PheTbt6g7aOwN4EzwUo4bREJzn
 lMvbZzXdn+5XKif7y9vJpVyF+ie3PiuFZ74lxXpVFMLrnDQLwEXS0SdQLZpekTfKn++HlLe7DU
 chekHZM2+F5/QxNdL8trW7fICX0aqc5tFB/1jrDK57WsZe71bnAnpcC/jzEvV5uNZXU7qnWN1v
 StM=
WDCIronportException: Internal
Message-ID: <ca924db7-f137-ce48-a83b-e0079995272d@opensource.wdc.com>
Date:   Mon, 7 Mar 2022 09:55:46 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 0/4] scsi: libsas and users: Factor out internal abort
 code
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, jinpu.wang@cloud.ionos.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ajish.Koshy@microchip.com, linuxarm@huawei.com,
        Viswas.G@microchip.com, hch@lst.de, liuqi115@huawei.com,
        chenxiang66@hisilicon.com
References: <1646309930-138960-1-git-send-email-john.garry@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1646309930-138960-1-git-send-email-john.garry@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/3/22 21:18, John Garry wrote:
> This is a follow-on from the series to factor out the TMF code shared
> between libsas LLDDs.
> 
> The hisi_sas and pm8001 have an internal abort feature to abort pending
> commands in the host controller, prior to being sent to the target. The
> driver support implementation is naturally quite similar, so factor it
> out.
> 
> Again, testing and review would be appreciated.

I ran my usual set of tests with fio and also libzbc tests to exercise
the failure/abort path. No problems detected. All good to me.
Feel free to add:

Tested-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

To your V2 with the cosmetic fixes.

> 
> This is based on mkp-scsi 5.18 staging queue @ commit f2ddbbea7780
> 
> John Garry (4):
>   scsi: libsas: Add sas_execute_internal_abort_single()
>   scsi: libsas: Add sas_execute_internal_abort_dev()
>   scsi: pm8001: Use libsas internal abort support
>   scsi: hisi_sas: Use libsas internal abort support
> 
>  drivers/scsi/hisi_sas/hisi_sas.h       |   8 +-
>  drivers/scsi/hisi_sas/hisi_sas_main.c  | 453 +++++++++----------------
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c |  11 +-
>  drivers/scsi/hisi_sas/hisi_sas_v3_hw.c |  18 +-
>  drivers/scsi/libsas/sas_scsi_host.c    |  89 +++++
>  drivers/scsi/pm8001/pm8001_hwi.c       |  27 +-
>  drivers/scsi/pm8001/pm8001_hwi.h       |   5 -
>  drivers/scsi/pm8001/pm8001_sas.c       | 186 ++++------
>  drivers/scsi/pm8001/pm8001_sas.h       |   6 +-
>  drivers/scsi/pm8001/pm80xx_hwi.h       |   5 -
>  include/scsi/libsas.h                  |  24 ++
>  include/scsi/sas.h                     |   2 +
>  12 files changed, 368 insertions(+), 466 deletions(-)
> 


-- 
Damien Le Moal
Western Digital Research