Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-955432eb-74c6-48f6-984e-d88a61854727-1646567165101@3c-app-gmx-bs64>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Frank Wunderlich <linux@fw-web.de>, devicetree@vger.kernel.org,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Rob Herring <robh+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Heiko Stuebner <heiko@sntech.de>,
        Peter Geis <pgwipeout@gmail.com>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        Hans de Goede <hdegoede@redhat.com>,
        Jens Axboe <axboe@kernel.dk>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
Subject: Aw: Re:  Re: Re: [PATCH v5 1/5] dt-bindings: ata: ahci-platform:
 Convert DT bindings to yaml
Content-Type: text/plain; charset=UTF-8
Date:   Sun, 6 Mar 2022 12:46:05 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <18f4dc19-b8a4-015e-48c8-923326cc7932@canonical.com>
References: <20220305112607.257734-1-linux@fw-web.de>
 <20220305112607.257734-2-linux@fw-web.de>
 <a2839b00-d195-131f-b2a7-d2f030a5bd95@canonical.com>
 <trinity-9ef9e0d3-e70c-45d9-bdd8-e43d1c89a8c9-1646560070497@3c-app-gmx-bs46>
 <b8553651-3cd0-845c-efbf-d2341d5506b3@canonical.com>
 <trinity-d42352e1-d778-40dd-9464-90a145653f74-1646563315484@3c-app-gmx-bs46>
 <18f4dc19-b8a4-015e-48c8-923326cc7932@canonical.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


> Gesendet: Sonntag, 06=2E M=C3=A4rz 2022 um 12:15 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof=2Ekozlowski@canonical=2Ecom>
> An: "Frank Wunderlich" <frank-w@public-files=2Ede>
> Cc: "Frank Wunderlich" <linux@fw-web=2Ede>, devicetree@vger=2Ekernel=2Eo=
rg, "Damien Le Moal" <damien=2Elemoal@opensource=2Ewdc=2Ecom>, "Rob Herring=
" <robh+dt@kernel=2Eorg>, "Andrew Lunn" <andrew@lunn=2Ech>, "Gregory Clemen=
t" <gregory=2Eclement@bootlin=2Ecom>, "Sebastian Hesselbarth" <sebastian=2E=
hesselbarth@gmail=2Ecom>, "Russell King" <linux@armlinux=2Eorg=2Euk>, "Heik=
o Stuebner" <heiko@sntech=2Ede>, "Peter Geis" <pgwipeout@gmail=2Ecom>, "Mic=
hael Riesch" <michael=2Eriesch@wolfvision=2Enet>, "Hans de Goede" <hdegoede=
@redhat=2Ecom>, "Jens Axboe" <axboe@kernel=2Edk>, linux-ide@vger=2Ekernel=
=2Eorg, linux-kernel@vger=2Ekernel=2Eorg, linux-arm-kernel@lists=2Einfradea=
d=2Eorg, linux-rockchip@lists=2Einfradead=2Eorg
> Betreff: Re: Aw: Re: Re: [PATCH v5 1/5] dt-bindings: ata: ahci-platform:=
 Convert DT bindings to yaml
>
> On 06/03/2022 11:41, Frank Wunderlich wrote:
> >> Gesendet: Sonntag, 06=2E M=C3=A4rz 2022 um 11:27 Uhr
> >> Von: "Krzysztof Kozlowski" <krzysztof=2Ekozlowski@canonical=2Ecom>
> >>>     add compatibles used together with generic-ahci
> >>>       - marvell,berlin2-ahci
> >>
> >> This is fine, just mention it in commit msg=2E
> >>
> >>>       - qcom,apq8064-ahci
> >>>       - qcom,ipq806x-ahci
> >>
> >> These you need to consult with qcom-sata=2Etxt=2E This could be a fol=
lowing
> >> commit which will integrate qcom-sata=2Etxt and remove it=2E
> >=20
> > this depends on Robs opinion
>=20
> Then maybe precise the question for Rob=2E=2E=2E

do i need to fix the errors for qcom-compatibles/reg-count/clock-count (re=
ported by your bot) *now*?

or is binding well enough with adding berlin-compatible and fixing the ind=
entation error in example?

for the marvell anyof issue and the spear13xx i have a patch in my tree wh=
ich i include in v6

> >=20
> >> Either you have
> >> binding document for all devices or you create a common part, like fo=
r UFS:
> >> https://lore=2Ekernel=2Eorg/linux-devicetree/20220222145854=2E358646-=
1-krzysztof=2Ekozlowski@canonical=2Ecom/
> >> https://github=2Ecom/krzk/linux/commits/n/dt-bindings-ufs-v2
> >>
> >> The choice depends more or less on complexity of bindings, IOW, how b=
ig
> >> and complicated bindings would be if you combine everything to one YA=
ML=2E
> >>
> >> In the case of UFS, the devices differ - by clocks, resets, phys and
> >> sometimes supplies=2E Therefore it easier to have one common shared p=
art
> >> and several device bindings=2E
> >>
> >> AHCI looks more consistent - except that Qualcomm - so maybe better t=
o
> >> have one document=2E
> >>
> >>>     increase reg-count to 2 (used in omap5-l4=2Edtsi)
> >>>     increase clock-count to 5 (used in qcom-apq8064=2Edtsi)
> >>
> >> This would need allOf+if=2E
> >=20
> > if i get ok from rob i add only the berlin-compatible and skip the qco=
m+reg/clock-change in the first applied version=2E Adding the allOf/if (and=
 making it right) will only delay the sata-binding/dts-change=2E
>=20
> I don't get what is the problem with delaying this patch for the time
> needed to make the bindings correct? Especially that alternative is to
> add bindings document which soon will need to be modified, e=2Eg=2E spli=
t
> into common part=2E Is there a particular hurry with these bindings
> conversion?

i see it as requirement for last part

"arm64: dts: rockchip: Add sata nodes to rk356x"

if this can applied without the bindings conversion there is nothing to hu=
rry :)

regards Frank