Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Colin Foster <colin.foster@in-advantage.com>
To:     linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
        linux-phy@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Marc Zyngier <maz@kernel.org>,
        Hector Martin <marcan@marcan.st>,
        Angela Czubak <acz@semihalf.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Vinod Koul <vkoul@kernel.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Russell King <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>, UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Lee Jones <lee.jones@linaro.org>, katie.morris@in-advantage.com
Subject: [RFC v7 net-next 03/13] net: mdio: mscc-miim: add local dev variable to cleanup probe function
Date:   Sun,  6 Mar 2022 18:11:58 -0800
Message-Id: <20220307021208.2406741-4-colin.foster@in-advantage.com>
In-Reply-To: <20220307021208.2406741-1-colin.foster@in-advantage.com>
References: <20220307021208.2406741-1-colin.foster@in-advantage.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?68KpFdEOqHu6O3pEFNj+6pyzW/eHykfVOyhwdQSk/lVgtPOQWj+x5+5nufaA?=
 =?us-ascii?Q?jlF+3AgBaSEz/JiwW5LN+XduFzXh8JKZaajwiaQNQeUep7wRxul0v70nMQ8r?=
 =?us-ascii?Q?/sJmU0w0nQH8bJ+/fmr0l19mX3aegBU4tIL5mX8AO7kbV9srCYH0uRONQQUU?=
 =?us-ascii?Q?2OQ1EIHv3FhgnUdnow1MmRtbqjYC0h+wqm495AGYXkh37MdeRBMHV30Ke1uK?=
 =?us-ascii?Q?Eb9Cka6vz9T06M7o9S1MsQeok6gL0WIIPI1f8VjkKeF818cEkbatVn1z/boB?=
 =?us-ascii?Q?toND0WiNWelwGJzo38Wm6ejdruPEbVnQQYhXoWVtrshQSbIdmD31j2YaCqOo?=
 =?us-ascii?Q?fJJEE0b+JCWo8F9jY/Sci2okeVj8jfNRmGY+eJTjm6WALlZEBdAeEihcCdIl?=
 =?us-ascii?Q?hv0H6ZJe2r22vqTUdCsn8SarfTEFi3aS2ADrxnB82GshdcefEsui3lLaR8xa?=
 =?us-ascii?Q?rNuOuISKtkiOxic4e8+zHzfdslo9EttGPIciQMke/P29+Pkzolk9i1n385bo?=
 =?us-ascii?Q?1lHaUjDQ6OK4YK3Tl9kkJaWuWZbw9Kc9PjxuzBU4cHx/YnFG3At6NYLYpsUc?=
 =?us-ascii?Q?Plh6toYl0/03lFI3f+ZCH6v2xLicq2ilxehL4mMVbFG+q+1e5naDavdJdVoL?=
 =?us-ascii?Q?5Zn2JjnpNZnSLUdu/eo/3Qd60ovPg4iasIE/NkV+NIqQb8vBVKqv39guKM+8?=
 =?us-ascii?Q?KDgbvSSCyzA89j54clVrx5w21iVJlQCXvX6m+q6A7T+Lg71hkfV2R6toBKvf?=
 =?us-ascii?Q?0ZxeibAx7m396hfI4eYQVxYkdGlkhu7FvXeFVwZZqWk5uonI3yEpMPQD03la?=
 =?us-ascii?Q?+60e+Jf/fZFmhL3uSjSP5vHXhYmOw7gw/KF3YAdCSM+kNB87cCqk0Zjnk0XW?=
 =?us-ascii?Q?Aq4IyJBCWaB3uXOpL8zBBNsmtfWWAD0RLAlUypd+f081qDXsOaP5dbmRcux3?=
 =?us-ascii?Q?vjWW6N/X45JaHMyF5D3s4vZh7NDH4An6/a78Ez08FuFKV4KPETCCTTciEear?=
 =?us-ascii?Q?dUCBYra425vUpDtkd5NILRNh0BqEecposDTa/bPwYziE068m9gtmhj/SHuPy?=
 =?us-ascii?Q?GxtHkvUL6MbLMl4kvJvQYYOkfQp3yuAADmaQpIGgF/uCvl9YPZ1aZu0vJlil?=
 =?us-ascii?Q?eE4R21aYBpA+FgyQeSH0aSEM8u8sz6zIFOzu+xkJCENABEQ5tflfAQ+6vDyc?=
 =?us-ascii?Q?rOPT+uCXJyCmstx7md2hfg0raS33WRJAJmssk3/04ubc7A4NMBQYw65KBs2y?=
 =?us-ascii?Q?iyyYQNYh/yOWb3kfAlMewySe3BDvy1GyL41QMXf1ULwG57CWXo/fUMoyZ4eG?=
 =?us-ascii?Q?2hlDz8Thm4Xm+am+DNXiqmLoEgQTtumYxS1MPRWYK7+zmxMCXIRg1DBSPfhk?=
 =?us-ascii?Q?w2JKluoBDnrz4s8eealllw88Oeol746yqSk9u2xrPxeYRx9YoE/yJrPxJWS1?=
 =?us-ascii?Q?McvF2d5LR6+bG30pw0M1HsWhK83P/TcvkTvs+MHc4UG5mKbMTb5NBHnQJ8WF?=
 =?us-ascii?Q?sXbjhz+gLD3ynYm1p0pSecwb4LemVuYp/y+11MbgTHFE7h/628KFepFRC82y?=
 =?us-ascii?Q?XtiaWFk3lYFOZdQDX98jkeNM2ceSiP3YTGIGfhfOCGBREmlZ7ZDscya3EvsM?=
 =?us-ascii?Q?ROtutKlDUaRgVrIIXLXY0CMUOCIjWCUViVl29oy5u+ntYfTMQvM2pQTUGSQY?=
 =?us-ascii?Q?5dnHQQ=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 765ae18e-23db-4662-41f4-08d9ffdfeca4
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 02:12:26.5269
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: io9JRYeymQD3I9vkON7qql8QtV58FJGCAfN6qOsDz2IAT/ganyRwEI8mrcz8rcboPWXFkWRrQa3bALe/3cahOaCb7+JjY7WwqoCgXtLJbO0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4553
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Create a local device *dev in order to not dereference the platform_device
several times throughout the probe function.

Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/mdio/mdio-mscc-miim.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c
index 7d2abaf2b2c9..6b14f3cf3891 100644
--- a/drivers/net/mdio/mdio-mscc-miim.c
+++ b/drivers/net/mdio/mdio-mscc-miim.c
@@ -220,6 +220,7 @@ EXPORT_SYMBOL(mscc_miim_setup);
 static int mscc_miim_probe(struct platform_device *pdev)
 {
 	struct regmap *mii_regmap, *phy_regmap = NULL;
+	struct device *dev = &pdev->dev;
 	void __iomem *regs, *phy_regs;
 	struct mscc_miim_dev *miim;
 	struct resource *res;
@@ -228,38 +229,37 @@ static int mscc_miim_probe(struct platform_device *pdev)
 
 	regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 	if (IS_ERR(regs)) {
-		dev_err(&pdev->dev, "Unable to map MIIM registers\n");
+		dev_err(dev, "Unable to map MIIM registers\n");
 		return PTR_ERR(regs);
 	}
 
-	mii_regmap = devm_regmap_init_mmio(&pdev->dev, regs,
-					   &mscc_miim_regmap_config);
+	mii_regmap = devm_regmap_init_mmio(dev, regs, &mscc_miim_regmap_config);
 
 	if (IS_ERR(mii_regmap)) {
-		dev_err(&pdev->dev, "Unable to create MIIM regmap\n");
+		dev_err(dev, "Unable to create MIIM regmap\n");
 		return PTR_ERR(mii_regmap);
 	}
 
 	/* This resource is optional */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
 	if (res) {
-		phy_regs = devm_ioremap_resource(&pdev->dev, res);
+		phy_regs = devm_ioremap_resource(dev, res);
 		if (IS_ERR(phy_regs)) {
-			dev_err(&pdev->dev, "Unable to map internal phy registers\n");
+			dev_err(dev, "Unable to map internal phy registers\n");
 			return PTR_ERR(phy_regs);
 		}
 
-		phy_regmap = devm_regmap_init_mmio(&pdev->dev, phy_regs,
+		phy_regmap = devm_regmap_init_mmio(dev, phy_regs,
 						   &mscc_miim_regmap_config);
 		if (IS_ERR(phy_regmap)) {
-			dev_err(&pdev->dev, "Unable to create phy register regmap\n");
+			dev_err(dev, "Unable to create phy register regmap\n");
 			return PTR_ERR(phy_regmap);
 		}
 	}
 
-	ret = mscc_miim_setup(&pdev->dev, &bus, "mscc_miim", mii_regmap, 0);
+	ret = mscc_miim_setup(dev, &bus, "mscc_miim", mii_regmap, 0);
 	if (ret < 0) {
-		dev_err(&pdev->dev, "Unable to setup the MDIO bus\n");
+		dev_err(dev, "Unable to setup the MDIO bus\n");
 		return ret;
 	}
 
@@ -267,9 +267,9 @@ static int mscc_miim_probe(struct platform_device *pdev)
 	miim->phy_regs = phy_regmap;
 	miim->phy_reset_offset = 0;
 
-	ret = of_mdiobus_register(bus, pdev->dev.of_node);
+	ret = of_mdiobus_register(bus, dev->of_node);
 	if (ret < 0) {
-		dev_err(&pdev->dev, "Cannot register MDIO bus (%d)\n", ret);
+		dev_err(dev, "Cannot register MDIO bus (%d)\n", ret);
 		return ret;
 	}
 
-- 
2.25.1