Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-d42352e1-d778-40dd-9464-90a145653f74-1646563315484@3c-app-gmx-bs46>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Frank Wunderlich <linux@fw-web.de>, devicetree@vger.kernel.org,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Rob Herring <robh+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Heiko Stuebner <heiko@sntech.de>,
        Peter Geis <pgwipeout@gmail.com>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        Hans de Goede <hdegoede@redhat.com>,
        Jens Axboe <axboe@kernel.dk>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
Subject: Aw: Re:  Re: [PATCH v5 1/5] dt-bindings: ata: ahci-platform:
 Convert DT bindings to yaml
Content-Type: text/plain; charset=UTF-8
Date:   Sun, 6 Mar 2022 11:41:55 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <b8553651-3cd0-845c-efbf-d2341d5506b3@canonical.com>
References: <20220305112607.257734-1-linux@fw-web.de>
 <20220305112607.257734-2-linux@fw-web.de>
 <a2839b00-d195-131f-b2a7-d2f030a5bd95@canonical.com>
 <trinity-9ef9e0d3-e70c-45d9-bdd8-e43d1c89a8c9-1646560070497@3c-app-gmx-bs46>
 <b8553651-3cd0-845c-efbf-d2341d5506b3@canonical.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

> Gesendet: Sonntag, 06=2E M=C3=A4rz 2022 um 11:27 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof=2Ekozlowski@canonical=2Ecom>
> >     add compatibles used together with generic-ahci
> >       - marvell,berlin2-ahci
>=20
> This is fine, just mention it in commit msg=2E
>=20
> >       - qcom,apq8064-ahci
> >       - qcom,ipq806x-ahci
>=20
> These you need to consult with qcom-sata=2Etxt=2E This could be a follow=
ing
> commit which will integrate qcom-sata=2Etxt and remove it=2E

this depends on Robs opinion

> Either you have
> binding document for all devices or you create a common part, like for U=
FS:
> https://lore=2Ekernel=2Eorg/linux-devicetree/20220222145854=2E358646-1-k=
rzysztof=2Ekozlowski@canonical=2Ecom/
> https://github=2Ecom/krzk/linux/commits/n/dt-bindings-ufs-v2
>=20
> The choice depends more or less on complexity of bindings, IOW, how big
> and complicated bindings would be if you combine everything to one YAML=
=2E
>=20
> In the case of UFS, the devices differ - by clocks, resets, phys and
> sometimes supplies=2E Therefore it easier to have one common shared part
> and several device bindings=2E
>=20
> AHCI looks more consistent - except that Qualcomm - so maybe better to
> have one document=2E
>=20
> >     increase reg-count to 2 (used in omap5-l4=2Edtsi)
> >     increase clock-count to 5 (used in qcom-apq8064=2Edtsi)
>=20
> This would need allOf+if=2E

if i get ok from rob i add only the berlin-compatible and skip the qcom+re=
g/clock-change in the first applied version=2E Adding the allOf/if (and mak=
ing it right) will only delay the sata-binding/dts-change=2E

> >=20
> > can i still add you reviewed-by to v6?
>=20
> Keeping reviewed-by would be fine when adding compatibles and bumping
> maxItems, but in your case you need to rework these bindings=2E Either b=
y
> growing document with several "if:" or by splitting them, so it will be
> significant change=2E Skip my review then=2E
>=20
> >=20
> > [1] https://github=2Ecom/frank-w/BPI-R2-4=2E14/commits/5=2E17-next-202=
20225

regards Frank