Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1646374812-2988-1-git-send-email-hammerh0314@gmail.com>
 <1646374812-2988-2-git-send-email-hammerh0314@gmail.com> <9113e319-58a2-fd90-6887-fb32eb21fd18@canonical.com>
In-Reply-To: <9113e319-58a2-fd90-6887-fb32eb21fd18@canonical.com>
From:   hammer hsieh <hammerh0314@gmail.com>
Date:   Mon, 7 Mar 2022 12:18:56 +0800
Message-ID: <CAOX-t55sXVg8Fj_G_xzxWTStxZXOwKo46=_R0LkfHnMS051KaQ@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] dt-bindings:pwm:Add bindings doc for Sunplus SoC
 PWM Driver
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     thierry.reding@gmail.com,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, lee.jones@linaro.org,
        robh+dt@kernel.org, linux-pwm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        wells.lu@sunplus.com, "hammer.hsieh" <hammer.hsieh@sunplus.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> =E6=96=BC 2022=E5=
=B9=B43=E6=9C=884=E6=97=A5 =E9=80=B1=E4=BA=94
=E4=B8=8B=E5=8D=8811:01=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On 04/03/2022 07:20, Hammer Hsieh wrote:
> > Add bindings doc for Sunplus SoC PWM Driver
>
> You miss spaces in the subject.
>

ok, will modify it.

> >
> > Signed-off-by: Hammer Hsieh <hammerh0314@gmail.com>
> > ---
> > Changes in v2:
> >  - Addressed all comments from Rob Herring.
> >    modify author's mail match Signed-off-by.
> >  - rebase kernel to 5.17 rc5
> >
> >  .../devicetree/bindings/pwm/pwm-sunplus.yaml       | 40 ++++++++++++++=
++++++++
> >  MAINTAINERS                                        |  5 +++
> >  2 files changed, 45 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sunplus.y=
aml
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml b/D=
ocumentation/devicetree/bindings/pwm/pwm-sunplus.yaml
> > new file mode 100644
> > index 0000000..19fe5d5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml
> > @@ -0,0 +1,40 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (C) Sunplus Co., Ltd. 2021
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pwm/pwm-sunplus.yaml#
>
> Is it going to be one binding for all Sunplus SoCs? Existing and future?
>

yes, that was my first plan.
but not all sunplus SoCs use the same IP-based,
so I will change file name form 'pwm-sunplus.yaml' to
'sunplus,sp7021-pwm.yaml' in  next patch.

> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sunplus SoC PWM Controller
> > +
> > +maintainers:
> > +  - Hammer Hsieh <hammerh0314@gmail.com>
> > +
>
> allOf with pwm.yaml
> Then unevaluatedProperties instead of additionalProperties.
>

ok , will add it.

>
> > +properties:
> > +  '#pwm-cells':
> > +    const: 2
> > +
> > +  compatible:
>
> Commpatible goes first. Rest of properties you could order
> alphabetically. Similar approach in required.
>
>

ok, will modify it.

> > +    items:
> > +      - const: sunplus,sp7021-pwm
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +required:
>
> compatible
>
> > +  - reg
> > +  - clocks
>
>
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    pwm: pwm@9c007a00 {
> > +      #pwm-cells =3D <2>;
> > +      compatible =3D "sunplus,sp7021-pwm";
>
> compatible goes first, then reg.
>

ok, will modify it.

>
> Best regards,
> Krzysztof