Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Mar 2022 13:58:32 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        bliang@analogixsemi.com, qwen@analogixsemi.com,
        jli@analogixsemi.com, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v6 2/2] usb: typec: anx7411: Add Analogix PD ANX7411
 support
Message-ID: <20220307055832.GB4174271@anxtwsw-Precision-3640-Tower>
References: <20220223102353.3833578-1-xji@analogixsemi.com>
 <20220223102353.3833578-2-xji@analogixsemi.com>
 <Yh9dBlrWm3OicQWa@kuha.fi.intel.com>
 <20220303024757.GA4159259@anxtwsw-Precision-3640-Tower>
 <YiC+/ccRvR/+mAkT@kuha.fi.intel.com>
 <20220304022936.GA4164495@anxtwsw-Precision-3640-Tower>
 <YiIF+PpuIeJMY+/T@kuha.fi.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YiIF+PpuIeJMY+/T@kuha.fi.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EglJmQjZTyJDVVVnDrNFBf8WgwLNFQyx0vlqV64gJbgwwWaS/AdaVNdbVv7V?=
 =?us-ascii?Q?joYLLd1tXPZo6Q3pknnNTmWYo9nE/TGJsSxLrkvF0yEbwE5kIpl6CyIdJbpv?=
 =?us-ascii?Q?4LwS31GUFJXGYYzYFdhMII9mlgLxr2aUauVrLmfdva+rsns/68lfVVbkpiMN?=
 =?us-ascii?Q?mcNwMZM0plHRs72SKiylZIMFpwp4/qDbI3pp/DXLhNlmS6Jd7EAE1L2lVs/G?=
 =?us-ascii?Q?HQkEL237RXaknAaDAeCqBnmcvxHThVs2MfQsV86rr21hjaCGCiPP8l9TZgqy?=
 =?us-ascii?Q?CetsGtXxR8AOWDIebNPv1wVg9Ut2Zy+HN+5iY3LlhUhN2WK/9WcZ9RwiUdxR?=
 =?us-ascii?Q?1mAzhB3rzjU3JP2smloRzDQJjiLsfsj6DtWx4ad8weg5qmwLnaqBBzTloaH2?=
 =?us-ascii?Q?zb2LsK3+Tg0OQdpH7r/Cz8ownqAew2DmVGAZufniIhxkel+6PXUlHPH6beds?=
 =?us-ascii?Q?kLob6z+F3WWT+jfIq2jomZ+HnKp0jlZ80HiEB9rO2y7AjEcwBsdEOie0z+FH?=
 =?us-ascii?Q?Q4OrTtEQOu04d6mEgRKRbh3tfrKsPHPg0kAmk2FXSABcfWNOjPcDcOWI0/U2?=
 =?us-ascii?Q?H+zAiR6MRrOoNvvhd5BLtOQBgYxA2Mf0S5cLCgSXxt26HrfvQzkspWzzJ7Tr?=
 =?us-ascii?Q?4sFjAZC02SmjgyhkS6boqAewY99H7L0AoeTzc5o/WH9bsb/UjkCjaJ6tGgcG?=
 =?us-ascii?Q?OO8t65HngvWp9WneiTk8I7aEQlani90uHISRx15xN8Mre3JyOXd8Im8f6e+q?=
 =?us-ascii?Q?dP1+kfwTiYCWgCZrUj1NVPe9ABJu/92ixErOJpqC4+q+wSWlPhpraxN0grRg?=
 =?us-ascii?Q?jRYT5Lhkpeom+bQBOplZBZPyz7gXCw3/4EZ8KIC21V6cUk6K2P+sS0mrzw9Z?=
 =?us-ascii?Q?ddcfO3u9XehI/VpCyuqoytjt6buxFYUB+n8goTCaVHC/k0UONIBmJlq5ppbk?=
 =?us-ascii?Q?Y2M7BWz1JfWQ/IgQmm203eB7XVE7SRjUrFJgzKVDsr4H/l6uJpgYjZN/exMg?=
 =?us-ascii?Q?OipoOS6g2IHme1z1Vf9Nn3RqN9Ldv9oYTUDOHDjMAi3YWNcMDKy9+veW1bqz?=
 =?us-ascii?Q?20BZUnEd8jxfr2wFBloeXnhxQ3NybK10iI3MJFWvULjKcOlRF78qCG2atNaV?=
 =?us-ascii?Q?uJ9RB9XvihpTUzk6kcw7nuRRbvXVrvrRmP6dqowogAUz0z4QYSOrA6G1W4X3?=
 =?us-ascii?Q?DSTiugEfyDNlByFgIhQCPb9pd6uutxGu39/xppJnT5WRFwZVp0q31WI1B2Q6?=
 =?us-ascii?Q?PLMgn1elMr1E3rPOZcN+6zoKQ2hr8h+4/IPzF0y8TSBOmtYXAwL6yU6cUF07?=
 =?us-ascii?Q?rumhlZwY9EbEPgazPheSoKx11AufgQUr+NkT26PMr7yxsr2514MiRJKJ/kvo?=
 =?us-ascii?Q?xS5ilgezMkL5ojaTcYl0f/L4U750lWaca6VRRI9Knu5OGu6oujVyYNCQgg/i?=
 =?us-ascii?Q?zRuLoi+yT7/CNL1vjdxCsvNlu9B91uyXxHadxrdlqt068orjxMvejAXkHkrW?=
 =?us-ascii?Q?rZYeSfOza/zon5D5+sU/JLXxf4t3YSPnSc+UgpW+5E4SJmb7hDm2jk95tH4j?=
 =?us-ascii?Q?/7NVuTqcuwepcyEidjEqJOoiKGwrDpOcqnewogkx72YP6h5OuKdh77Rm/3oM?=
 =?us-ascii?Q?qNHLyTBaEDSQzb/r4BhCEfU=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 809b8882-4e46-47a7-62f2-08d9ffff8935
X-MS-Exchange-CrossTenant-AuthSource: CH2PR04MB6741.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 05:58:43.7983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5dO6k2jqrwX/r12NbfJfKo3YB7gA/lDjev1nwLvUoVkTnP3DsHLgovBg7Zv0H7Opkypm8yH24L5uSQdJYJLW3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB3966
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 04, 2022 at 02:28:40PM +0200, Heikki Krogerus wrote:
> On Fri, Mar 04, 2022 at 10:29:36AM +0800, Xin Ji wrote:
> > On Thu, Mar 03, 2022 at 03:13:33PM +0200, Heikki Krogerus wrote:
> > > On Thu, Mar 03, 2022 at 10:47:57AM +0800, Xin Ji wrote:
> > > > On Wed, Mar 02, 2022 at 02:03:18PM +0200, Heikki Krogerus wrote:
> > > > > Hi,
> > > > > 
> > > > > This does not apply on top of Greg's latest usb-next branch. You need
> > > > > to rebase this. There are also a few more nitpicks below.
> > > > 
> > > > Hi, I didn't found tcpci.h in include/linux/usb/
> > > 
> > > I'm asking you to create the file.
> > > 
> > > So create a separate patch where you move the register definitions and
> > > command definitions from drivers/usb/typec/tcpm/tcpci.h to
> > > include/linux/usb/tcpci.h
> > Hi heikki, I'm confused, do you mean move total tcpci.h to
> > include/linux/usb/ directory or just move our driver patch used register
> > definitions and command to "include/linux/usb/tcpci.h"?
> > 
> > And I think the other way is, our driver patch just include
> > "tcpm/tcpci.h" is better(no need to create new file). What do you think?
> 
> I would prefer that you just introduce the global header for them.
Hi heikki, I'll try to move the tcpci.h as global header.

Thanks,
Xin
> 
> thanks,
> 
> -- 
> heikki