Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1697548pxp; Sun, 6 Mar 2022 23:48:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJxf2KEYj/4HCvAeBo/tjHmExRoNWbKjq5TapwA1oOQllQLzFbrCt4gFGhUJfvCCJJejltXb X-Received: by 2002:aa7:805a:0:b0:4f6:dc68:5d41 with SMTP id y26-20020aa7805a000000b004f6dc685d41mr9194998pfm.69.1646639303302; Sun, 06 Mar 2022 23:48:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646639303; cv=none; d=google.com; s=arc-20160816; b=XLyhHusRYTPdN6VoMvPyxIKLCnSQ2bNMQBZr/xelmpmK2/p9jIQ3PWv++NuMHR1Ffk Owhsfj4eL5R+aC1GTz1sr14v4Cjx0BgY0sGzGXHUM88QU/Y9D6FrLLj6quIMbN1rxyug SRJxdadorE6063RLijCTswfB8ucbA/dHFLqHyH4W+5qO3UeEhu9WFOwFRtliqqEhzTiE lkrsu4TrnXaIT+LZ/9fGXZQms+o/nNiOuJ8wTe/3+gmZk0m8gM9e8x+hs6GcrZLoHjlE uaGeiB1QQn+qDIliBDtuZemp2X850FxMcZ6gMbd05gxWAKYMlmS649nOhbaPdDxEbuk3 AVkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=FRHEY3GRFXoG1UU1e98wLEZW7/ZnhLl219P9N6Q7Xfk=; b=KBeUm7csF43QFHyXwBi7sv4SaHekadgx4r4QQ5/9kao8ungzxnNC4wCO3ydI098poB rp7qMfcAWxpg5ixrztxa3VKcVqcqo8AmqBWLT96kaQ8Frjkt/Zkx15ToH8T5rsH6xdT3 gOc83y77lzNyqod3ummO3eZy/0bVUgf3fbM7GYKmESnVQh15aYVVKi20JAEIqoSYvzsw bif8/lCwNaXCFNbLusdRUf7NZcVEqaeydDLpih+BPXztq2gUHptHZCptAjgCzyYc9Lqw 15wdiVu381rgDxaIjpUrA+hgxw8CZujlZKZ6AavCbPjzRZ/W0ggVj7Lyp4ED+cBAId0A urCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Iub3o8HZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k21-20020a170902f29500b00151a41d551fsi10399176plc.458.2022.03.06.23.48.08; Sun, 06 Mar 2022 23:48:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Iub3o8HZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235305AbiCGFk3 (ORCPT + 99 others); Mon, 7 Mar 2022 00:40:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231848AbiCGFk2 (ORCPT ); Mon, 7 Mar 2022 00:40:28 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15D61DF31 for ; Sun, 6 Mar 2022 21:39:34 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id bx5so12293822pjb.3 for ; Sun, 06 Mar 2022 21:39:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FRHEY3GRFXoG1UU1e98wLEZW7/ZnhLl219P9N6Q7Xfk=; b=Iub3o8HZFGzZncj+cUUaGyruUSLVT6eZ4Fa3w6CU8/WDywXHGWPXYEKKxrxAGmClId soE+Md0SYuQPvqvIKbIyzzlAamFqsKdG2k7nFO8/8Q6GKJcobhdfA+UwobywjQmyFspW QU07Tyf3zEIkL4dkAGfZ909lxs5YX5vMb6ixopBxxnCNdFRAljg82kx3Uk17AnQjpOaO oI/h724Rf/wJ3RB/JT9B95ib3pjf69k0OLtVRrFxGlxz08nulXyR1FLZQ1DavnZorjws ypOn2O4yPslr3ohfx70+qzqwR9KNnf3uw27T+QQstpYxDqRHjJDxteMNCpSKxyDyxdyW 7DDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FRHEY3GRFXoG1UU1e98wLEZW7/ZnhLl219P9N6Q7Xfk=; b=3bd5Rp+jNpcIOUGXvu3cLw1Qd4cKD/sBQwBILJH+20MYbNAmugCKUY8aVyODPp9T8r JsIoc16WUm+XXA5254Mtdp0AONlQMhkDkTQXl7aZl+mawkUT4KQqoPZHs1wayd1FCYty ZSPS7vaDQOVvy/uz+wR/iCtOrxJj767MgbYA6djKoHrrUacxDQZreMUpAbCmPdyGIoVS OJ84u0hMRdz5Y1axFrZy4eNqlr+X+QWww9UL2ShztfPafSPa866HDFQuDCM6PV5eNiaL r0LOFKGkQhCw3i3X/cTshRrGrkrAsI96PBHnoJkRw4/LRrQQ4jjJ8glULvsEjd4+7uMP BF2w== X-Gm-Message-State: AOAM530RgnTme3lQgI58DhCN4gBo8Wt28XIUSU2BG2LwtKGF+pYJIuOA KbgACo9ubrobVSPbPUczvwWqUg== X-Received: by 2002:a17:902:7610:b0:151:6152:549c with SMTP id k16-20020a170902761000b001516152549cmr10650246pll.91.1646631573579; Sun, 06 Mar 2022 21:39:33 -0800 (PST) Received: from localhost ([223.184.83.228]) by smtp.gmail.com with ESMTPSA id z14-20020aa7888e000000b004e5c2c0b9dcsm14392582pfe.30.2022.03.06.21.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Mar 2022 21:39:32 -0800 (PST) Date: Mon, 7 Mar 2022 11:09:31 +0530 From: Viresh Kumar To: zhanglianjie Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] cpufreq: unify the show() and store() styles of attr Message-ID: <20220307053931.kkhnxrujljynp5cz@vireshk-i7> References: <20220306021250.64315-1-zhanglianjie@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220306021250.64315-1-zhanglianjie@uniontech.com> User-Agent: NeoMutt/20180716-391-311a52 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06-03-22, 10:12, zhanglianjie wrote: > Unify the show() and store() styles of attr, What is the problem with current naming that you are facing ? What's there to unify? Are there two types of names used here ? If that is so, please explain them first as I am not able to understand why you are making this change. -- viresh