Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a19a7a28-4b77-dd41-8213-f46ff64da921@amd.com>
Date:   Mon, 7 Mar 2022 13:24:15 +0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [RFC PATCH 13/13] KVM: SVM: Use fastpath x2apic IPI emulation
 when #vmexit with x2AVIC
Content-Language: en-US
To:     Maxim Levitsky <mlevitsk@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     pbonzini@redhat.com, seanjc@google.com, joro@8bytes.org,
        jon.grimm@amd.com, wei.huang2@amd.com, terry.bowman@amd.com
References: <20220221021922.733373-1-suravee.suthikulpanit@amd.com>
 <20220221021922.733373-14-suravee.suthikulpanit@amd.com>
 <34f52fb38a54e22ede0f2e28c6a0ecb49bf01a68.camel@redhat.com>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <34f52fb38a54e22ede0f2e28c6a0ecb49bf01a68.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUlPOHdmZTR3L1dmYWFaaERKOGgrNFkxeE9FVHl6RUFpR3VHSDRjSWZEdWM3?=
 =?utf-8?B?UEZkZUZuK2R3VDEvRUFKK1lrUnkzOWJkSmVCbEVCSnJMNUVIMW0zdjJjbitj?=
 =?utf-8?B?SWhzUDJ4ZEJQRjlRT1Vtc3gyOGtTUHFIS3J5OFpNMlhRNHpZYnZ4ajJsZk8w?=
 =?utf-8?B?bzlRMXowK256Umo1ODVFM3FoRjlvckxMTkdwaElJQ2VzNGFtRFV1bnczbWlV?=
 =?utf-8?B?dWhBMzA4TjMvUTRPNFRGSG1JQnAvWUNndVlVQkQ0ZzdVd3NzVFpVcS8zUDR1?=
 =?utf-8?B?ZVJUNkZ1Qm92RDc4Ym5nc3hqajViT2FUelkxTnRWay90WE1ZL2ptWFU3OFpO?=
 =?utf-8?B?SnpXOXp2bmoydHdGOUFmZUZsNy9vbmlWd21BRG8xNEM5NVBIYXd6bHhpZzRp?=
 =?utf-8?B?ZzNLckpCK1NHRjNQU2dQZ2FKbmdIT0hCNHdsTGdXS2RFYk1iRDFSenpyZUhs?=
 =?utf-8?B?SzhBNGZMa1RneVgvOWhwZXp3Ymd4S0k3bWFtbTRzMm5VKzkrSlFxWTJLQ0pW?=
 =?utf-8?B?UGp4Q2RFR1IxVnA5MkU0dGtDSXptZ3hsN1B3VUpsSXU5QW5BV0ZZQWU2WUt6?=
 =?utf-8?B?Slp5alRwdFhIc0lWUVBVL3gxcjhWcmVoanZwM3htaUhnaTgyR0Q2bHdUeE50?=
 =?utf-8?B?ZkRWMFVRNnkrdm4wYUk5TEhxTDc4NTE5cmdSYldCbTJud29GdmVYT09jTWFX?=
 =?utf-8?B?SHRaQ0x6SnhwYWhrMmV2YjJqK253T2NYakthcEVzZDdzb2poNVRBRm05RDhM?=
 =?utf-8?B?SStmbGRDSlo2bW5teVRmTVMwUW02VGx0ZGphcC9uNGtSOWc1MU5pOGVRU3cz?=
 =?utf-8?B?ZFJJUUJQVnY1SU1tOU12bHNDWXZYZEtWNTRpUW9OY0pncmpoTS9hRGJvZEdF?=
 =?utf-8?B?WnFGTjhRT2k4eTc1QlVhZnQwVmV0eWVtbDR2NU02Z1hYQktvcUYxNWxwYUlH?=
 =?utf-8?B?c2Q4c3VVV0xrM2FvSWgvdUxwN0FHTlZDSENzelRZcU5XNmcyVzYvUDVpQ3hU?=
 =?utf-8?B?c2xRZWRYcFVZL3BVb1BMa040U0FvWXY4ZWRlOXdUL3k5VElsUSsvaWRCUUxv?=
 =?utf-8?B?KzRhUVRMRlh3WTJsckp1UkJ5SXhTS0JrU1Vab3dobitlby9NUUprbFlrNDdL?=
 =?utf-8?B?NTJOZk5VZ25VNzhGY3prbm80VFh6R1E4cGdlVUd6em1OcW9DNWtlWFJnR0Nz?=
 =?utf-8?B?bkg5TzQwa3VOSVJiNFg2TmRROHMrdGtEMVI3RVh0NW1UeGMrUFgvZGNJTWxH?=
 =?utf-8?B?MU5XSmhzWXJrSHVzNkw3L1VqNHB3TnQ3eW4rNDNHbWg5YmpCODc0ZDBJZ1Jo?=
 =?utf-8?B?NFRnQ1FxcVJVZWV2ODFsUk1wc3FOdnBWM3ovOXlUeVMwZFc2TkVyTmJlc1VP?=
 =?utf-8?B?YU5OckkxOG5zUzR1cWx3WWtxOTVYRjBrNFFJdklUVHdDSGtLMExONTJZaHpR?=
 =?utf-8?B?di9RM3lyVGlyb2JiWmNwRFBnZ3owVGxuTzl4MDVLRmVMTi93VnArODJ2THla?=
 =?utf-8?B?cis5a0NEVmViR012UHJvY2dqS0tyUGdZbHI3ZERHSkgyUTFBa0hRRTdQSGlI?=
 =?utf-8?B?OFIySUR6Nk5zZ2lUa2R2UytwZFVYbkNwZGdnTUxxWktxcm9QNFlhOHYyeHdp?=
 =?utf-8?B?Wm5VemJWQ20rYm9iK1c2YzBnVS9kZ0Mxb1FhMnFIWmFENGpZQTdzMWVSK3B4?=
 =?utf-8?B?Z3JJYXE1S2IwSDhLd3dCT0ZyWEhPTXhXL1crRHMxZWpQUG5OdUlzeVpWdDJ2?=
 =?utf-8?B?OUlPTnh5bDAzRlVtRlJmNkpNbEJYcmhwc01QZktZRU5qSHRpOUxmd2VyNHVK?=
 =?utf-8?B?cXEvNGNROW5ZdnJJbGV2RG9yYzI5ZzBLNzM2NWxrU3F1SEZycC8rZGFnY2Vv?=
 =?utf-8?B?ZVNSMm0zVXlOZnJ0YkhsdXBQUklzWExLZHBVbmFHTndyaVd1RDNnTXRBNjVm?=
 =?utf-8?B?aVRFdk5BMjNORnNTY0lxOFdHM1NXR0RiTnhkc1A2bGRGaVUxdFQwUlh5ZVBh?=
 =?utf-8?B?emI2cFNzYi9kK04xVmJEakYyVXZ6ZCtDNHRuc1Z3M1Fnb0oyL3drUzBXMGt2?=
 =?utf-8?B?cGVYL3BraXVuK2ZQN2lpNDRPR3o3M0VYQ1dETEo1VEpVeHB0Z2Zmd0R3ckk1?=
 =?utf-8?B?UlRJS1FyOXFBZUVUQnhvQ0lJeUExOHgxc0gzZWoxMWhtU3hrYTBQVyt5cWVt?=
 =?utf-8?Q?cKflDLjKFeWs8xcbiym2pLE=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ba825a4-bee0-4674-8f2c-08da00032122
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 06:24:27.1535
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N2tbNbHoQN4F9OioiVqJMlSeTF70Dc25Gqee+TFAGPcLNcoTd2vGOODRGeDLq3UyTJLTcqSvXBRDCRIbeL5ZIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5055
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Maxim,

On 2/25/2022 3:12 AM, Maxim Levitsky wrote:
> On Sun, 2022-02-20 at 20:19 -0600, Suravee Suthikulpanit wrote:
>> When sends IPI to a halting vCPU, the hardware generates
>> avic_incomplete_ipi #vmexit with the
>> AVIC_IPI_FAILURE_TARGET_NOT_RUNNING reason.
>>
>> For x2AVIC, enable fastpath emulation.
>>
>> Signed-off-by: Suravee Suthikulpanit<suravee.suthikulpanit@amd.com>
>> ---
>>   arch/x86/kvm/svm/avic.c | 2 ++
>>   arch/x86/kvm/x86.c      | 3 ++-
>>   arch/x86/kvm/x86.h      | 1 +
>>   3 files changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
>> index 874c89f8fd47..758a79ee7f99 100644
>> --- a/arch/x86/kvm/svm/avic.c
>> +++ b/arch/x86/kvm/svm/avic.c
>> @@ -428,6 +428,8 @@ int avic_incomplete_ipi_interception(struct kvm_vcpu *vcpu)
>>   		kvm_lapic_reg_write(apic, APIC_ICR, icrl);
>>   		break;
>>   	case AVIC_IPI_FAILURE_TARGET_NOT_RUNNING:
>> +		handle_fastpath_set_x2apic_icr_irqoff(vcpu, svm->vmcb->control.exit_info_1);
> This just doesn't seem right - it sends IPI to the target, while we just need to wake it up.
> avic_kick_target_vcpus already does all of this, and it really should be optimized to avoid
> going over all vcpus as it does currently.

Ah, you are right. I'll remove this patch.

Regards,
Suravee