Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e1cb34ab-2ed4-0855-b59b-aa6e5a9206f8@kernel.org>
Date:   Mon, 7 Mar 2022 07:31:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 2/7] tty: serial: samsung: embed s3c2410_uartcfg in parent
 structure
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220304080348.218581-1-krzysztof.kozlowski@canonical.com>
 <20220304080348.218581-2-krzysztof.kozlowski@canonical.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20220304080348.218581-2-krzysztof.kozlowski@canonical.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04. 03. 22, 9:03, Krzysztof Kozlowski wrote:
> Embed "struct s3c2410_uartcfg" directly as a member of "struct
> s3c24xx_serial_drv_data" instead of keeping it as a pointer.  This makes
> the code clearer (obvious ownership of "s3c2410_uartcfg
> s3c24xx_serial_drv_data") and saves one pointer.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>


> ---
>   drivers/tty/serial/samsung_tty.c | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index aa5678d03704..a9a75b5b9705 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -86,7 +86,7 @@ struct s3c24xx_uart_info {
>   
>   struct s3c24xx_serial_drv_data {
>   	struct s3c24xx_uart_info	info;
> -	struct s3c2410_uartcfg		*def_cfg;
> +	struct s3c2410_uartcfg		def_cfg;
>   	unsigned int			fifosize[CONFIG_SERIAL_SAMSUNG_UARTS];
>   };
>   
> @@ -2200,7 +2200,7 @@ static int s3c24xx_serial_probe(struct platform_device *pdev)
>   	ourport->info = &ourport->drv_data->info;
>   	ourport->cfg = (dev_get_platdata(&pdev->dev)) ?
>   			dev_get_platdata(&pdev->dev) :
> -			ourport->drv_data->def_cfg;
> +			&ourport->drv_data->def_cfg;
>   
>   	switch (ourport->info->type) {
>   	case TYPE_S3C24XX:
> @@ -2632,7 +2632,7 @@ static struct s3c24xx_serial_drv_data s3c2410_serial_drv_data = {
>   		.clksel_mask	= S3C2410_UCON_CLKMASK,
>   		.clksel_shift	= S3C2410_UCON_CLKSHIFT,
>   	},
> -	.def_cfg = &(struct s3c2410_uartcfg) {
> +	.def_cfg = {
>   		.ucon		= S3C2410_UCON_DEFAULT,
>   		.ufcon		= S3C2410_UFCON_DEFAULT,
>   	},
> @@ -2661,7 +2661,7 @@ static struct s3c24xx_serial_drv_data s3c2412_serial_drv_data = {
>   		.clksel_mask	= S3C2412_UCON_CLKMASK,
>   		.clksel_shift	= S3C2412_UCON_CLKSHIFT,
>   	},
> -	.def_cfg = &(struct s3c2410_uartcfg) {
> +	.def_cfg = {
>   		.ucon		= S3C2410_UCON_DEFAULT,
>   		.ufcon		= S3C2410_UFCON_DEFAULT,
>   	},
> @@ -2692,7 +2692,7 @@ static struct s3c24xx_serial_drv_data s3c2440_serial_drv_data = {
>   		.clksel_shift	= S3C2412_UCON_CLKSHIFT,
>   		.ucon_mask	= S3C2440_UCON0_DIVMASK,
>   	},
> -	.def_cfg = &(struct s3c2410_uartcfg) {
> +	.def_cfg = {
>   		.ucon		= S3C2410_UCON_DEFAULT,
>   		.ufcon		= S3C2410_UFCON_DEFAULT,
>   	},
> @@ -2721,7 +2721,7 @@ static struct s3c24xx_serial_drv_data s3c6400_serial_drv_data = {
>   		.clksel_mask	= S3C6400_UCON_CLKMASK,
>   		.clksel_shift	= S3C6400_UCON_CLKSHIFT,
>   	},
> -	.def_cfg = &(struct s3c2410_uartcfg) {
> +	.def_cfg = {
>   		.ucon		= S3C2410_UCON_DEFAULT,
>   		.ufcon		= S3C2410_UFCON_DEFAULT,
>   	},
> @@ -2749,7 +2749,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
>   		.clksel_mask	= S5PV210_UCON_CLKMASK,
>   		.clksel_shift	= S5PV210_UCON_CLKSHIFT,
>   	},
> -	.def_cfg = &(struct s3c2410_uartcfg) {
> +	.def_cfg = {
>   		.ucon		= S5PV210_UCON_DEFAULT,
>   		.ufcon		= S5PV210_UFCON_DEFAULT,
>   	},
> @@ -2778,7 +2778,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
>   		.clksel_mask	= 0,				\
>   		.clksel_shift	= 0,				\
>   	},							\
> -	.def_cfg = &(struct s3c2410_uartcfg) {			\
> +	.def_cfg = {						\
>   		.ucon		= S5PV210_UCON_DEFAULT,		\
>   		.ufcon		= S5PV210_UFCON_DEFAULT,	\
>   		.has_fracval	= 1,				\
> @@ -2827,7 +2827,7 @@ static struct s3c24xx_serial_drv_data s5l_serial_drv_data = {
>   		.clksel_mask	= 0,
>   		.clksel_shift	= 0,
>   	},
> -	.def_cfg = &(struct s3c2410_uartcfg) {
> +	.def_cfg = {
>   		.ucon		= APPLE_S5L_UCON_DEFAULT,
>   		.ufcon		= S3C2410_UFCON_DEFAULT,
>   	},


-- 
js
suse labs