Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bcf0567c-b17a-4c39-4a34-6da2d9edb20f@canonical.com>
Date:   Mon, 7 Mar 2022 08:51:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 1/2] dt-bindings:pwm:Add bindings doc for Sunplus SoC
 PWM Driver
Content-Language: en-US
To:     hammer hsieh <hammerh0314@gmail.com>
Cc:     thierry.reding@gmail.com,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        lee.jones@linaro.org, robh+dt@kernel.org,
        linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, wells.lu@sunplus.com,
        "hammer.hsieh" <hammer.hsieh@sunplus.com>
References: <1646374812-2988-1-git-send-email-hammerh0314@gmail.com>
 <1646374812-2988-2-git-send-email-hammerh0314@gmail.com>
 <9113e319-58a2-fd90-6887-fb32eb21fd18@canonical.com>
 <CAOX-t55sXVg8Fj_G_xzxWTStxZXOwKo46=_R0LkfHnMS051KaQ@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
In-Reply-To: <CAOX-t55sXVg8Fj_G_xzxWTStxZXOwKo46=_R0LkfHnMS051KaQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 07/03/2022 05:18, hammer hsieh wrote:
> Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> 於 2022年3月4日 週五
> 下午11:01寫道：
>>
>> On 04/03/2022 07:20, Hammer Hsieh wrote:
>>> Add bindings doc for Sunplus SoC PWM Driver
>>
>> You miss spaces in the subject.
>>
> 
> ok, will modify it.
> 
>>>
>>> Signed-off-by: Hammer Hsieh <hammerh0314@gmail.com>
>>> ---
>>> Changes in v2:
>>>  - Addressed all comments from Rob Herring.
>>>    modify author's mail match Signed-off-by.
>>>  - rebase kernel to 5.17 rc5
>>>
>>>  .../devicetree/bindings/pwm/pwm-sunplus.yaml       | 40 ++++++++++++++++++++++
>>>  MAINTAINERS                                        |  5 +++
>>>  2 files changed, 45 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml b/Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml
>>> new file mode 100644
>>> index 0000000..19fe5d5
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml
>>> @@ -0,0 +1,40 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +# Copyright (C) Sunplus Co., Ltd. 2021
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/pwm/pwm-sunplus.yaml#
>>
>> Is it going to be one binding for all Sunplus SoCs? Existing and future?
>>
> 
> yes, that was my first plan.
> but not all sunplus SoCs use the same IP-based,
> so I will change file name form 'pwm-sunplus.yaml' to
> 'sunplus,sp7021-pwm.yaml' in  next patch.

Yes, that might be better approach,


Best regards,
Krzysztof