Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b5976993-aee0-b5f3-2762-8066d7f083d1@os.amperecomputing.com>
Date:   Mon, 7 Mar 2022 15:31:13 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
From:   Quan Nguyen <quan@os.amperecomputing.com>
Subject: Re: [PATCH v6 5/9] regmap: Introduces regmap lock helpers
To:     Mark Brown <broonie@kernel.org>
Cc:     Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Rob Herring <robh+dt@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-hwmon@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
        openbmc@lists.ozlabs.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>
References: <20211224041352.29405-1-quan@os.amperecomputing.com>
 <20211224041352.29405-6-quan@os.amperecomputing.com>
 <YcXI73GKNdx/gvUb@sirena.org.uk>
Content-Language: en-US
In-Reply-To: <YcXI73GKNdx/gvUb@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkVHYXdGK21valdlYUN6WmQrcGpGWXV0L1RxMlNQb0JnNzdBenBFVUdDR0lq?=
 =?utf-8?B?c0xCWGVkWDdEUHdxOTBUZUlacTJPY3NrcTViNlRaNm9xRHVicFh1UkNObEhJ?=
 =?utf-8?B?ZGlvZGF5bUlUTnNRKy9jbXBZNkx2VE5Lb2xUME5HQmRLdHZjWjd2eGx6Q1Rl?=
 =?utf-8?B?SldYWHJIQ1RqUFBHeU9rT1VCdm9uTmMrbk9sUDdBdVpuZHJQdlBLVk5HUkxH?=
 =?utf-8?B?MkFLNjZSVTZJTC8wa3BiMmNzTzhlc094Q2UzMEJNUU14NEtIWWRDa1Y1VEk0?=
 =?utf-8?B?SzBGUjV0c1dXTk52b3dXUWs1YkJSaUZvWjdzTWRrUjgyb0IwQjJOYmthbWdz?=
 =?utf-8?B?dWdOYWRZbWpUUUY2WkRNNFpVZXJQWURpenhtOS9vREd5RWJqV0hVai9LTUJw?=
 =?utf-8?B?bnh6bS9tZEVydHBWZ2JkdEtFYVJhckducVZSQkt2dTlKc3BZZFRFSHZaV0Vi?=
 =?utf-8?B?MzM3NDZvZVdTMmpEQS8rNCtieTY5WXN5SHJuTTRZT3BSZXZXMW05TUVrZFow?=
 =?utf-8?B?UjhETWRTNUtnYjR3NGR5cnVjY3hKSW1PVVJVbHUyVG9UL3RTcHJhdzQrY0I2?=
 =?utf-8?B?eGJuM2svdW9FQ3RGbXhZaE0wRFdTL1d0ZTd1NDBqc0c2RHFucE5DbzRCZllw?=
 =?utf-8?B?cXpvUkZRaU00SzdaZHRDVHYrcjdKSlgvdTYrd1hwY2x0M2xCTFk5L0NZWUpz?=
 =?utf-8?B?aUk4S0pObzNvY0NvSDZZdmFwVmVRMlNZY082S0lNYkhrWmlWbW9GTU1KNE1Y?=
 =?utf-8?B?Y1JJZWRnWmg1N09Wcm1iVGRlR05kb2llb0hYdXJib2ZGSmZOQ2RyMlRSOEJB?=
 =?utf-8?B?MUlFUGZEelorK2FEL0dSSmhCNnBRTzN6UG9yVmVqdnhhOFFjN1FKL3JwcFl4?=
 =?utf-8?B?RmNLdEx3REVad25udWJiT3k2NHQzcXJtUVpZNU1BZnRRRWRTdHZvOXRxVzRL?=
 =?utf-8?B?cHp3NTRoczMxWjhzUHBUZGlpSzlPbloreDVPSExxMEhFUWV5ODI4dlA2V2Vp?=
 =?utf-8?B?SkNJQzVpNnFNU3pub3VNVXlwTHdSajQ4bVNCb1J3TFdYa1ZSYk5NM3FrRUlR?=
 =?utf-8?B?SHA1cW5UNS9SeUlHekhueUtRa0Q1b01UWWZnY0dlTlJ0NGhaczBQb09XbnlP?=
 =?utf-8?B?U2xBQzErQm9uM1JDaitBaDAzOHhSZDBpQ01iZ093bHpzTUh2YlRYc3RPdmJI?=
 =?utf-8?B?RVprcmF5bHJwUkNuKzNXMy93T3FWemd2eFFMVnl1T1BIODVjN21GbEwwc0gy?=
 =?utf-8?B?a1dkTTlOT3l0Z1p4QzdMb2ZGYkNWNmtHdUNTc0V1VWRtakwwQS9oTlFJMmp5?=
 =?utf-8?B?ZU51djVWWjgyNUY5QXBVQmtyeEgrSThoQVhHNkhVNXBpOXpmRTcwY0d4alB6?=
 =?utf-8?B?dkdBUkVvTTg4T2pKUG9tcEZzSlZGYnNJOFJ3QVM3VW8rQUtGK3ROSnlJYTMy?=
 =?utf-8?B?SHFxUWJWdUIwUXBtcDd4c21MN2k2ckVwK2FzVmEwNEhsRWlpUFJMV1BNL3hO?=
 =?utf-8?B?bncwblQ3dFBoRFNic3dnQ1R0cHFMeDVDY25RZHZYNUM5OWtDbXdYUCtzcXIx?=
 =?utf-8?B?UzhuTW9qL1hoTVBnTnh2WGFmYXI3Zmpjc2w0UlB6MmlYckRTaXBjeGlkV3JP?=
 =?utf-8?B?VUFuSkhpWWI5dXdYK2VFM01OUTFBQUQ0YzE1TjJOYnJEUVFsUFRFcTNvSDVl?=
 =?utf-8?B?d1ZObE00WlliWkUveWpVMmtKVFcyQ1pmRDR0U1NFTWUvRWw3dDVBNVBNRjRT?=
 =?utf-8?B?b2hleW5uVUk4Q3FzeTZ3MTZISnpZSGZMeW9QcjhhMDVuU2MxdWZnSEE2cW5m?=
 =?utf-8?B?eFZ5QVdmWWYyTEF2cXNhekdXMGNqWnMvWDU3cGNid1NDcC9jTnBjVTJ4Ujg5?=
 =?utf-8?B?cllnRWZicDBPYXFWeDhTeE9TeTljd1U3bXdTWDAwYnJROWFubjhHdm9COHVW?=
 =?utf-8?B?azB3am9yTDhUa0Q4M0Raa3hJUU4xZjF1M2s1Z0VpKytKNGJqTXhvQ0s1VGxL?=
 =?utf-8?B?Ym1Ybi9xdlFweVR0c2dNTzFwc1RjMHQwTmdwQlJucUh5WjJOSEhyZGgvMEZS?=
 =?utf-8?B?emp1S2pjaDBTYXpvb1gwcXo5OEs4QVhPTHRwZHFKenpxY3FDWnFZSkw2dGR6?=
 =?utf-8?B?clYxbXhHZnR6S1ZsSENER1l4eXFlem1JakxnU0ZLMlVKcEZRblA0SXRwODVi?=
 =?utf-8?B?WjZJMkV2RGlnRHNySFBTWGx1YzdGSkxkc1k0cGltUGt4TElMY0hZVnJKUXh6?=
 =?utf-8?Q?Uih2KUmUyfGxT0D4lbIdn1GeRPMMjDAiiXHEVTBrFI=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88a8ff70-30fe-4d51-cc9b-08da0014e036
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 08:31:29.0557
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d2EwDppoyxadIxoB1XAGsqz5b0q+FzGsv+bgv+o25neU8fpaZwsD9g54f8n7bT0hTEdIbBQ1JjBndYKUTTYukiD5Nn4Kg8ql7bn9ZLlSyFE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR0102MB3498
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24/12/2021 20:19, Mark Brown wrote:
> On Fri, Dec 24, 2021 at 11:13:48AM +0700, Quan Nguyen wrote:
>> This commit introduces regmap_acquire/release_lock() functions and makes
>> them available for drivers that need atomic access of regmap registers
> 
> You've not explained what something would need this for and how
> it's expected to work - we don't provide unlocked access to the
> regmap to client drivers so I don't see how one could safely use
> this.  It's unclear to me what this would mean or why it's not
> better implemented in the client driver.

Thanks a lot for the review, Mark.
As per my comment in the other email, this code will be removed in my 
next version.

Thanks,
- Quan