Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ab145110-6a9d-8a1d-811d-0c209b4bac60@os.amperecomputing.com>
Date:   Mon, 7 Mar 2022 15:31:40 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
From:   Quan Nguyen <quan@os.amperecomputing.com>
Subject: Re: [PATCH v6 6/9] misc: smpro-errmon: Add Ampere's SMpro error
 monitor driver
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Rob Herring <robh+dt@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-hwmon@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
        openbmc@lists.ozlabs.org, Mark Brown <broonie@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
References: <20211224041352.29405-1-quan@os.amperecomputing.com>
 <20211224041352.29405-7-quan@os.amperecomputing.com>
Content-Language: en-US
In-Reply-To: <20211224041352.29405-7-quan@os.amperecomputing.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QW9VWjEyRDY4NEdYK01KOHk5NGdJdWc2NkFZQSswaGV4eStjS2NWTW5SV3Bt?=
 =?utf-8?B?OE9LS21KU1ZLc2RKN0M0dm1vUFVPNTlwVEoyRWFwalN1UkVHRzVkOG9HNW8x?=
 =?utf-8?B?eW9CMm5mWFM4NHlaekZxeG8xS0c2dWtNTmp2YWdSSVZSSXNSbS9GeTh5SHRr?=
 =?utf-8?B?b3RGazdiWFZPcllPUll5SWNWbUUvMGJGZDNGSUpOMmVjVkREWVFKQUNHWStp?=
 =?utf-8?B?N2p0bG82aGZwbWo3ejdta0dhNERnSkp5Nys2Z2FjWFNMejY1ZHRCTjlhT2dB?=
 =?utf-8?B?TjlMZUIxNm5rS1hZakh1VEZrdHFrU0lES3dXTUxTcjZuNVhjYmZnTlQvamFY?=
 =?utf-8?B?UEdOREFBUHBEdFhzRHU4NDVXbnJDd2tjbGVwa05qaTdsL2hOT2ZuZXU2Tkpz?=
 =?utf-8?B?b0JOL0ZrYjRTUERYTUJYVVRnRWoyMGtma3I5UDdJdXI2aytESVYySUxTQ2RC?=
 =?utf-8?B?RmZLRWsvb0VBeHd5NXQvQ3B6cVZwOEtQNkd1ZmNiOGJTdVBsYnEwSXFoZGV2?=
 =?utf-8?B?RGNGdEIvZzJyem1Zd1ZzWFdNa0RNSUNFZEpQZS9xQXdxMGNjMEpZYzZIWVNv?=
 =?utf-8?B?MlNtVWcyTlBSQ3JuRWp4WnVXdUFxNkNwZTVwUW1uTm5sR2tKNjJjajNFVGJn?=
 =?utf-8?B?UmxxRkZkczh1eW0wL2h0L2dRblREUDlYdDFDRkhJbVdYSjdoV2l6RkIxWmxM?=
 =?utf-8?B?eTBDVW9FdFdUeHJJZFBuMm1Vd25Yc1VLam5JWmg1R0lORDRhbHl5VmxzcFo5?=
 =?utf-8?B?K3NzQ0xjSU9Qakx5aW12ZHFOQ2IyWDdNekVIa2M3dStBa05RN29UZlpQQ2c4?=
 =?utf-8?B?RkFHc1RYaWhiODY1eEdqVU5oSkp2aGd6blh1dlN2djNSclNPcnB1bXgrK1lF?=
 =?utf-8?B?UTloUC9PRXdYY2w1R2Z0UFJ0UFNFMW5IN2xwcFd0V0xjQ0ZCSHJXYnB1UWtG?=
 =?utf-8?B?Z0pueUdocTdybnFkR1R2SnovOURhaW83bGc5ZlBRWjRMZm5YaTBpbmMvYis4?=
 =?utf-8?B?THZyQmNCaStHQnl5WmUyUDBaUFNzNUpNQmFYUXFQN0lSMHRWQk9uRktHYlFv?=
 =?utf-8?B?YkFQVmFEb1RYM3lGT3lvQktCUUQxVGNjNG9LL0VDR1RTTVQyNXRXRnNTb0F1?=
 =?utf-8?B?eGNWVC9UWEgrbEhtUjl6RkpkVExGU0VmWk1YZkVYMzd1bVovRGROZXVjYkdS?=
 =?utf-8?B?aEdVQmV1QXJtYk9jNXpPYVNRbUxtVWE1QWlmWGhiVE1pQS9DQWx4OVl6clU3?=
 =?utf-8?B?T0pCY0gvRG5TYlpGUWY5RGFlTEZBT05tclA4RDJ2cSs3VjdMMGpQbUVjVi9N?=
 =?utf-8?B?TWkwZldTb0pCY0tHMHhGU2wyUXB5TlBzdXBERVo4ZVNEbHBIcXhrZjg5VUc1?=
 =?utf-8?B?MkVXSEJZaVNibG81dURLV2NhYW9LMVFwZjVtbDBhWk04ekVqdS9uRktyWVpy?=
 =?utf-8?B?U0hQZ3BPRDNUZWxpeThUOVdVQjV5NlVoT3Rvc21uTS9rSHNld3pIM0dHcDNk?=
 =?utf-8?B?RExPQVdKVzFHczNkcFpyc2R6M0ZCdnpXK0ZVMEhacVpiNloxSlhpL0F1Y1Rn?=
 =?utf-8?B?V3hQdTFrY1NuSVQrOVhRZkVad3VFU2tNK0k3dHozWk1ibjc1cUpQc3FSUFFm?=
 =?utf-8?B?QWY0UkhsR2dPTHVMQUZpVXExdngxZGdMb091RXlMNUU0K2tlQ1dBcWV5R2tL?=
 =?utf-8?B?THZNMVg4WlBaakIzU3M3eGY4MTlIUXNxNE9KN3NYenVsZGNGblZNdGgwTHM0?=
 =?utf-8?B?cy9JaFBVcEc1OWVRVXhyc1RuSmpZU3BCQmc1SEpONFdSbzQvS2h3V2pqYld4?=
 =?utf-8?B?WlVJQVZGRzcwWFNJZS9tSENWaVFSa0RWenY0T0hjVGtCcXAzeVlRdndRSmdJ?=
 =?utf-8?B?WmtjRk9rWFpsc0oyVTdNdEUwdUVBSkVaeU9hN1BGa3haVUJoLzdvZ2Uzcks1?=
 =?utf-8?B?SnVCcTM0cnVEZitVYjRuK0psNkx0TFdkQTlvV1pKcFh5ZFlxbTczZ3VMSERa?=
 =?utf-8?B?QU4vLzE5WlFIK3B6SndLbFJ3QUZyeHpST2tWVEtiY0lUYmI2L2lrN2lOa012?=
 =?utf-8?B?OVJMdGU1bmdxdk9VT3RZNG9idzExWVpoWXJQdmJlL1VsUjRheWEzZWE2Q1ly?=
 =?utf-8?B?aXdqMWFBVHMycG1ZRDVIZG8yWEd2MGFqNjdrQTFNUkorYUlielJqbDAyTUFu?=
 =?utf-8?B?UXY2MkcvTkR4b0Q5dXBndkl4ZkNiZTJBQ2grN2FwUlBXc3Mzam5wRmt4bFRv?=
 =?utf-8?Q?BMLOob4a1weZN6W6tMMSVBWgL8nnrJiy5l2Ay3oego=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ebf272cf-7e9e-4c35-e67a-08da0014ef77
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 08:31:54.6599
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CMX2SGCeNcFzALPXybtIbMBmnuraTP665tPxHCFhu0ivm2/II02cMSTzah2097nUvsV03+womrkmqZGPnZc3yYljc3ZnMy3SXj5f9003cqo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR0102MB3498
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dear Lee Jones,

This mail is to reply your comment in https://lkml.org/lkml/2021/12/29/120

Thanks for the review,
- Quan

On 24/12/2021 11:13, Quan Nguyen wrote:
> This commit adds Ampere's SMpro error monitor driver for monitoring
> and reporting RAS-related errors as reported by SMpro co-processor
> found on Ampere's Altra processor family.
> 
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> ---
> Change in v6:
>    + First introduced in v6 [Quan]
> 
>   drivers/mfd/smpro-mfd.c     |   1 +

[Lee Jones] Separate patch please

Will separate this smpro-mfd.c in single patch only in my next version

>   drivers/misc/Kconfig        |   7 +
>   drivers/misc/Makefile       |   1 +
>   drivers/misc/smpro-errmon.c | 571 ++++++++++++++++++++++++++++++++++++
>   4 files changed, 580 insertions(+)
>   create mode 100644 drivers/misc/smpro-errmon.c
>