Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ab8c96a9-b064-f96b-9062-095ff8635ec5@os.amperecomputing.com>
Date:   Mon, 7 Mar 2022 15:32:10 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
From:   Quan Nguyen <quan@os.amperecomputing.com>
Subject: Re: [PATCH v6 6/9] misc: smpro-errmon: Add Ampere's SMpro error
 monitor driver
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Rob Herring <robh+dt@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-hwmon@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
        openbmc@lists.ozlabs.org, Mark Brown <broonie@kernel.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>
References: <20211224041352.29405-1-quan@os.amperecomputing.com>
 <20211224041352.29405-7-quan@os.amperecomputing.com>
 <YcWFrCjWSG65KQgb@kroah.com>
Content-Language: en-US
In-Reply-To: <YcWFrCjWSG65KQgb@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0hqZnYzcjRwUjdkcFNxZElrdnNOM3pTeUxxTHJDREF4S1VUSU15eVVYV00x?=
 =?utf-8?B?UTJyM2htTFo5YUhWRGZiQ0JqUjhLL1N0QWh1czRzbHN1UG1wdTJhWS85Mm5q?=
 =?utf-8?B?VEdwUm5ZZDBXRHN0QW90S2dHRTJVYnZiSUI4V3pSdVllK0V2RzJSNWZ2bkwy?=
 =?utf-8?B?bFBWbTRyVU9UWUhXVTdTM2laMmI4OHp0OC9ZamZYQWs1SStrdy9CLzA4SGhk?=
 =?utf-8?B?c2hPcXFPcnd4OHl4d3RKV09QV1VPaForTHRYTkxSQXdSc0xhZElvV1dvK25J?=
 =?utf-8?B?NWxGUEszSlo3S2tROCtYczNRSEI3Ynh5enlQN3dqb0hDUFkzdDd1NHBjR3lr?=
 =?utf-8?B?eTFCdm9hQi85cjJ4NnJTdHBNSE5ITU5NdWRIaStQbkIzYjZ3ZUVzc1V3NVJJ?=
 =?utf-8?B?bHUwL21tTUFCTk1TSUJyN216WEhrL2N3UGxweUQrRGZhNlhhNVk3V3dnTWZh?=
 =?utf-8?B?RzZRQktoSk9CbUlHUjZPSHYrakFWOWwrTTM3UWVJTk9sUmRNMG5OMFRxZ3Q2?=
 =?utf-8?B?RlJNNWpMTFVXMVptZXRQTXdmODg2VFNSMmd3eHdnNG8yL1l3MWczZTJ0anho?=
 =?utf-8?B?VkFNektpOFZpSFpkOEZCeWxZWW5WZ3lPaXJEUTEyYmFvdi9wQmF1YkgyWTBZ?=
 =?utf-8?B?Y0NlaUR3c1BpV2JKUGVpbHZWdk1xOHcyZjNpNFp0RURnZHFYeFE3OEh3b3hm?=
 =?utf-8?B?VDFvYWVGRW1kc0tWN2tIR2ZKQWptaFJTa1VyY3J5OUx4MzZGMnFXbVVNVlBK?=
 =?utf-8?B?Ull2Mzd5ODg0WlRTZXc4ckZkU0Ixcm0wNDZoeUJGN0pHZU9Gck5aSm91dWdE?=
 =?utf-8?B?aURGTG9RNFhTaU1oMEVwaTJCYldObFlCV3Nid0pEYUduZjJTTG5haWl0T002?=
 =?utf-8?B?RUlPWXAvL0FTQUZRb1QwNEVtOVpDZ25BOFhaclVadGN4THBEWnM1THAwU1BY?=
 =?utf-8?B?UE12OTFCN0lZaCsvQUhlVHJmOS9ZNmFWUVQ2UTRUOVlOQjFMNExmQW12S1VN?=
 =?utf-8?B?SlFvRDhSOGUyS2FEMXpZaDBSQWlYc2wrR1pqVkFRMWpobFlacklFUTNpM3ZN?=
 =?utf-8?B?d3JScjgzVXlDa0RTdE1nV1p1dnhwbytjRWNqWmtRa1BvbkJibEN4Q3kzdi9D?=
 =?utf-8?B?S3VhTWZaNFZuMWJmM204REZnVEdZeTFXdEp0em9WMVh1NEtUVlphRmJQckJE?=
 =?utf-8?B?THBKZHRZR1dNTDdpUGNUK3N5NXhaZ2FQajk2NCt1b2dEKzFKdFJPUTJMa0JQ?=
 =?utf-8?B?RFhsSEpKbTA2QkJTVVVTK2hlOFJsM0laZ054VnpHWHQ4S3lwd2ZNYWVIREVq?=
 =?utf-8?B?MWRZYWh4YUVoNUlzVHJrMWJLS01QMWpDVW11VVN1eDZ5UTJqSlIzVHRjdDFS?=
 =?utf-8?B?T3Ewc2hMMkQ3ZHVBVWZoeDk2SkJvSHMwN3B1clNHWW90SGExMjl0YjlBc3hm?=
 =?utf-8?B?K1ZmQmd2Vm9YcWRPbXl2eVpvYlVFQUZyVmp1d1c0QjlSdk5ORjhFL2h5TW9U?=
 =?utf-8?B?MmhpYk1YVnh5M2dpWDRlZUlsOFBLOTJzZTBRdEJEZzhMMEhhcmtoOTlGcHlN?=
 =?utf-8?B?Z3FJZDlDcGVMQkV4SUxTcGpaRCtMd0tJVk5OVCtLVG1YRjRPajFWSmZGMlE3?=
 =?utf-8?B?MjRpWFV6azF5T3N1dHJhZTBpcUJsMkFuUnpjNHEyWDNDNWI0UHVIMGQzdFZW?=
 =?utf-8?B?Y1d1SHJla1ppNUxRN0F6V3JmM25ZQ0RXNmZUSFNvdk0veVp5Rk1JZVEzOXEw?=
 =?utf-8?B?Nmx4dytBanV4bitWU1dmamJWY05pNkswSmEyRlpNdk1Lc1o4QzdONWUydHZQ?=
 =?utf-8?B?cnJIMm82VkU3K09uUUxZS1Q0NjUwTGx0Szg4d0hrZlliTzlXK2NoaHJNRzd4?=
 =?utf-8?B?RmU1VkVtbFMveUdKdmFVRWF2bGV2aDBjV0t5Y2JtK0xFTkM2V0dEMjh5NmVC?=
 =?utf-8?B?SU0xeWRTTmtIYkZxU2lRRUUxejFDQWZnL1lQYnJ4SVZRbUNERmN5T0pqVXNm?=
 =?utf-8?B?TFpUalFtM1ZHTFRlbU96Ukx6UCtiWFZUV0JFblpFcmt4SDVjWDFTWDVBYmx2?=
 =?utf-8?B?ZXB2VEFQTFEyOGVsRFdnWkVoaUVUbUtuOGpkVUlIUzUwbENrSVhnMDhFdlFO?=
 =?utf-8?B?Z0xsNGc4UDFCb2RpcVNUTmt1RUFISisySDV3Zis3Mld6aHRWdmwzWGhvZXVF?=
 =?utf-8?B?ZWl6WlJjZDVKaVI3R0xab1VxNytoYmk2TGMwcHVJQTNrVlR6bUMrSmwzZ2hl?=
 =?utf-8?B?b0RhRldaaGlCbUF6bkxQWDZZTTFRPT0=?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5186937a-acea-4657-e8f3-08da0014ffff
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 08:32:22.3934
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: juju/3QgeCQCl9iqMAd6TRdaT7kSPgHIaMdnRBjM+G6S0JMkNSuiFi8TcTYR4xepyRdpd809xvqtzHZzpA/1QsMbxcZZqeivSpugkEJKclI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR0102MB3498
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24/12/2021 15:32, Greg Kroah-Hartman wrote:
> On Fri, Dec 24, 2021 at 11:13:49AM +0700, Quan Nguyen wrote:
>> This commit adds Ampere's SMpro error monitor driver for monitoring
>> and reporting RAS-related errors as reported by SMpro co-processor
>> found on Ampere's Altra processor family.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>> ---
>> Change in v6:
>>    + First introduced in v6 [Quan]
>>
>>   drivers/mfd/smpro-mfd.c     |   1 +
>>   drivers/misc/Kconfig        |   7 +
>>   drivers/misc/Makefile       |   1 +
>>   drivers/misc/smpro-errmon.c | 571 ++++++++++++++++++++++++++++++++++++
>>   4 files changed, 580 insertions(+)
>>   create mode 100644 drivers/misc/smpro-errmon.c
> 
> You need Documentation/ABI/ updates when you add sysfs files.  Please do
> that for your next version of this patch.
> 

Thanks greg for the review,
Will update Documentation/ABI/testing/sysfs-* file in next version.

> Also remember that sysfs is only "one value per file", this driver seems
> to violate that in huge ways and is not ok.
> 

These sysfs's does not return "multi value per file" but a single record 
of data, one example is to return the 48-byte ARM RAS Vendor specific 
error record.

Thanks
- Quan