Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1769058pxp; Mon, 7 Mar 2022 01:52:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwckt7FY3biElwB3K5O572Bat1Wwa7uam8Re5GL6SfkhTgaAo7wHA+bxdQIWOsM7cRPfmwa X-Received: by 2002:a05:6402:1e8f:b0:3fa:72cb:1733 with SMTP id f15-20020a0564021e8f00b003fa72cb1733mr10507118edf.24.1646646760343; Mon, 07 Mar 2022 01:52:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1646646760; cv=pass; d=google.com; s=arc-20160816; b=KLQE8OH1sSGWRio28gTvTz/bXrZXYx83pbG3NWmTxR5okpB2DenupMg6PZh8Ty0KxR x3Yv9aaxymlGvjr/XTELCA2jXWACd7/pRfJ3odCWA+EdxoOSXfncnRc/mZQElyb0GcAd WZPjvWc0Z8ILsu7vvstDgSdVDjTc/0I3qOkRvpJgLCcWPR00UlkRKFf5PPmDKRGdtk2G +vVeiveExdE+ZDPYRrFDMdkYWhUooEw3e7HsnqHKcmmKdzlwW740xKBfZf3SFSx/ksYu VxEnLbkJ6cKdsa55ELBHTt3eTBS94tV92I0bZecVnBRebtxYzhcta6Q5v0x6fGlvzZDo Gfyg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:content-disposition :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oZEwTMe4Dvwaqad0Vyi5bi0yJJvPcEB51uDl93z9pjE=; b=mDn9ZhwA4GLzzKnbKZSxmAMQeJ6/rp8HmDaHP61kpQqqpOMlyY0oe2o84BX6zlchI+ uKVzH1C8y/lILihUbBpIB/Ed31NuC2Cdm1SGki9T9C5pfN5qJkb7RC/tcXkp3VYs4Ezv +zegp0bMpoXJw+ZRV0hktVZdckVayWJz61xbdIp2H8JTqDj0MM4WJng4D71x4bfJ+985 rnMvjeTPzl+NnbOi133Oc9h25/uLBXQX7n0cNYR+1gBq0vLf27djWsEzFIEef1DcNMX5 UWBu/ihYZj7FHqO1iO1GgKcwuez80DBjjL6qVB6aDC3DlY6F1U43XWDeGRiuZlDsCfuu 2oWw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@Analogixsemi.onmicrosoft.com header.s=selector2-Analogixsemi-onmicrosoft-com header.b=UyTf54V3; arc=pass (i=1 spf=pass spfdomain=analogixsemi.com dkim=pass dkdomain=analogixsemi.com dmarc=pass fromdomain=analogixsemi.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analogixsemi.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d2-20020a170906370200b006cfe5440e93si7599295ejc.879.2022.03.07.01.52.17; Mon, 07 Mar 2022 01:52:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@Analogixsemi.onmicrosoft.com header.s=selector2-Analogixsemi-onmicrosoft-com header.b=UyTf54V3; arc=pass (i=1 spf=pass spfdomain=analogixsemi.com dkim=pass dkdomain=analogixsemi.com dmarc=pass fromdomain=analogixsemi.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analogixsemi.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235161AbiCGEd7 (ORCPT + 99 others); Sun, 6 Mar 2022 23:33:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbiCGEd5 (ORCPT ); Sun, 6 Mar 2022 23:33:57 -0500 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2124.outbound.protection.outlook.com [40.107.100.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E3D12250D; Sun, 6 Mar 2022 20:32:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CGqpypnIrt3wvt4b22pIp7sk9WRHWPnVczRccorMJhKCZxMWFlFfWUBte8HfFNxzWcpucyy+xui0FY/Grz6KC6Zbhx/1bbphjncXSo/KuqOHQWySfFqKVM4OTFlBGaHLhUiG+nAbcPNXz4UcgYuD2H28MBmJOL6eGiWwnVRgpA/MjZqQE8CyF8C6f/gaCh8zzuC+rYLaxDVt/jmh0phxUMXeNtA/TGfzUikpeEfVAhEHkRj1yUzwotXM+qEyKlPBXNZhbnYHdqJfu+1TUE9dNEWsFRYt89gVKrY7FFmMuHdE5W6wRlc5nd+v8g+JAbnAW6A/FS+gs2jDbTES4E/O5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oZEwTMe4Dvwaqad0Vyi5bi0yJJvPcEB51uDl93z9pjE=; b=Gfm7BeQlnoMvtS1+r9ASSwRVSI2HwPidIqENhbnNqQIG/GMxmP7EbHD1d2xT9VG74vhD6B+0k0VWAtndE8gv96BaVw60MKb7KUhtmWcxZXJoxO13yoyBWmX9Z8yGgcSzt9kugfhN6x1Iw5aXdeQlFcVWonASJBMx13hL+fbeQgv7ArSGGxk3rATHy6f5uH9NGNE3pPvafbrpmH3ExvGPMD8G5/hpl2ZC3h96Hd9WSH6/OEQiNSnLngQ7ifvWyUef1k661c4v6fq6eeRNW+8w43J4OSqpy2ShjLvXfLstuN88UBKVYRwNkaIryOzK7DIkEy4shgaIqG8G5xpp31rhBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=analogixsemi.com; dmarc=pass action=none header.from=analogixsemi.com; dkim=pass header.d=analogixsemi.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Analogixsemi.onmicrosoft.com; s=selector2-Analogixsemi-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oZEwTMe4Dvwaqad0Vyi5bi0yJJvPcEB51uDl93z9pjE=; b=UyTf54V3i4puN4ZYgb3uKrHqUzKX9+LgelgVn1I/ZOibJbrqi2E9oqf8Rf4bFR+Q6+xrn0fYpkrpbLJ78sWI8CSKiLSplA8/exUDaF5QwDJIzsMX1KH4K6ZukCY5KIPJ4cWI70BlHKK92S+xBH71mrVfnkIEqgUrnwCYNSAY8Ss= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=analogixsemi.com; Received: from BY5PR04MB6739.namprd04.prod.outlook.com (2603:10b6:a03:229::8) by SN6PR04MB4832.namprd04.prod.outlook.com (2603:10b6:805:ac::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Mon, 7 Mar 2022 04:32:54 +0000 Received: from BY5PR04MB6739.namprd04.prod.outlook.com ([fe80::a865:6d10:c4a9:1142]) by BY5PR04MB6739.namprd04.prod.outlook.com ([fe80::a865:6d10:c4a9:1142%9]) with mapi id 15.20.5038.026; Mon, 7 Mar 2022 04:32:54 +0000 Date: Mon, 7 Mar 2022 12:32:49 +0800 From: Xin Ji To: Laurent Pinchart Cc: a.hajda@samsung.com, narmstrong@baylibre.com, dan.carpenter@oracle.com, robert.foss@linaro.org, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, sam@ravnborg.org, pihsun@chromium.org, tzungbi@google.com, maxime@cerno.tech, drinkcat@google.com, hsinyi@chromium.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, bliang@analogixsemi.com, qwen@analogixsemi.com, robh+dt@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v12 3/4] drm/bridge: anx7625: add MIPI DPI input feature Message-ID: <20220307043249.GA4174029@anxtwsw-Precision-3640-Tower> References: <20211105031904.2641088-1-xji@analogixsemi.com> <20211105031904.2641088-3-xji@analogixsemi.com> <20220307032248.GA4173850@anxtwsw-Precision-3640-Tower> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: HK2PR02CA0221.apcprd02.prod.outlook.com (2603:1096:201:20::33) To BY5PR04MB6739.namprd04.prod.outlook.com (2603:10b6:a03:229::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f3a8531a-7dee-45fe-0851-08d9fff38beb X-MS-TrafficTypeDiagnostic: SN6PR04MB4832:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bcL3bBOU1uLSwuoylkQEKWPUVD6CJ3EX79cFmHXmNpfPapXL3CADhkM6lSD31xuKikT9Fggv2pHIYkkZMxl3EBHpfz78Ixj/PaxO2xUgJrLmttNBC8M7b4rlAya6Z8uCcpfJOaebMZ5NNEm9MiXJstlJOILTrrtOnCaMXnWccKifMFMbFEqA1puyO0WTLv361qFWHHOLeSDtV7z+qg58s7Smjb12Qgu+EJDQPeiGOI20seN9dpTi03TqXZA3B+tiBS3W5yaKDgsYCHR+/JhsOft1M8MC/ZM5N7ZJtc8oSC2FcLd5Q9h0k+cjuABvhroo8OCjnmtRPdzwMTQF+RQpRcl/8jmK99xHnhAdAjtAA55HAUcTdnOjKvt4+Zmn795VePBKc5MNgdIG7i+o48uG4Txtg2H+FEamcYDa11hjAaa745RkO6cDcG5AlFKgcZITxdGYijpY3wW1H/HEDiLbAgbvMqOnpNIxcwUYYaPdwHbe3y9Cup9yc+tlwRtoXdexSsOG9sfLNZnRmW6TGVYmLLUM7cN6BUPHINVFKJnML9UMxbwUHuea0KrtP6APYMaD+Xpx5qP0/6xjDZksyoRoFRrKOKwz2/SbeX5nVsh8UrI2d1xF18O+lZLIyNG1nxOnejjp11DEcJRSvTmpNyHUA0mBjcmbCFwZg8BYlUFxL8oKqNc2hVYs8GyISZseq3OG6Q3ZAQI0A0kGaaINBiciWg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR04MB6739.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(7916004)(366004)(2906002)(498600001)(66476007)(66946007)(66556008)(8676002)(4326008)(30864003)(52116002)(7416002)(6666004)(8936002)(6486002)(6512007)(9686003)(38100700002)(38350700002)(6506007)(55236004)(86362001)(33656002)(6916009)(186003)(26005)(83380400001)(33716001)(1076003)(5660300002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q78pLmYJcPYWXQpiZPB/RvS/vGb69hUuE3SFiZY/AyDxYC4/IZx0RME/TeEH?= =?us-ascii?Q?/dYTeHXOCLInnUGN5lOCV6GsmcZjfoBVZX/NjQkcZ7ph/GC1T9gGDs7FC7Fv?= =?us-ascii?Q?62oCnWabcuGNOcpeUX3zZopQpjOaEgQxs4d/EmkE4er5u7iy6Z654ksNRHNB?= =?us-ascii?Q?tZN/BFCsDKVVxNUEcwxvkFYkj1ESzGOWAR12bR/MFHddDUCB6n/2z5Cp7VVg?= =?us-ascii?Q?IFHq/be4ShORygA8T65/mjqZWsAZfbtnhQnNEKuIhFzHVKCkhs8aH9KxTguj?= =?us-ascii?Q?qsO5jBtPqtCaJfwJuqGBb2r62uRasNjYnzs+9Hq7D4cw3eFZp/+6ejICEB3C?= =?us-ascii?Q?92iV0I/av99IjZ7VRXhDe628AdPjdmMAlXwJxZiyu9OIopThMGgb85NJ0sLV?= =?us-ascii?Q?eLdnYKAYJEzrmZk7MSQ9iGmuVDCfmWgHoBiGbCDHhJtSEUwpL1foKUhh2KzA?= =?us-ascii?Q?N5RNFexqDEJSN8s7drXMhPIvgkGbBDtrxp/y52WnHk8A3H7j0U8qfre9cRsH?= =?us-ascii?Q?Php+9NXuLjGbT7i59Vc7Jm1N95iD3Kh2LsTregb5HqwdC3+7gfpOvae2DOWC?= =?us-ascii?Q?81Xskwf7cxjXZUHXTsvGxIolbtsGKeFrF0yHy3mg+GouPWG0NWr+FSrjlquM?= =?us-ascii?Q?wmswixXTSmwpQ7OXiD/exyPxRCwXWY72j7QwfyaZ7WH+uCHLiT5AueywOoSN?= =?us-ascii?Q?gPND3alttrtmp6untCriKGI4xjnQxK1JzFFhWEgxckQCZ1YCMv6bw6XbYYFX?= =?us-ascii?Q?norU+X3oMy7Wkq7rh2nIBD8iUnRr3iElj5IxUJwoOYlMb4/4rVIR9OFPfE89?= =?us-ascii?Q?ONP6sE/q19Xto35gS2o4+afWfZFapcknXWZ6EwDlLS5cS1zilPWTOzdEllEr?= =?us-ascii?Q?tDx05g/2tGKOHNF63uxViyyv9Ivj0FYSvMvaQSbk4EWKpY0SnQZVKDPivD/d?= =?us-ascii?Q?6/V+qXMbw7XuUw3GeG9w7uoL+eErCQTtgGjwOYguF8Seyc9EngmX10hhIWpl?= =?us-ascii?Q?EANnT91ZLRdGtfjAn7nPpe4Fi18fA19JG+Cj/2i/nZe2LJjpzBs+Rfb4+av6?= =?us-ascii?Q?7zCemOSkID3OeBwj0rrZttq+PL0ZcY4VMRPMVvHbKaGHtGqy3g8rvRV6w2+l?= =?us-ascii?Q?7+uBUzgy26Ypi2+eSmjV0nlYiJx1P1YlZqq6WqwQg9qf2gjixerczA1ihjjc?= =?us-ascii?Q?AhzV3eRUmRgriXKkYASX07rLQjU1jX8ly/gQKQY8sDY5bFZAkL/F6oKmT50c?= =?us-ascii?Q?fuv2Noy/KUb7FR0Q4cubfgjaCTsszejkhJeCdVad+lE44nkkeXscTSdU3xiF?= =?us-ascii?Q?dRBdo2fnlrswr6eqqnsXDC0OdYIDzGETmd1SJLXmeb4av6q8+ZbIbZGPymh/?= =?us-ascii?Q?uQjpFxK+UFfqywN6+RrikCYEDjSNlDsWCDTOGe1kslRXTwPBefMj/baYh51N?= =?us-ascii?Q?UoLfFdpUZsxl2ak0SDo2QKoff0ydOqBPg9dc0quDXErrXAy0fjBNkAyfI8MR?= =?us-ascii?Q?6FXhT4RjDbKVgiCYdYPAKW9NivhIYwynovCprkz18JM2srb9zVauvJJaVu0F?= =?us-ascii?Q?xdzRfhzNAAhpFoXVdgfH72JJXLPOzW/UmE2RGfQ6QJ9G6icyAydkF1jlZSzS?= =?us-ascii?Q?Nd5PhYMkiOc1DwHxkktGDrE=3D?= X-OriginatorOrg: analogixsemi.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3a8531a-7dee-45fe-0851-08d9fff38beb X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 04:32:54.3894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d8hKkuFaaMfYAimLuYO6PGHIBNC7eTKdkUxsI5w0dw4VwatJR2obkbh8HhDwBBlLh22KhhTgA5I3hL4Oy4aNxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4832 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 07, 2022 at 05:30:09AM +0200, Laurent Pinchart wrote: > Hello Xin, > > On Mon, Mar 07, 2022 at 11:22:48AM +0800, Xin Ji wrote: > > On Sun, Mar 06, 2022 at 07:13:30PM +0200, Laurent Pinchart wrote: > > > Hello Xin, > > > > > > (Question for Rob below, and I'm afraid this is urgent as we need to > > > merge a fix in v5.17). > > > > > > On Fri, Nov 05, 2021 at 11:19:03AM +0800, Xin Ji wrote: > > > > The basic anx7625 driver only support MIPI DSI rx signal input. > > > > This patch add MIPI DPI rx input configuration support, after apply > > > > this patch, the driver can support DSI rx or DPI rx by adding > > > > 'bus-type' in DT. > > > > > > > > Reviewed-by: Robert Foss > > > > Signed-off-by: Xin Ji > > > > --- > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 247 ++++++++++++++++------ > > > > drivers/gpu/drm/bridge/analogix/anx7625.h | 18 +- > > > > 2 files changed, 205 insertions(+), 60 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > index f48e91134c20..f7c3386c8929 100644 > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > @@ -32,6 +32,7 @@ > > > > #include > > > > #include > > > > > > > > +#include > > > > #include