Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1769176pxp; Mon, 7 Mar 2022 01:52:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1RACDc19UvhmbonnKtDnsm1fdqGgzIIqy5bz5i2q1wx2l5qG7igacoRfe/wkA8gi+l8yU X-Received: by 2002:a05:6402:1112:b0:413:3d99:f2d7 with SMTP id u18-20020a056402111200b004133d99f2d7mr10390699edv.23.1646646771510; Mon, 07 Mar 2022 01:52:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646646771; cv=none; d=google.com; s=arc-20160816; b=qtUZ70Qyiqh5/x1eojbmAwuN786g+btsrWmCAa0wjE5FeAQa+yRNTihCPNjL4bNRnw jEFpF7grULske6r1Oz1Ie/5GiL6K85OXAvannl4mkWh0ROIkgTQVD1Y93uLKhTyl4ZLB 4KbfLOFYNlEE3oFuBDybI4NIAwsyI+gHvxkYNxcfrxZJo0Ip7IvTC3ekkMAeoSVw9xJR jIEvrkiErm8oFOKewh9XgNxISRNx+bEOh+pJAvJApDl3MQ65Y0dYxwLkVPGgiLIWMDg4 tC0auBXBjcUS/y1yhrIygKkasbAwW3W4bGfZjwLFbLtBVqYR2t8nTpio74s9f6BmD0pE Ndww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Ug00C0TLqhMQFVRMFl4wzRsq93sEkVz4GF6pOmW3fxo=; b=MbBp/PFpJFyoI5TGCcT3JrfgFZCNB7kdgvqSQu/VptucovPLszPm3ua+hNYzjBXUKJ Rv738AEdnuCA+a72t2jv+HYQKHc1HCLKbTm/+Gvj5izAVeM0QCKZbtOltMhSmEiSjxKu uIufcEXgIsjOnRXAz6Ol8bV18ZwMHNCRqeqKDEiHWnE3pRsBaXUBxIp/Tmwkz6CGhw9q QDmShfgyyqEc2EyteOxUuKzpXWnYV0vyJr8LApCqEHaUy/xSlI9PLbPBXI0yZvRWv0a1 3F8162vQClTyr+u445s2uV9l8hIDeXzdmH1aa97gofcPA0csMMON/Nnn7URplIEZuUQ2 2W4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ORj58dgi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp19-20020a1709071b1300b006d87926454csi9270444ejc.599.2022.03.07.01.52.29; Mon, 07 Mar 2022 01:52:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ORj58dgi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232867AbiCGFxQ (ORCPT + 99 others); Mon, 7 Mar 2022 00:53:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbiCGFxL (ORCPT ); Mon, 7 Mar 2022 00:53:11 -0500 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4D4848395 for ; Sun, 6 Mar 2022 21:52:18 -0800 (PST) Received: by mail-pg1-x529.google.com with SMTP id w37so12692896pga.7 for ; Sun, 06 Mar 2022 21:52:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ug00C0TLqhMQFVRMFl4wzRsq93sEkVz4GF6pOmW3fxo=; b=ORj58dgiICK4BAz457mklGokk8GqtxMq4KiofTaZ+jwDFCpEmEl+afUL09Si8xqHlU zWOPhmlo1xg1vH+z0+JxbZrC3OR06F7H9jNk58OnJ1R0JAIRRvohGFjlVrTUfQN5LM8T nEAGZ0JmS5RcbV/hm+p89949aHvfFX+R3fE9vbOozOdkIdGbRcboCX9r4yGQj8l25pA5 +PSauTsaIDrxUy/HfyE1sZJh0K+MoOrT0iCh7aKuWnPTc8VcB1766wh3XeMVcdTvn82c FPyCqBCOAbbHkFX9W19S8i5DpzILw6YpkD7U8YjZDh+LoHvdXacYN7rEU+akLt9fmpON VuHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ug00C0TLqhMQFVRMFl4wzRsq93sEkVz4GF6pOmW3fxo=; b=WPI5d+iyI0k411r5RX9GLij7A+aeipjIfSQJEyvT47DNteu/s2XAO9sGCS6AkBSKdl 2qO8ftSncYGafqKkNKVoLsppdLbidJpHOE5Pp4Mqk2BpEeR28HvYpAwvE0j2S+6RQYXb uD2KmvEPYQSTCMOHsRThejHLYrvB96v3tCpipAoDZ5++eB1T5YftH+D5apNTVrcrpri6 8dwd+fzGvX0kjCtMbcLMzguotv8z3k4qAibi17tW8sWyo7wCdNYhzswLru4v+nWRwKER 5eDP9QYxoLqhej2cH9IHrc3+iY9IyJWeO1zNoZrcCAJvhz8Sv3NELGaUJDyXZZI3BNtQ uXmw== X-Gm-Message-State: AOAM531k47RrQ59d6ix+8exgXilBN/v+YoAMCH17/PlYUIM69GZUXRBF V1G1IihlELS2BKrTJ2Y2URImzw== X-Received: by 2002:a05:6a00:1991:b0:4f7:1322:ca04 with SMTP id d17-20020a056a00199100b004f71322ca04mr209239pfl.85.1646632338180; Sun, 06 Mar 2022 21:52:18 -0800 (PST) Received: from localhost ([223.184.83.228]) by smtp.gmail.com with ESMTPSA id p128-20020a622986000000b004e1366dd88esm13530071pfp.160.2022.03.06.21.52.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Mar 2022 21:52:17 -0800 (PST) Date: Mon, 7 Mar 2022 11:22:16 +0530 From: Viresh Kumar To: zhanglianjie Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] cpufreq: unify the show() and store() styles of attr Message-ID: <20220307055216.gh3aiivz7o3tvomr@vireshk-i7> References: <20220306021250.64315-1-zhanglianjie@uniontech.com> <20220307053931.kkhnxrujljynp5cz@vireshk-i7> <62259d22.1c69fb81.5ba55.5efaSMTPIN_ADDED_BROKEN@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62259d22.1c69fb81.5ba55.5efaSMTPIN_ADDED_BROKEN@mx.google.com> User-Agent: NeoMutt/20180716-391-311a52 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07-03-22, 13:50, zhanglianjie wrote: > Usually /sys directory under the file, the corresponding Attribute contains > .show and .store, and their naming style is filename_show() and > filename_store(). But all naming style in 'cpufreq' is show_filename() and > store_filename(), So you need to change naming style. This is something that is present within the kernel and not exposed to userspace. I don't see why we would need to make this change and what good it brings. I would have supported this if cpufreq itself had different names, but for this one, No. -- viresh