Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Mar 2022 10:27:10 +0100
From:   Niklas =?iso-8859-1?Q?S=F6derlund?= 
        <niklas.soderlund@corigine.com>
To:     Guo Zhengkui <guozhengkui@vivo.com>
Cc:     Simon Horman <simon.horman@corigine.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Louis Peens <louis.peens@corigine.com>,
        Yinjun Zhang <yinjun.zhang@corigine.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "open list:NETRONOME ETHERNET DRIVERS" <oss-drivers@corigine.com>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nfp: xsk: avoid newline at the end of message in
 NL_SET_ERR_MSG_MOD
Message-ID: <YiXP7i/tSLpdzM3+@bismarck.dyn.berto.se>
References: <20220307090804.4821-1-guozhengkui@vivo.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220307090804.4821-1-guozhengkui@vivo.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?2Hyl6GOL1uFPRnA4F7p/CsiXgSA7juAhc4z8WXkoYDNXgNjgo9C3XBkUPn?=
 =?iso-8859-1?Q?AaNOr6P/lXK/iZhqsuepENtiWhLl7lSz2009BCI0gs5LmAf1vAA32Rz8jA?=
 =?iso-8859-1?Q?jN7uimVdkCFt19zEDrzDArG76zfMux9JAH0G57nxCxS7Q96BXY9e9gvZeI?=
 =?iso-8859-1?Q?O8BbyLI5tw3ZUCMg1rYYgti1PyZvz2b+aYSTQVk0pqY4fWnI4ulclO5ca+?=
 =?iso-8859-1?Q?iMMWFSY7s/8RKTbRTq9VVBpVvNgeB5VuHCot3PPh51DpzjNs5TTfZZ5AzO?=
 =?iso-8859-1?Q?AIcwNLyI1LLMIeQ2JDIbzFbKuMxf7Uciy7Ntk3B9PmyHhBLDpsMiu56Viv?=
 =?iso-8859-1?Q?v51J969MXml2gFiSE38IJhOpYHN8xajCJWGp3nAhwYiKdkvGbYs1ODAS8w?=
 =?iso-8859-1?Q?ud7EftC1wdJHi7PNih/VTM1SIfBzj0mzES5pVVZg39NCkU4Ud9hBHo8RcG?=
 =?iso-8859-1?Q?3xzy/82nkhVK1OyhkrzASkilArhHkqvJ7pRfgYbS9YWNoF/yGhaN+Y3SAS?=
 =?iso-8859-1?Q?mJDAWAKXhMStHaUbjhSEhhQfK1VJzto+Wdl4WJhmXd6gwtPyumUHTFs8aP?=
 =?iso-8859-1?Q?Qu052wqxiAH2G6Irp1zh5+0PNWUx3401B/LGJTMfB6GO8U4+YnuYl3zISi?=
 =?iso-8859-1?Q?AdOLRg77BosBsOxyhw6Dz9pj8DZt518RWPFR25IjbbF7YzURK4VOEAPy5V?=
 =?iso-8859-1?Q?P1oN2/EPsNc8S5Bbx0rHulNYtCiAQh4mAeewF69XXcwMOg/PFEFnYyHFWi?=
 =?iso-8859-1?Q?0jXMbRsO1qSHcONxKTC9rADbqHtQW9G323LYuaQ5amaknW2YpplAoQVxVP?=
 =?iso-8859-1?Q?yU9oxKCLAcOQuYme1DiTzXfqwvOw6MwsmjUfE6yWqOfq0X0gd5qJOkw9Ra?=
 =?iso-8859-1?Q?5hCfJSPXhQQhVRi2utB/tzHgnKa9CJs7AoT7BWI8zhoxCtg5PSwJy/fD0A?=
 =?iso-8859-1?Q?hDkoQcqNud11vcR5H/7fH/r9O9YZkYQSP9TOfV39XpZYYBCxC/l2W2dE7i?=
 =?iso-8859-1?Q?aWHrrAgDcStYL/2n9dI78jHH5nkLYYrk4OuaV8I5dy6pKghX7y0G3kQAtq?=
 =?iso-8859-1?Q?bQXGXs8GNDlKgeHX5OLkjOjP12+jIfEKxeOTOEfl2qeyBydFDZTwOc2+HH?=
 =?iso-8859-1?Q?zSR6WyxYlPWytmLewr35hxIncuyY8WQiQQrNZDDWFNnQmov7ifNxYhpoze?=
 =?iso-8859-1?Q?N+Jk7vzN3qM2g4SyO7XDLbxIWtb6WvWgSf7cxqyPXXR7jc//Zc6OE1yZuI?=
 =?iso-8859-1?Q?qbT+JlaDRCglhFR2VG0aNWbw9CH4hPHwaUGIGhADf40LcfrkiMa7qkkAta?=
 =?iso-8859-1?Q?Vz2KlwjJYI0ifXu1raJOWQaWiI4m2L5FUmfw/1RH72HET2nePSiShMyn0/?=
 =?iso-8859-1?Q?r/KU5/SJ6JXDP97Q+K4aZkgFOfSiiJZHqi3AePR0U7CgnP2zmM5Kz7QIfs?=
 =?iso-8859-1?Q?x72WwuNKsJNLyeztBOzE1+UFurXnc+FV88wZMkpN8x3iXSMi4e39QJWWzE?=
 =?iso-8859-1?Q?fx7LvuU3qhnQoRJfL6IefyX6cWP8CA2D6iVQcUGUMAoQUSKRuUH5FFUKLU?=
 =?iso-8859-1?Q?z/Oxbr8=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb4310de-b27b-47f1-d4a8-08da001cac0e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB4431.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 09:27:17.4427
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W/y9j73xivd5s6v+wxHmP3H+XSGc7eZnEQuGrk4hb7NN4iq9T9TMM/xVf//tKrmxMdbFUEwy/UnVxc4P9tdXhRxw0nfN8DyOsiuTaPMgbOY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR13MB5355
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Guo,

Thanks for your work.

On 2022-03-07 17:07:59 +0800, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING
> avoid newline at end of message in NL_SET_ERR_MSG_MOD
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>

Reviewed-by: Niklas S?derlund <niklas.soderlund@corigine.com>

> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index 00a09b9e0aee..d5ff80a62882 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -3431,7 +3431,7 @@ nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp,
>  
>  		if (xsk_pool_get_rx_frame_size(dp->xsk_pools[r]) < xsk_min_fl_bufsz) {
>  			NL_SET_ERR_MSG_MOD(extack,
> -					   "XSK buffer pool chunk size too small\n");
> +					   "XSK buffer pool chunk size too small");
>  			return -EINVAL;
>  		}
>  	}
> -- 
> 2.20.1
> 

-- 
Regards,
Niklas S?derlund