Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750948AbXBTS1L (ORCPT ); Tue, 20 Feb 2007 13:27:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751005AbXBTS1K (ORCPT ); Tue, 20 Feb 2007 13:27:10 -0500 Received: from agminet01.oracle.com ([141.146.126.228]:43643 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948AbXBTS1J (ORCPT ); Tue, 20 Feb 2007 13:27:09 -0500 In-Reply-To: References: Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <930023BF-0955-4C3A-989F-9ECC3D7ECCC9@oracle.com> Cc: , , "Benjamin LaHaise" , "Suparna bhattacharya" , "Andrew Morton" Content-Transfer-Encoding: 7bit From: Zach Brown Subject: Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event Date: Tue, 20 Feb 2007 10:26:44 -0800 To: "Ananiev, Leonid I" X-Mailer: Apple Mail (2.752.3) X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 28 On Feb 20, 2007, at 9:33 AM, Ananiev, Leonid I wrote: > There is change in the patch which is uncommented in preface. > Now aio_ring_insert_entry() is not called if req->ki_users>=1. > Before was called. > Could you comment it? It is described in the patch description, though perhaps not explicitly enough: "To get this working we change the aio_complete() path so that the ring insertion is performed as the final iocb reference is dropped." This stops an aio_complete() from generating a completion event before the submission path has had a chance to generate an error. This could happen if O_DIRECT bios completed very quickly before the submission path had a chance to return up and call ivalidate_inode_pages2_range(). - z - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/