Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1789324pxp; Mon, 7 Mar 2022 02:21:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJxgM7xsmEBY/Tal6nuFrzBB13Oe/QzLXnbW/ylsm+cmlR+WvhVdjd8faqf+NyrNyw7uhOuW X-Received: by 2002:a63:455e:0:b0:380:57a0:c1dd with SMTP id u30-20020a63455e000000b0038057a0c1ddmr2776186pgk.624.1646648503100; Mon, 07 Mar 2022 02:21:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646648503; cv=none; d=google.com; s=arc-20160816; b=JcNyIACZIzwnIV6DpIla8fbVKU+qlWPw3X6GYnCTeT/kkiomlhZA+O/RHTbDQxEcmv kcaKuM2aqK2qlNjVNxYMtM6zd1uJ2RPkmd5WwnaRYe8/szBTJQcCdr6bWt2NvFnXLn9J xuD7KtXRHMDv6+e9mpv+DcnhofSL1YioTDRlV/gweYhIxW8kqU5o0zqKT5KIpc8iRiI0 34MojipO2uir16AUfyAVJzwgGah8BnLjC4newUTJs5MSiS/O3rAYAkiCMAPyMIl1VS45 1Pbg4kERaVSycznL1K9FeMnf6iCftrUsn+9AjeFVrdUGqakvHv7HPtOtSiNWU3amek/T 47/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UpJD/fA21mCY5I8b4uzOhDeESMoC3y1LZ9ys5sH4zoE=; b=Wrt0OlhoILLjjBgKFE6nkGxeQ1t7ZYTnoNWF1cIfjyfV9PqaYYl3cMZ4U84SHBxWvz EEquJMZulAy7Q8grNWoIGvKEaRw3U5bnHmeR8GfaWYOyljAUINKRlZj8SbDZchP75qnL 4R+Q9MoEZVH40bzMlb/95zH59JZ8oI+4kv16Dn8n2MPAYija6v0AREHPuSurjWDB81x+ AC0+h5NcuqgZF3i6JD5E9qjyfGHjVBWPRrHqx2Fv8qUzrVL/34TLHzgcmeLxwVJolZn5 DVCHuhp5IYaw8+/jgHO8eYjAsAIn3YqPHkzV5v+hs+fCXqqEEy4xO1cWZXG3CAp/NC6z cVEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=si8jzjzL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k9-20020a17090aaa0900b001bd14e01f78si6886626pjq.102.2022.03.07.02.21.28; Mon, 07 Mar 2022 02:21:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=si8jzjzL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238497AbiCGJwU (ORCPT + 99 others); Mon, 7 Mar 2022 04:52:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240984AbiCGJlo (ORCPT ); Mon, 7 Mar 2022 04:41:44 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A71986D19B; Mon, 7 Mar 2022 01:38:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 08CDDB810B2; Mon, 7 Mar 2022 09:33:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C261C340E9; Mon, 7 Mar 2022 09:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646645618; bh=605Itjkcjl8xyYq0VbHCegn2Ox/shTKMoaIMC1UCEeI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=si8jzjzLn4+2e/Jyxrx8nCal33Ix/SRx12bj0oQj4mpzAsA4uxKjvUrh+/76gtqLB IX5cw1q0MRRcmdTgLIZGctokZtfkkQrnv82Trc2Hf7KLz2ViIUVYuuu0W81DrL0eW2 PupyCRXA+RQRRCy06XjR+zjCDeknjfXprpT5LeUE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sukadev Bhattiprolu , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 089/105] ibmvnic: complete init_done on transport events Date: Mon, 7 Mar 2022 10:19:32 +0100 Message-Id: <20220307091646.682645178@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220307091644.179885033@linuxfoundation.org> References: <20220307091644.179885033@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sukadev Bhattiprolu [ Upstream commit 36491f2df9ad2501e5a4ec25d3d95d72bafd2781 ] If we get a transport event, set the error and mark the init as complete so the attempt to send crq-init or login fail sooner rather than wait for the timeout. Fixes: bbd669a868bb ("ibmvnic: Fix completion structure initialization") Signed-off-by: Sukadev Bhattiprolu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/ibm/ibmvnic.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index f07468316656..1afb31c9ed7b 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -4931,6 +4931,13 @@ static void ibmvnic_handle_crq(union ibmvnic_crq *crq, adapter->fw_done_rc = -EIO; complete(&adapter->fw_done); } + + /* if we got here during crq-init, retry crq-init */ + if (!completion_done(&adapter->init_done)) { + adapter->init_done_rc = -EAGAIN; + complete(&adapter->init_done); + } + if (!completion_done(&adapter->stats_done)) complete(&adapter->stats_done); if (test_bit(0, &adapter->resetting)) -- 2.34.1