Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1796818pxp; Mon, 7 Mar 2022 02:33:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJyKg4k5r2G8cchgAw6PeVneGtsaKfuezD6yv5LtkkrFg+oIuxMDdheJredX7Nz+mhsmw0sS X-Received: by 2002:a17:902:bf07:b0:150:9b8a:a14f with SMTP id bi7-20020a170902bf0700b001509b8aa14fmr11406400plb.127.1646649197130; Mon, 07 Mar 2022 02:33:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646649197; cv=none; d=google.com; s=arc-20160816; b=vlEq/7cINcEcL9tEXEWyJlgeT0Ggg3Z+F/1pADyEICZl3D5Z7InzryFALx+4eGmWP2 rLnmq2KiQXA3kyVd8V8O+bMvGW71QuumjbWybwXiicjiUOPQSH36HPA43R1tGTg10Nvp H6rGXxFgT7rkJW4nmrPFjo5CMkXOZPC+CVJiU7W4VPZhI2MYb3/lrkQ1kRxiI0FNLy4F 1JP6yVJpMn1/7wvrdrtGWLk/OnQQL12fYrUM8TYyI7Q9c2bfwiEjZdW792cLVLRlZSYt cZcUl3wYexIiJ+Jjktj2VW1laujKpwLmqUF63Ld0Zwoft/LvUGLgCtVG2GOrzUJd3eQD fpDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5G9d6Kno/6PCGTKzWZBmuiLdtb5aeaHnRXWV520HwMA=; b=x/CaAU2Oq2heoDLo5AUAgy2uvzIzbgRoQyF6Nrp9YsJj7u+pP30gDCkZRtAUZRGaPO ERIFEaaSIjXGQdmpGt4OA1e0ln9IOCmYidJBNp49WSU/H5BwjXObyEqaqULr28tbZQP0 Zsy/UQCSwaGZsHI2p5M08FoHMlPb1I01qWahHRJvGIsoI5+3eMu/y9qcWkL8/YUxm5wF 0rv9hiUB5vu5tV8nnP5kdIWliZA6ozSRUrweT3scgvbxIwhjQu1dFCHZLSjxTU63FHlE Y8xFeqbgTJ/vr6z8tw+NYeVCuqEjf3d0eOmPZ6QlxzWgb/bs3N1uIqHkEV6wo9fW5DMU 3T3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=A822l9Ea; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s14-20020a056a00178e00b004f124e36301si13256694pfg.77.2022.03.07.02.33.02; Mon, 07 Mar 2022 02:33:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=A822l9Ea; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240115AbiCGKE6 (ORCPT + 99 others); Mon, 7 Mar 2022 05:04:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236508AbiCGJmC (ORCPT ); Mon, 7 Mar 2022 04:42:02 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B878422A; Mon, 7 Mar 2022 01:41:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 306ADCE0EAA; Mon, 7 Mar 2022 09:41:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1194C340E9; Mon, 7 Mar 2022 09:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646646065; bh=w3xW6sXuqTAEkeMEks1u2RQfpbj9vS7RE95tWEHFmkY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A822l9Ea7/jXUa12UqALbJC5bfmtT4HvWQebdARmsHdi9mgRkEt4ui1ythMajKuFH xDNglMeWvveSDtVm55M6dq4EPeSEXKjZPjMuL/mqtb7rM2ELQhJ+ennoCqwdfiIiOx xz4u/DlDufOqz3dTkFvomr3XUhoowrBbraZWtDTw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tao Liu , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 121/262] gve: Recording rx queue before sending to napi Date: Mon, 7 Mar 2022 10:17:45 +0100 Message-Id: <20220307091705.877888655@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220307091702.378509770@linuxfoundation.org> References: <20220307091702.378509770@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tao Liu [ Upstream commit 084cbb2ec3af2d23be9de65fcc9493e21e265859 ] This caused a significant performance degredation when using generic XDP with multiple queues. Fixes: f5cedc84a30d2 ("gve: Add transmit and receive support") Signed-off-by: Tao Liu Link: https://lore.kernel.org/r/20220207175901.2486596-1-jeroendb@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/google/gve/gve_rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c index 629d8ed08fc61..97431969a488f 100644 --- a/drivers/net/ethernet/google/gve/gve_rx.c +++ b/drivers/net/ethernet/google/gve/gve_rx.c @@ -450,6 +450,7 @@ static bool gve_rx(struct gve_rx_ring *rx, struct gve_rx_desc *rx_desc, skb_set_hash(skb, be32_to_cpu(rx_desc->rss_hash), gve_rss_type(rx_desc->flags_seq)); + skb_record_rx_queue(skb, rx->q_num); if (skb_is_nonlinear(skb)) napi_gro_frags(napi); else -- 2.34.1