Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <ben.widawsky@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kael_w@qq.com, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] cxl/core/port: fix NULL but dereferenced coccicheck error
Date:   Mon,  7 Mar 2022 17:41:48 +0800
Message-Id: <20220307094158.404882-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?To6aVpMwae3Amw4SB/kuE8oY00NY5iN4ag18Pn4vNKXo50J2yvAkkaS5n++0?=
 =?us-ascii?Q?Y/okb9u+2ekeKFEs0c1jY0pmrIUKBDYAPbn4rQ/SLCHFlX42qkXbTkQgJUng?=
 =?us-ascii?Q?8Er070DfxOOkXPceymAIRF0xqMd7e74FVEU3P5ZOHS4vA4iShKK8jTR8i/oO?=
 =?us-ascii?Q?iw0mt2hTig/HkFP2G3r9yBCPYVeWAz6r5dUNrbDET6akDfsYx7YydFP216JL?=
 =?us-ascii?Q?Z6jhMZlP+p/6Q23JVV2CGlaiEo5tRderyiBRqnfVBTjC65dfPyCr6Y1m0rhh?=
 =?us-ascii?Q?6x4R+zYQjw46Kbdx34nukrO9PCnJP4GwGArSPt2JMlkiCJZY8ZKIc3dMG8xT?=
 =?us-ascii?Q?4B6SnqtJE9OtDHX2UVJ6qmBkeyXPJ80Rph83SkTbE/fQwJxgFeYNjEATbDt0?=
 =?us-ascii?Q?g4duNwyXx6CDjPDU3c+9bca4ZNfXiSxBKMUCtleqFLPFwvM3G2Oopo/CNVFq?=
 =?us-ascii?Q?HyJk1+kIkbETWtQRdelz6Huq0fvpp1lOCS7nvCdOhW1RD30zMODW20dkb9fa?=
 =?us-ascii?Q?NcrL49i6/y4QAcF6eQJmzM5pZxhGxSBL5uE3mN5zb7Xp15qGeNSGHSWzQoJd?=
 =?us-ascii?Q?HzvlI1Yf3AyZfIqHHnYOeD/SZVMEo1HzBlHTRgPyssQbWIWF1R/0vS7w6DgH?=
 =?us-ascii?Q?uahw4777HkYgMpsAm+PHAo3zcNxvs8Q4W8aIwj6if2vocvVDWiXDAazjHGA5?=
 =?us-ascii?Q?HWW/dEATexNulZ6um25Twco+/HnUFvxKz1eB8MuptDhd1L285+YQx1SnqnfQ?=
 =?us-ascii?Q?bPL9xVShgOaUHR2wnjEZpPKpOfwkrL9BF5g2quYO0gCzM4BLZ+HsJs//HI4/?=
 =?us-ascii?Q?lAHNnC92rt8ZYVi7/Y8lbejfVbf4PZk3BZ3hrnNKg3rLBopIJpCA3+JzDZaY?=
 =?us-ascii?Q?YSEK3iWkt2GfPrEluO9dpGMezWDlYB8k1bqQ6P4xNy645zFM9XmaH5Lb/8kn?=
 =?us-ascii?Q?RrGWL9xS2MLB44BlK7AnlBvODLXGyk1WaJB6ZUJmeREcsMUviwJ7bs1olZbP?=
 =?us-ascii?Q?XkgcopWHXEIkOwFvrcPEEPwznwIa7nAqOIze213ED8GN0kqvGKH4Flmxrcis?=
 =?us-ascii?Q?8YmFNltjGBZqzbrD9NQnw/VwfhJ+chJz1SBDcOMnCcG6Wnr3xNLvAeYwAqBH?=
 =?us-ascii?Q?Hed84VXWSeJQNhirYdnboTfif5q2LEVJw51trN0U4alfRNULw0o9ZxOzWGLy?=
 =?us-ascii?Q?PYEgVA3/LwdGOaSO5OWa5ZsaLMuR3Ba0J27g9hlf+mpMQoXjNTJdD03j1F/n?=
 =?us-ascii?Q?3uxvL4NqCC69n1sbvQREmyrgOBsQgLkTOHozWxrR1gr+enIXuYSWGcAPOamP?=
 =?us-ascii?Q?tkc+zgF4+QkkBOTmxSY8YmefxELrXyjDD1D8xRsblkXBmOUNB5XQJNOay2Si?=
 =?us-ascii?Q?OKDNzpIVhxlQ/qzB/W3Mb/I/NxpCGxWmpPqL5/HxUlrkzHtpV8BwSSZ8fttW?=
 =?us-ascii?Q?VmBF1D4JJoQyGGWxUbXMx4UsfGXkfafEQE6YC8zN9Uybp6u4jR1gi6Do1Q5x?=
 =?us-ascii?Q?KemcIrMqVFEY7dI+va50Un+nHK8OXSI9cmjxGAwQeJAg8acXrqtAuyAIoAM7?=
 =?us-ascii?Q?8CzV5UER8NfwShtzz3Q3tOAkBeFan7+BnYAZwmHI0F7fp4ePE9pJSMeTqkjR?=
 =?us-ascii?Q?Qk8hJywU7vPEx6QXBFxrTY8=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a246a15b-590f-47a8-39a5-08da001edeeb
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 09:43:01.9853
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yaJ5QkS73+xrTiX3R+7N2RSk2RwsqBn9/Hwxm4UupQJL26cELkQndHyrmj7OFgEwpowzi5/p+fh/Y8aBiPZqsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4094
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix the following coccicheck warning:
./drivers/cxl/core/port.c:913:21-24: ERROR: port is NULL but dereferenced.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/cxl/core/port.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
index d29eb2abdbc2..3349e9f7b89e 100644
--- a/drivers/cxl/core/port.c
+++ b/drivers/cxl/core/port.c
@@ -909,7 +909,10 @@ static void cxl_detach_ep(void *data)
 			break;
 
 		port = find_cxl_port(dport_dev);
-		if (!port || is_cxl_root(port)) {
+		if (!port)
+			continue;
+
+		if (is_cxl_root(port)) {
 			put_device(&port->dev);
 			continue;
 		}
-- 
2.35.1