Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1800655pxp; Mon, 7 Mar 2022 02:39:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJyn8n6NoZEa6weWFUD+Ar6FioBF46mxxIsLBuA3bhmwZU+ixb6YuQ0garE7hyAlkfarHqF6 X-Received: by 2002:a17:902:d486:b0:151:8e66:621c with SMTP id c6-20020a170902d48600b001518e66621cmr11352975plg.141.1646649568123; Mon, 07 Mar 2022 02:39:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646649568; cv=none; d=google.com; s=arc-20160816; b=y92/lSBE75K/RZtemZCmzypK+WSFcJ72G02qqFHwgCSSbMGeZZ8+P0nizKS4Ye3ZOt S/wnr12migm6fBelKa5IGmSfQxCtxZwbpCULemkuINbDgFtImY7Lv5a0r/Oxvxl4jwmY +81Nm3Y/nujpSeZgWdlfRe2kgVLBIxIF+sDlRfeocgUX3YjWhbKiD4VYzpyz4bufMRmS S8s/MjDQqrixAQA0fgcOxnWbnDvyr1OM9cwzqyps247EBKm/6GTvDO+2WKOqpw6sFaCq bFBf7wrx5Kd5PAuPQhOS/b26/h+wAn2N497p/JLvFJF92svE+iV76B1BQTpNwvaGjNH7 /gwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3jq9BVcSqOjT5eJ7YaXlXy7xNo6YrnVDWpCoBS5wCL8=; b=w59A/sZ4Gdpj+0pVOImjD7hTzNjbKbH95J0VaQvBJ+XPkj5xOYX+Cxxh1ST0U/7W7W uZZgyeeYiq4PhnhCjWqMCZVBduITyTki9InYlbX/o8q5XinjIqO7X+ASoQgwZ6xBG2x8 VguXT8FgMYHmNvWPNCDatiX2NqqOXmIARGhmLM3iJRSju3hrC/B5KtDkhEAKKJQ3Anyn Y4FisaNFQdPxHMqMOZl4UNVpkRTDv2ze3pno2uvpGtjsy6mx2JqQfMD3Ue0NHG5TRBP4 Y8XdriuGedTiwnlQRDSVa7AZIy027+UDrxU/6qr5uAjXld8VeLB426ZdhWqoPLNphaCL fiaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Yv+hoj+m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a63fd01000000b00380472379dbsi2716314pgh.424.2022.03.07.02.38.58; Mon, 07 Mar 2022 02:39:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Yv+hoj+m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241535AbiCGKKT (ORCPT + 99 others); Mon, 7 Mar 2022 05:10:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240394AbiCGJu7 (ORCPT ); Mon, 7 Mar 2022 04:50:59 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EE4274855; Mon, 7 Mar 2022 01:44:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3892A60FB3; Mon, 7 Mar 2022 09:44:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44F37C340F3; Mon, 7 Mar 2022 09:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646646268; bh=ZdNObHiYHnzSCAvNC2nWvjr0DzK6YzERh5u9K+IXs9U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yv+hoj+mlGE7FRFih5vB72IJXiQaJ1R7lvtDGu/mElBsCOZAOIOLeH1A48irLSJXG 7yC7kV67WbKB4IDAcmt3B3keT4EIu5/0910scI8koVBPD4bzJqbazgivSMgrHmVlaY uR3+lfYbOWURKmcwbkXGcXvKfS4YHt2TY5sTWGQs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Thierry Reding , Joerg Roedel Subject: [PATCH 5.15 189/262] iommu/tegra-smmu: Fix missing put_device() call in tegra_smmu_find Date: Mon, 7 Mar 2022 10:18:53 +0100 Message-Id: <20220307091707.838104146@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220307091702.378509770@linuxfoundation.org> References: <20220307091702.378509770@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin commit 9826e393e4a8c3df474e7f9eacd3087266f74005 upstream. The reference taken by 'of_find_device_by_node()' must be released when not needed anymore. Add the corresponding 'put_device()' in the error handling path. Fixes: 765a9d1d02b2 ("iommu/tegra-smmu: Fix mc errors on tegra124-nyan") Signed-off-by: Miaoqian Lin Acked-by: Thierry Reding Link: https://lore.kernel.org/r/20220107080915.12686-1-linmq006@gmail.com Signed-off-by: Joerg Roedel Signed-off-by: Greg Kroah-Hartman --- drivers/iommu/tegra-smmu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/iommu/tegra-smmu.c +++ b/drivers/iommu/tegra-smmu.c @@ -808,8 +808,10 @@ static struct tegra_smmu *tegra_smmu_fin return NULL; mc = platform_get_drvdata(pdev); - if (!mc) + if (!mc) { + put_device(&pdev->dev); return NULL; + } return mc->smmu; }