Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1803644pxp; Mon, 7 Mar 2022 02:43:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJzT6z9XJEmqH8TYeJyEhmtHv6UgfmdE9M7D6j6Fm6PsYFIqRb0ejV0dxRtjVu+3Yx1QoY9v X-Received: by 2002:a17:906:2899:b0:6d6:e479:1fe2 with SMTP id o25-20020a170906289900b006d6e4791fe2mr8618099ejd.394.1646649820905; Mon, 07 Mar 2022 02:43:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646649820; cv=none; d=google.com; s=arc-20160816; b=e2wr1b/fL8g7djso3/6NWVSW1K7+ql/jUvQoECaUcpuQ661MP71pHWZ0uLuWA8TTIX 0p7SGke1BwBhd+ynpW8N/MfMEqdo13/8I0D49n4fT2rDXeupTE34tgUw9FQm0HWmW8SU i4+czuCm5pfLGU1spvKTs2F0jbAEEdEvE4dXUx1i41Z/dUgVJe+DRxVVTJNyNTYjDJ7S osmLLaadwRAuLlsqhBI7mkT0WWUhJ95oKaSjhBN6rlpLys3/MdFxswZuqWS1wxioCOlI bfrCzG7MyXJcMhMAov8/KifwV63NkEJ2GhLT/wUx+g5IadtyOnH+jQn25QN9pfENj1QP +naQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Q38Gu0C5vl1eitAB4EbVMqLPyw25ITWN0ovCtYeKlTY=; b=mFtIvgqz/HVu26qcEsi9fNSJPQyFpyd1DV98smEMqWw/NRXBX/wLn3ad6sx1uPGYyI /8vHn98rFaGpQ99az9RASvxI/EVukakpMPjfwrPTMKTSSASRmjWE5NajMqIJWhFO7j7b jzB3TYT60WFw8arZ5YGd4Og9QaeoqSt1Ch7NUUmxVEXtbpJpSZwBwLTDX7JDMcf5qQ1c p2HCclRAbOzJipNxFQhHxx1/j0Dlw/sD7d7ZzZoWPpO5KJcH3cGvK60yASEIVk+yTbyY lRFCC8pdSJ+h/SdMP4lfCzlT2zTyJVozW80MIjcu1BZs4AjfOVYGkKpAmlYSuPXudZq7 n9Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pqZnwnYy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t13-20020a170906178d00b006cf9c53ba53si7289917eje.419.2022.03.07.02.43.18; Mon, 07 Mar 2022 02:43:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pqZnwnYy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239160AbiCGKQC (ORCPT + 99 others); Mon, 7 Mar 2022 05:16:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240232AbiCGKAu (ORCPT ); Mon, 7 Mar 2022 05:00:50 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C09CD7E5A1; Mon, 7 Mar 2022 01:47:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7886DB80E70; Mon, 7 Mar 2022 09:47:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6D64C340F3; Mon, 7 Mar 2022 09:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646646428; bh=hT2zHLkoZCpWjRb1PC58VKi41C7bjI8tcXNAs9bR/LI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pqZnwnYyxsS2Hz3wOBwegReNsF5dLz26J0k7QR6ov+McG/WPdCRvT3Qr1hPLdzKdg OHws2O9t8KFQCcLsYYZgmcLojE80oQQziGhqEPz0Xw+jUKFbZrfuj1JeOhsRE+P+me ehgi2MvDaBzrro4nxu3n3BIVRSmxWruVSSYhyDnc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Christian=20K=C3=B6nig?= , Qiang Yu , Alex Deucher , Sasha Levin Subject: [PATCH 5.15 240/262] drm/amdgpu: fix suspend/resume hang regression Date: Mon, 7 Mar 2022 10:19:44 +0100 Message-Id: <20220307091710.191847128@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220307091702.378509770@linuxfoundation.org> References: <20220307091702.378509770@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiang Yu [ Upstream commit f1ef17011c765495c876fa75435e59eecfdc1ee4 ] Regression has been reported that suspend/resume may hang with the previous vm ready check commit. So bring back the evicted list check as a temp fix. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1922 Fixes: c1a66c3bc425 ("drm/amdgpu: check vm ready by amdgpu_vm->evicting flag") Reviewed-by: Christian König Signed-off-by: Qiang Yu Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index a33cb2f4d744..fd37bb39774c 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -777,7 +777,8 @@ bool amdgpu_vm_ready(struct amdgpu_vm *vm) amdgpu_vm_eviction_lock(vm); ret = !vm->evicting; amdgpu_vm_eviction_unlock(vm); - return ret; + + return ret && list_empty(&vm->evicted); } /** -- 2.34.1